* [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc, free}_attrs
@ 2013-04-22 5:09 ` Damian Hobson-Garcia
0 siblings, 0 replies; 6+ messages in thread
From: Damian Hobson-Garcia @ 2013-04-22 5:09 UTC (permalink / raw)
To: linux-arm-kernel
Most architectures that define CONFIG_HAVE_DMA, have implementations for
both dma_alloc_attrs() and dma_free_attrs(). All achitectures that do
not define CONFIG_HAVE_DMA also have both of these definitions provided by
dma-mapping-broken.h.
Add default implementations for these functions on arm64.
Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
---
arch/arm64/include/asm/dma-mapping.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
index 9947768..65ab181 100644
--- a/arch/arm64/include/asm/dma-mapping.h
+++ b/arch/arm64/include/asm/dma-mapping.h
@@ -81,6 +81,9 @@ static inline void dma_mark_clean(void *addr, size_t size)
{
}
+#define dma_alloc_attrs(d, s, h, f, a) dma_alloc_coherent(d, s, h, f)
+#define dma_free_attrs(d, s, h, f, a) dma_free_coherent(d, s, h, f)
+
static inline void *dma_alloc_coherent(struct device *dev, size_t size,
dma_addr_t *dma_handle, gfp_t flags)
{
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc,free}_attrs
@ 2013-04-22 5:09 ` Damian Hobson-Garcia
0 siblings, 0 replies; 6+ messages in thread
From: Damian Hobson-Garcia @ 2013-04-22 5:09 UTC (permalink / raw)
To: linux-kernel
Cc: catalin.marinas, will.deacon, linux-arm-kernel,
Damian Hobson-Garcia
Most architectures that define CONFIG_HAVE_DMA, have implementations for
both dma_alloc_attrs() and dma_free_attrs(). All achitectures that do
not define CONFIG_HAVE_DMA also have both of these definitions provided by
dma-mapping-broken.h.
Add default implementations for these functions on arm64.
Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
---
arch/arm64/include/asm/dma-mapping.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
index 9947768..65ab181 100644
--- a/arch/arm64/include/asm/dma-mapping.h
+++ b/arch/arm64/include/asm/dma-mapping.h
@@ -81,6 +81,9 @@ static inline void dma_mark_clean(void *addr, size_t size)
{
}
+#define dma_alloc_attrs(d, s, h, f, a) dma_alloc_coherent(d, s, h, f)
+#define dma_free_attrs(d, s, h, f, a) dma_free_coherent(d, s, h, f)
+
static inline void *dma_alloc_coherent(struct device *dev, size_t size,
dma_addr_t *dma_handle, gfp_t flags)
{
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc, free}_attrs
2013-04-22 5:09 ` [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc,free}_attrs Damian Hobson-Garcia
@ 2013-04-22 6:11 ` Lars-Peter Clausen
-1 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2013-04-22 6:11 UTC (permalink / raw)
To: linux-arm-kernel
On 04/22/2013 07:09 AM, Damian Hobson-Garcia wrote:
> Most architectures that define CONFIG_HAVE_DMA, have implementations for
> both dma_alloc_attrs() and dma_free_attrs(). All achitectures that do
> not define CONFIG_HAVE_DMA also have both of these definitions provided by
> dma-mapping-broken.h.
>
> Add default implementations for these functions on arm64.
>
> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
> ---
> arch/arm64/include/asm/dma-mapping.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
> index 9947768..65ab181 100644
> --- a/arch/arm64/include/asm/dma-mapping.h
> +++ b/arch/arm64/include/asm/dma-mapping.h
> @@ -81,6 +81,9 @@ static inline void dma_mark_clean(void *addr, size_t size)
> {
> }
>
> +#define dma_alloc_attrs(d, s, h, f, a) dma_alloc_coherent(d, s, h, f)
> +#define dma_free_attrs(d, s, h, f, a) dma_free_coherent(d, s, h, f)
> +
> static inline void *dma_alloc_coherent(struct device *dev, size_t size,
> dma_addr_t *dma_handle, gfp_t flags)
> {
The other way around would be better, properly implement
dma_{alloc,free}_attrs and implement dma_{alloc,free}_coherent on top of
the. E.g. you are supposed to pass the attrs parameter to ops->alloc and
ops->free instead of NULL. And it will also allow us to move
dma_{alloc,free}_coherent to asm-generic/dma-mapping-common.h eventually.
- Lars
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc, free}_attrs
@ 2013-04-22 6:11 ` Lars-Peter Clausen
0 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2013-04-22 6:11 UTC (permalink / raw)
To: Damian Hobson-Garcia
Cc: linux-kernel, catalin.marinas, will.deacon, linux-arm-kernel
On 04/22/2013 07:09 AM, Damian Hobson-Garcia wrote:
> Most architectures that define CONFIG_HAVE_DMA, have implementations for
> both dma_alloc_attrs() and dma_free_attrs(). All achitectures that do
> not define CONFIG_HAVE_DMA also have both of these definitions provided by
> dma-mapping-broken.h.
>
> Add default implementations for these functions on arm64.
>
> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
> ---
> arch/arm64/include/asm/dma-mapping.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
> index 9947768..65ab181 100644
> --- a/arch/arm64/include/asm/dma-mapping.h
> +++ b/arch/arm64/include/asm/dma-mapping.h
> @@ -81,6 +81,9 @@ static inline void dma_mark_clean(void *addr, size_t size)
> {
> }
>
> +#define dma_alloc_attrs(d, s, h, f, a) dma_alloc_coherent(d, s, h, f)
> +#define dma_free_attrs(d, s, h, f, a) dma_free_coherent(d, s, h, f)
> +
> static inline void *dma_alloc_coherent(struct device *dev, size_t size,
> dma_addr_t *dma_handle, gfp_t flags)
> {
The other way around would be better, properly implement
dma_{alloc,free}_attrs and implement dma_{alloc,free}_coherent on top of
the. E.g. you are supposed to pass the attrs parameter to ops->alloc and
ops->free instead of NULL. And it will also allow us to move
dma_{alloc,free}_coherent to asm-generic/dma-mapping-common.h eventually.
- Lars
^ permalink raw reply [flat|nested] 6+ messages in thread* [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc, free}_attrs
2013-04-22 6:11 ` Lars-Peter Clausen
@ 2013-04-23 3:41 ` Damian Hobson-Garcia
-1 siblings, 0 replies; 6+ messages in thread
From: Damian Hobson-Garcia @ 2013-04-23 3:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Lars,
On 2013/04/22 15:11, Lars-Peter Clausen wrote:
> On 04/22/2013 07:09 AM, Damian Hobson-Garcia wrote:
>> Most architectures that define CONFIG_HAVE_DMA, have implementations for
>> both dma_alloc_attrs() and dma_free_attrs(). All achitectures that do
>> not define CONFIG_HAVE_DMA also have both of these definitions provided by
>> dma-mapping-broken.h.
>>
>> Add default implementations for these functions on arm64.
>>
>> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
>> ---
>> arch/arm64/include/asm/dma-mapping.h | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
>> index 9947768..65ab181 100644
>> --- a/arch/arm64/include/asm/dma-mapping.h
>> +++ b/arch/arm64/include/asm/dma-mapping.h
>> @@ -81,6 +81,9 @@ static inline void dma_mark_clean(void *addr, size_t size)
>> {
>> }
>>
>> +#define dma_alloc_attrs(d, s, h, f, a) dma_alloc_coherent(d, s, h, f)
>> +#define dma_free_attrs(d, s, h, f, a) dma_free_coherent(d, s, h, f)
>> +
>> static inline void *dma_alloc_coherent(struct device *dev, size_t size,
>> dma_addr_t *dma_handle, gfp_t flags)
>> {
>
> The other way around would be better, properly implement
> dma_{alloc,free}_attrs and implement dma_{alloc,free}_coherent on top of
> the. E.g. you are supposed to pass the attrs parameter to ops->alloc and
> ops->free instead of NULL. And it will also allow us to move
> dma_{alloc,free}_coherent to asm-generic/dma-mapping-common.h eventually.
Ok, makes sense. I'll update this for archs that are using dma_map_ops
(arm64 and s390).
Thanks,
Damian
>
> - Lars
>
--
Damian Hobson-Garcia
IGEL Co.,Ltd
http://www.igel.co.jp
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc, free}_attrs
@ 2013-04-23 3:41 ` Damian Hobson-Garcia
0 siblings, 0 replies; 6+ messages in thread
From: Damian Hobson-Garcia @ 2013-04-23 3:41 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: linux-kernel, catalin.marinas, will.deacon, linux-arm-kernel
Hi Lars,
On 2013/04/22 15:11, Lars-Peter Clausen wrote:
> On 04/22/2013 07:09 AM, Damian Hobson-Garcia wrote:
>> Most architectures that define CONFIG_HAVE_DMA, have implementations for
>> both dma_alloc_attrs() and dma_free_attrs(). All achitectures that do
>> not define CONFIG_HAVE_DMA also have both of these definitions provided by
>> dma-mapping-broken.h.
>>
>> Add default implementations for these functions on arm64.
>>
>> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
>> ---
>> arch/arm64/include/asm/dma-mapping.h | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
>> index 9947768..65ab181 100644
>> --- a/arch/arm64/include/asm/dma-mapping.h
>> +++ b/arch/arm64/include/asm/dma-mapping.h
>> @@ -81,6 +81,9 @@ static inline void dma_mark_clean(void *addr, size_t size)
>> {
>> }
>>
>> +#define dma_alloc_attrs(d, s, h, f, a) dma_alloc_coherent(d, s, h, f)
>> +#define dma_free_attrs(d, s, h, f, a) dma_free_coherent(d, s, h, f)
>> +
>> static inline void *dma_alloc_coherent(struct device *dev, size_t size,
>> dma_addr_t *dma_handle, gfp_t flags)
>> {
>
> The other way around would be better, properly implement
> dma_{alloc,free}_attrs and implement dma_{alloc,free}_coherent on top of
> the. E.g. you are supposed to pass the attrs parameter to ops->alloc and
> ops->free instead of NULL. And it will also allow us to move
> dma_{alloc,free}_coherent to asm-generic/dma-mapping-common.h eventually.
Ok, makes sense. I'll update this for archs that are using dma_map_ops
(arm64 and s390).
Thanks,
Damian
>
> - Lars
>
--
Damian Hobson-Garcia
IGEL Co.,Ltd
http://www.igel.co.jp
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-23 3:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-22 5:09 [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc, free}_attrs Damian Hobson-Garcia
2013-04-22 5:09 ` [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc,free}_attrs Damian Hobson-Garcia
2013-04-22 6:11 ` [RFC/PATCH 1/4] arm64: Provide default implementation for dma_{alloc, free}_attrs Lars-Peter Clausen
2013-04-22 6:11 ` Lars-Peter Clausen
2013-04-23 3:41 ` Damian Hobson-Garcia
2013-04-23 3:41 ` Damian Hobson-Garcia
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.