All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
	linux-kernel@vger.kernel.org, dedekind1@gmail.com
Subject: Re: [PATCH v2 3/8] mtd: get the ECC info from the Extended Parameter Page
Date: Tue, 23 Apr 2013 14:15:56 +0800	[thread overview]
Message-ID: <5176271C.7030304@freescale.com> (raw)
In-Reply-To: <CAN8TOE_xOBTv7weAqYinFMmTStXgY93KanV-jDAqFnY=CEfkdQ@mail.gmail.com>

于 2013年04月23日 05:22, Brian Norris 写道:
> You never sent a command to the chip. How can you expect to read from it?
>
> It seems that you are writing this function with the assumption of a
> particular calling context (a context in which the last command was
> CMD_PARAM). IMO, it would make a lot more sense that this function
> actually send its own CMD_PARAM followed by either X bytes of skipped
> read_buf() or a change read column command. Then it doesn't need the
> "last" argument, and its usage makes much more sense.
>
I finally find why i can not use the CHANGE READ COLUMN command:

When we detect the ONFI nand, we actually use the nand_command() to 
issue the command which
does not works with CHANGE READ COLUMN command.

I use the nand_command_lp() to issue the CHANGE READ COLUMN command, it 
works fine.

I can remove the "last" argument now.

thanks Brian.

Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <dwmw2@infradead.org>, <dedekind1@gmail.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/8] mtd: get the ECC info from the Extended Parameter Page
Date: Tue, 23 Apr 2013 14:15:56 +0800	[thread overview]
Message-ID: <5176271C.7030304@freescale.com> (raw)
In-Reply-To: <CAN8TOE_xOBTv7weAqYinFMmTStXgY93KanV-jDAqFnY=CEfkdQ@mail.gmail.com>

于 2013年04月23日 05:22, Brian Norris 写道:
> You never sent a command to the chip. How can you expect to read from it?
>
> It seems that you are writing this function with the assumption of a
> particular calling context (a context in which the last command was
> CMD_PARAM). IMO, it would make a lot more sense that this function
> actually send its own CMD_PARAM followed by either X bytes of skipped
> read_buf() or a change read column command. Then it doesn't need the
> "last" argument, and its usage makes much more sense.
>
I finally find why i can not use the CHANGE READ COLUMN command:

When we detect the ONFI nand, we actually use the nand_command() to 
issue the command which
does not works with CHANGE READ COLUMN command.

I use the nand_command_lp() to issue the CHANGE READ COLUMN command, it 
works fine.

I can remove the "last" argument now.

thanks Brian.

Huang Shijie


  parent reply	other threads:[~2013-04-23  6:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22  7:47 [PATCH v2 0/8] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-04-22  7:47 ` Huang Shijie
2013-04-22  7:47 ` [PATCH v2 1/8] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-04-22  7:47   ` Huang Shijie
2013-04-22  7:47 ` [PATCH v2 2/8] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-04-22  7:47   ` Huang Shijie
2013-04-22 21:04   ` Brian Norris
2013-04-22 21:04     ` Brian Norris
2013-04-23  2:49     ` Huang Shijie
2013-04-23  2:49       ` Huang Shijie
2013-04-22  7:47 ` [PATCH v2 3/8] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-04-22  7:47   ` Huang Shijie
2013-04-22 21:22   ` Brian Norris
2013-04-22 21:22     ` Brian Norris
2013-04-23  2:43     ` Huang Shijie
2013-04-23  2:43       ` Huang Shijie
2013-04-23  7:06       ` Brian Norris
2013-04-23  7:06         ` Brian Norris
2013-04-23  6:15     ` Huang Shijie [this message]
2013-04-23  6:15       ` Huang Shijie
2013-04-22  7:47 ` [PATCH v2 4/8] mtd: replace the hardcode with the onfi_get_feature() Huang Shijie
2013-04-22  7:47   ` Huang Shijie
2013-04-22  8:09   ` [PATCH v2] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-04-22  7:47 ` [PATCH v2 5/8] mtd: add a new field for ecc info in the nand_flash_dev{} Huang Shijie
2013-04-22  7:47   ` Huang Shijie
2013-04-22  7:47 ` [PATCH v2 6/8] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-04-22  7:47   ` Huang Shijie
2013-04-22  7:47 ` [PATCH v2 7/8] mtd: add the ecc info for some " Huang Shijie
2013-04-22  7:47   ` Huang Shijie
2013-04-22  7:47 ` [PATCH v2 8/8] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
2013-04-22  7:47   ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5176271C.7030304@freescale.com \
    --to=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.