From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: balbi@ti.com
Cc: Sourav Poddar <sourav.poddar@ti.com>,
gregkh@linuxfoundation.org, tony@atomide.com,
rmk+kernel@arm.linux.org.uk, khilman@linaro.org,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Rajendra nayak <rnayak@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [RFC/PATCHv2 5/5] arm: omap2+: omap_device: remove no_idle_on_suspend
Date: Tue, 23 Apr 2013 09:13:39 +0200 [thread overview]
Message-ID: <517634A3.30104@ti.com> (raw)
In-Reply-To: <20130422143839.GE7508@arwen.pp.htv.fi>
Hi,
On 04/22/2013 04:38 PM, Felipe Balbi wrote:
>> Is it possible to handle ABE no_idle_on_suspend uscase the way I am
>> trying to handle it for UART in the 2nd patch of this series?
>
> let's ask Péter.
>
> Péter, OMAP_DEVICE_NO_IDLE_ON_SUSPEND should be removed as driver's can
> get same behavior by just returning -EBUSY from their ->runtime_suspend
> callbacks. Do you see any problems with patch below (left for
> reference) ? Would it be too difficult to add
> ->runtime_suspend/->runtime_resume on ASoC layer ?
I don't see any issue with this. FWIW AESS/ABE does not use the
OMAP_DEVICE_NO_IDLE_ON_SUSPEND flag neither in upstream nor in my development
branch.
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <balbi@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
<gregkh@linuxfoundation.org>, <tony@atomide.com>,
<rmk+kernel@arm.linux.org.uk>, <khilman@linaro.org>,
<linux-serial@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Rajendra nayak <rnayak@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [RFC/PATCHv2 5/5] arm: omap2+: omap_device: remove no_idle_on_suspend
Date: Tue, 23 Apr 2013 09:13:39 +0200 [thread overview]
Message-ID: <517634A3.30104@ti.com> (raw)
In-Reply-To: <20130422143839.GE7508@arwen.pp.htv.fi>
Hi,
On 04/22/2013 04:38 PM, Felipe Balbi wrote:
>> Is it possible to handle ABE no_idle_on_suspend uscase the way I am
>> trying to handle it for UART in the 2nd patch of this series?
>
> let's ask Péter.
>
> Péter, OMAP_DEVICE_NO_IDLE_ON_SUSPEND should be removed as driver's can
> get same behavior by just returning -EBUSY from their ->runtime_suspend
> callbacks. Do you see any problems with patch below (left for
> reference) ? Would it be too difficult to add
> ->runtime_suspend/->runtime_resume on ASoC layer ?
I don't see any issue with this. FWIW AESS/ABE does not use the
OMAP_DEVICE_NO_IDLE_ON_SUSPEND flag neither in upstream nor in my development
branch.
--
Péter
next prev parent reply other threads:[~2013-04-23 7:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 13:43 [PATCHv2 0/5] Serial Omap fixes and cleanups Sourav Poddar
2013-04-22 13:43 ` Sourav Poddar
2013-04-22 13:43 ` [PATCHv2 1/5] driver: tty: serial: Move "uart_console" def to core header file Sourav Poddar
2013-04-22 13:43 ` Sourav Poddar
2013-04-22 14:30 ` Felipe Balbi
2013-04-22 14:30 ` Felipe Balbi
2013-04-22 13:43 ` [PATCHv2 2/5] driver: serial: omap: prevent runtime PM for "no_console_suspend" Sourav Poddar
2013-04-22 13:43 ` Sourav Poddar
2013-04-22 14:31 ` Felipe Balbi
2013-04-22 14:31 ` Felipe Balbi
2013-04-23 4:52 ` Sourav Poddar
2013-04-23 4:52 ` Sourav Poddar
2013-04-22 14:48 ` Grygorii Strashko
2013-04-22 14:48 ` Grygorii Strashko
2013-04-22 18:36 ` Kevin Hilman
2013-04-22 18:36 ` Kevin Hilman
2013-04-23 5:14 ` Sourav Poddar
2013-04-23 5:14 ` Sourav Poddar
2013-04-23 5:12 ` Sourav Poddar
2013-04-23 5:12 ` Sourav Poddar
2013-04-22 13:43 ` [PATCHv2 3/5] arm: omap2+: serial: remove no_console_suspend support Sourav Poddar
2013-04-22 13:43 ` Sourav Poddar
2013-04-22 14:32 ` Felipe Balbi
2013-04-22 14:32 ` Felipe Balbi
2013-04-22 13:43 ` [PATCHv2 4/5] arm: dts: am33xx: Remove "ti,no_idle_on_suspend" property Sourav Poddar
2013-04-22 13:43 ` Sourav Poddar
2013-04-22 14:35 ` Felipe Balbi
2013-04-22 14:35 ` Felipe Balbi
2013-04-23 4:53 ` Sourav Poddar
2013-04-23 4:53 ` Sourav Poddar
2013-04-22 13:43 ` [RFC/PATCHv2 5/5] arm: omap2+: omap_device: remove no_idle_on_suspend Sourav Poddar
2013-04-22 13:43 ` Sourav Poddar
2013-04-22 14:14 ` Grygorii Strashko
2013-04-22 14:14 ` Grygorii Strashko
2013-04-22 18:41 ` Kevin Hilman
2013-04-22 18:41 ` Kevin Hilman
2013-04-23 5:19 ` Sourav Poddar
2013-04-23 5:19 ` Sourav Poddar
2013-04-23 9:19 ` Grygorii Strashko
2013-04-23 9:19 ` Grygorii Strashko
2013-04-23 9:21 ` Sourav Poddar
2013-04-23 9:21 ` Sourav Poddar
2013-04-22 14:38 ` Felipe Balbi
2013-04-22 14:38 ` Felipe Balbi
2013-04-23 7:13 ` Peter Ujfalusi [this message]
2013-04-23 7:13 ` Peter Ujfalusi
2013-04-22 14:39 ` Felipe Balbi
2013-04-22 14:39 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517634A3.30104@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.