All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Scott <dave.scott@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] Only call stat() when adding a disk if we expect a device to exist.
Date: Tue, 23 Apr 2013 10:52:06 +0100	[thread overview]
Message-ID: <517659C6.40409@eu.citrix.com> (raw)
In-Reply-To: <1366710288.20256.87.camel@zakaz.uk.xensource.com>

On 23/04/13 10:44, Ian Campbell wrote:
> On Tue, 2013-04-23 at 10:36 +0100, David Scott wrote:
>> >We consider calling stat() a helpful error check in the following
>> >circumstances only:
>> >  1. the disk backend type must be PHYsical
>> >  2. the disk backend domain must be the same as the running libxl
>> >     code (assumed to be 0)
> AKA LIBXL_TOOLSTACK_DOMID. That line could also do with wrapping but I
> can do that as I commit if you like.

Ah, I grepped around for stuff like "DOMID_SELF" but missed that one :-)

I'll resend...

Cheers,
Dave

      reply	other threads:[~2013-04-23  9:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  9:36 [PATCH] Only call stat() when adding a disk if we expect a device to exist David Scott
2013-04-23  9:44 ` Ian Campbell
2013-04-23  9:52   ` David Scott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517659C6.40409@eu.citrix.com \
    --to=dave.scott@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.