From: Mugunthan V N <mugunthanvnm@ti.com>
To: Markus Brunner <systemprogrammierung.brunner@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Mark Jackson <mpfj-list@newflow.co.uk>
Subject: Re: [PATCH] remove vlan tags in CPSW dual emac mode
Date: Tue, 23 Apr 2013 22:59:34 +0530 [thread overview]
Message-ID: <5176C4FE.4080305@ti.com> (raw)
In-Reply-To: <4699400.vD3TdgH1nR@localhost>
On 4/23/2013 9:48 PM, Markus Brunner wrote:
> If operating in dual emac mode all packets sent by the CPSW contain vlan headers with the reserved VID 0,
> which gets stripped away by all somewhat recent Linux versions. Operating systems without that behaviour will fail to communicate.
> This patch fixes that behaviour by disabling the VLAN_AWARE mode as already described by the comment above.
>
> Signed-off-by: Markus Brunner <systemprogrammierung.brunner@gmail.com>
> Tested-by: Mark Jackson <mpfj@newflow.co.uk>
>
> ---
> --- linux-3.9-rc8.orig/drivers/net/ethernet/ti/cpsw.c 2013-04-23 17:26:11.000000000 +0200
> +++ linux-3.9-rc8/drivers/net/ethernet/ti/cpsw.c 2013-04-23 17:36:25.000000000 +0200
> @@ -751,9 +751,9 @@ static void cpsw_init_host_port(struct c
> /* switch to vlan unaware mode */
> cpsw_ale_control_set(priv->ale, priv->host_port, ALE_VLAN_AWARE,
> CPSW_ALE_VLAN_AWARE);
> control_reg = readl(&priv->regs->control);
> - control_reg |= CPSW_VLAN_AWARE;
> + control_reg &= ~CPSW_VLAN_AWARE;
> writel(control_reg, &priv->regs->control);
> fifo_mode = (priv->data.dual_emac) ? CPSW_FIFO_DUAL_MAC_MODE :
> CPSW_FIFO_NORMAL_MODE;
> writel(fifo_mode, &priv->host_port_regs->tx_in_ctl);
Disabling VLAN aware mode will enable switching mode and the feature of
separating the two down stream port is lost with this patch
Please check TRM for more info in *14.3.2.10.2 Dual Mac Mode* chapter
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] remove vlan tags in CPSW dual emac mode
Date: Tue, 23 Apr 2013 22:59:34 +0530 [thread overview]
Message-ID: <5176C4FE.4080305@ti.com> (raw)
In-Reply-To: <4699400.vD3TdgH1nR@localhost>
On 4/23/2013 9:48 PM, Markus Brunner wrote:
> If operating in dual emac mode all packets sent by the CPSW contain vlan headers with the reserved VID 0,
> which gets stripped away by all somewhat recent Linux versions. Operating systems without that behaviour will fail to communicate.
> This patch fixes that behaviour by disabling the VLAN_AWARE mode as already described by the comment above.
>
> Signed-off-by: Markus Brunner <systemprogrammierung.brunner@gmail.com>
> Tested-by: Mark Jackson <mpfj@newflow.co.uk>
>
> ---
> --- linux-3.9-rc8.orig/drivers/net/ethernet/ti/cpsw.c 2013-04-23 17:26:11.000000000 +0200
> +++ linux-3.9-rc8/drivers/net/ethernet/ti/cpsw.c 2013-04-23 17:36:25.000000000 +0200
> @@ -751,9 +751,9 @@ static void cpsw_init_host_port(struct c
> /* switch to vlan unaware mode */
> cpsw_ale_control_set(priv->ale, priv->host_port, ALE_VLAN_AWARE,
> CPSW_ALE_VLAN_AWARE);
> control_reg = readl(&priv->regs->control);
> - control_reg |= CPSW_VLAN_AWARE;
> + control_reg &= ~CPSW_VLAN_AWARE;
> writel(control_reg, &priv->regs->control);
> fifo_mode = (priv->data.dual_emac) ? CPSW_FIFO_DUAL_MAC_MODE :
> CPSW_FIFO_NORMAL_MODE;
> writel(fifo_mode, &priv->host_port_regs->tx_in_ctl);
Disabling VLAN aware mode will enable switching mode and the feature of
separating the two down stream port is lost with this patch
Please check TRM for more info in *14.3.2.10.2 Dual Mac Mode* chapter
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: Mugunthan V N <mugunthanvnm@ti.com>
To: Markus Brunner <systemprogrammierung.brunner@gmail.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>,
Mark Jackson <mpfj-list@newflow.co.uk>
Subject: Re: [PATCH] remove vlan tags in CPSW dual emac mode
Date: Tue, 23 Apr 2013 22:59:34 +0530 [thread overview]
Message-ID: <5176C4FE.4080305@ti.com> (raw)
In-Reply-To: <4699400.vD3TdgH1nR@localhost>
On 4/23/2013 9:48 PM, Markus Brunner wrote:
> If operating in dual emac mode all packets sent by the CPSW contain vlan headers with the reserved VID 0,
> which gets stripped away by all somewhat recent Linux versions. Operating systems without that behaviour will fail to communicate.
> This patch fixes that behaviour by disabling the VLAN_AWARE mode as already described by the comment above.
>
> Signed-off-by: Markus Brunner <systemprogrammierung.brunner@gmail.com>
> Tested-by: Mark Jackson <mpfj@newflow.co.uk>
>
> ---
> --- linux-3.9-rc8.orig/drivers/net/ethernet/ti/cpsw.c 2013-04-23 17:26:11.000000000 +0200
> +++ linux-3.9-rc8/drivers/net/ethernet/ti/cpsw.c 2013-04-23 17:36:25.000000000 +0200
> @@ -751,9 +751,9 @@ static void cpsw_init_host_port(struct c
> /* switch to vlan unaware mode */
> cpsw_ale_control_set(priv->ale, priv->host_port, ALE_VLAN_AWARE,
> CPSW_ALE_VLAN_AWARE);
> control_reg = readl(&priv->regs->control);
> - control_reg |= CPSW_VLAN_AWARE;
> + control_reg &= ~CPSW_VLAN_AWARE;
> writel(control_reg, &priv->regs->control);
> fifo_mode = (priv->data.dual_emac) ? CPSW_FIFO_DUAL_MAC_MODE :
> CPSW_FIFO_NORMAL_MODE;
> writel(fifo_mode, &priv->host_port_regs->tx_in_ctl);
Disabling VLAN aware mode will enable switching mode and the feature of
separating the two down stream port is lost with this patch
Please check TRM for more info in *14.3.2.10.2 Dual Mac Mode* chapter
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-04-23 17:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 16:18 [PATCH] remove vlan tags in CPSW dual emac mode Markus Brunner
2013-04-23 16:18 ` Markus Brunner
2013-04-23 17:29 ` Mugunthan V N [this message]
2013-04-23 17:29 ` Mugunthan V N
2013-04-23 17:29 ` Mugunthan V N
2013-04-23 18:15 ` Mark Jackson
2013-04-23 18:15 ` Mark Jackson
2013-07-12 13:57 ` Mark Jackson
2013-07-12 13:57 ` Mark Jackson
2013-07-12 18:35 ` Mugunthan V N
2013-07-12 18:35 ` Mugunthan V N
2013-07-12 18:35 ` Mugunthan V N
2013-07-12 19:25 ` Mark Jackson
2013-07-12 19:25 ` Mark Jackson
2013-07-15 12:45 ` Mugunthan V N
2013-07-15 12:45 ` Mugunthan V N
2013-07-15 12:45 ` Mugunthan V N
2013-07-15 15:50 ` Mark Jackson
2013-07-15 15:50 ` Mark Jackson
2013-07-15 17:02 ` Mugunthan V N
2013-07-15 17:02 ` Mugunthan V N
2013-07-19 18:07 ` Markus Brunner
2013-07-19 18:07 ` Markus Brunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5176C4FE.4080305@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpfj-list@newflow.co.uk \
--cc=netdev@vger.kernel.org \
--cc=systemprogrammierung.brunner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.