From: Christoph Egger <chegger@amazon.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] docs: make 'gmake dist-docs' work
Date: Wed, 24 Apr 2013 14:54:07 +0200 [thread overview]
Message-ID: <5177D5EF.5040908@amazon.de> (raw)
In-Reply-To: <1366804085.20256.290.camel@zakaz.uk.xensource.com>
On 24.04.13 13:48, Ian Campbell wrote:
> On Mon, 2013-04-22 at 12:55 +0100, Egger Christoph wrote:
>> doc: Makefile fixes
>>
>> - use correct pathes (make gmake dist-docs from toplevel directory work)
>> - use tools as found by configure (perl)
>
> Did you test this?
Yes.
[...]
> $(PERL) is defined in config/Tools.mk but docs/Makefile by design only
> includes config/Docs.mk. I think you need to check for perl in
> docs/configure.ac as well and propagate the result into config/Docs.mk
> AC_ARG_VAR([PERL], [Path to Perl parser])
> AX_PATH_PROG_OR_FAIL([PERL], [perl])
docs/Makefile also includes Config.mk which in turn includes
config/Tools.mk.
>From there $(PERL) is defined and makes this patch work.
Christoph
> The reason for checking twice is to support people who only want to
> build the docs and not the tools and therefore only run configure in the
> subdirectory.
>
> Ian.
>
>
next prev parent reply other threads:[~2013-04-24 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 11:55 [PATCH] docs: make 'gmake dist-docs' work Egger Christoph
2013-04-24 11:48 ` Ian Campbell
2013-04-24 12:54 ` Christoph Egger [this message]
2013-04-24 13:02 ` Ian Campbell
2013-05-10 12:06 ` Christoph Egger
2013-05-10 14:00 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5177D5EF.5040908@amazon.de \
--to=chegger@amazon.de \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.