From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Disable driver-specific options for 1.5
Date: Wed, 24 Apr 2013 07:57:44 -0600 [thread overview]
Message-ID: <5177E4D8.7010702@redhat.com> (raw)
In-Reply-To: <1366810169-23700-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
On 04/24/2013 07:29 AM, Kevin Wolf wrote:
> We don't want to commit to the API yet before everything is worked out.
> Disable it for the 1.5 release. This commit is meant to be reverted
> after the 1.5 release.
Agreed that command line support without QMP support is awkward, so
crippling the code until we have full support in 1.6 is perfectly fine
for libvirt's perspective.
>
> The disabling of the driver-specific options is achieved by applying the
> old checks while parsing the command line.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> blockdev.c | 118 +++++++++++++++++++++++++++++++++++++++++++++--
> tests/qemu-iotests/group | 2 +-
> 2 files changed, 115 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-04-24 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 13:29 [Qemu-devel] [PATCH] block: Disable driver-specific options for 1.5 Kevin Wolf
2013-04-24 13:57 ` Eric Blake [this message]
2013-04-24 14:58 ` Stefan Hajnoczi
2013-04-24 15:03 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5177E4D8.7010702@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.