Re: [Qemu-devel] [RESEND PATCH 1/2] qapi: introduce strList and visit_type_strList()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

On 04/24/2013 06:47 AM, Amos Kong wrote:
> Currently we can only use ['String'] to add string to a list,
> it contains some additional JSON structure.
>     "multicast": [
>         {
>             "str": "01:80:c2:00:00:21"
>         },
>         {
>             "str": "00:00:00:00:00:00"
>         }
>     ]
> 
> This patch introdued strList, we can use ['str']
> 
>     "multicast": [
>         "01:00:5e:00:00:01",
>         "33:33:ff:12:34:57"
>     ]
> 
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> I used an _ugly_ "#ifndef" to limit it only be defined in qapi-types.h.
> do you have some suggestion to fix it?

I'm not the maintainer, so you may still want to wait for a better
suggestion.  But since I personally don't mind the #ifdef if that's what
it takes to get this to compile, and since I'd like to see the feature
added, I'm fine giving:

Reviewed-by: Eric Blake <eblake@redhat.com>

That said, I think the API in patch 2/2 is not quite right; and when you
fix things there, you may not need this patch in the 1.5 timeframe...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]