From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, Amos Kong <akong@redhat.com>,
qemu-devel@nongnu.org, jyang@redhat.com
Subject: Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command
Date: Thu, 25 Apr 2013 07:30:34 -0600 [thread overview]
Message-ID: <51792FFA.2010803@redhat.com> (raw)
In-Reply-To: <20130425083600.021e8bec@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On 04/25/2013 06:36 AM, Luiz Capitulino wrote:
>>> One other concern - you document that if a flag parameter is omitted,
>>> then it defaults to 1. Is that really true?
>>
>>
>> I'm wrong. If it's omitted in cmdline, we will give it a default value.
>>
>> This kind of default info is only added in help descriptions right
>> now, we can add a new item 'default_value' to option.h:QemuOptDesc &
>> qapi-schema.json:CommandLineParameterInfo in future?
>
> Yes. I don't think we'll have enough time to fix this now.
Agreed - we've added additional information in the QMP types returned by
query-* in the past, and it's no problem if we don't expose default
values via QMP until improving the C code to track default values in
1.6. For 1.5, let's just focus on exposing the information we have
readily available.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-04-25 13:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 12:47 [Qemu-devel] [RESEND PATCH 1/2] qapi: introduce strList and visit_type_strList() Amos Kong
2013-04-24 12:47 ` [Qemu-devel] [PATCH 2/2] monitor: introduce query-config-schema command Amos Kong
2013-04-24 14:38 ` Eric Blake
2013-04-24 16:45 ` Anthony Liguori
2013-04-24 17:33 ` [Qemu-devel] [PATCH] " Amos Kong
2013-04-24 17:36 ` [Qemu-devel] [PATCH v2] " Amos Kong
2013-04-24 18:20 ` [Qemu-devel] [PATCH] " Luiz Capitulino
2013-04-24 19:39 ` Eric Blake
2013-04-24 23:55 ` Eric Blake
2013-04-25 3:52 ` Amos Kong
2013-04-25 4:27 ` Osier Yang
2013-04-25 5:09 ` Amos Kong
2013-04-25 12:36 ` Luiz Capitulino
2013-04-25 13:30 ` Eric Blake [this message]
2013-04-25 1:14 ` Amos Kong
2013-04-25 1:35 ` Luiz Capitulino
2013-04-25 1:44 ` Eric Blake
2013-04-25 2:03 ` Amos Kong
2013-04-25 2:14 ` Luiz Capitulino
2013-04-25 1:43 ` Eric Blake
2013-04-25 3:38 ` Osier Yang
2013-04-24 14:01 ` [Qemu-devel] [RESEND PATCH 1/2] qapi: introduce strList and visit_type_strList() Eric Blake
2013-04-24 15:59 ` Amos Kong
2013-04-24 14:39 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51792FFA.2010803@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jyang@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.