From: Eric Blake <eblake@redhat.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server
Date: Wed, 24 Apr 2013 08:54:18 -0600 [thread overview]
Message-ID: <5177F21A.6050406@redhat.com> (raw)
In-Reply-To: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On 04/24/2013 04:12 AM, Lei Li wrote:
> Hi guys,
>
> This patch series tries to add support for LED state
> extension to Qemu VNC server. The proposal has been sent
> few days ago as link below:
>
> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html
>
> The previous version as link:
>
> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03988.html
>
> Pleae let me know if there is anything else need be improved.
Can you fix your setup to include a series diffstat in your cover
letter? I know that 'git send-email --cover-letter --annotate' does
this; but I also know that's not the workflow everyone uses. I just
updated http://wiki.qemu.org/Contribute/SubmitAPatch to mention that a
cover letter diffstat is a useful review aid (I'd much rather check a
0/n letter to see what files are touched in summary, rather than opening
n emails just to see if it touches any file I care about). I guess that
means I'm asking for a bit of help in further updating the wiki to
mention how to have git reliably include a cover letter diffstat, since
asking for something without giving a recipe of how to accomplish it
isn't very nice.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-04-24 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 10:12 [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server Lei Li
2013-04-24 10:12 ` [Qemu-devel] [PATCH 1/3] vnc: Add SCROLL lock key to kbd_leds Lei Li
2013-04-24 10:12 ` [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension Lei Li
2013-04-24 11:44 ` Gerd Hoffmann
2013-04-25 3:53 ` Lei Li
2013-04-24 10:12 ` [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state Lei Li
2013-04-24 14:57 ` Eric Blake
2013-04-25 2:25 ` Lei Li
2013-04-25 2:56 ` Eric Blake
2013-04-24 14:54 ` Eric Blake [this message]
2013-04-25 2:10 ` [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5177F21A.6050406@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lagarcia@br.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.