From: Lei Li <lilei@linux.vnet.ibm.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension
Date: Thu, 25 Apr 2013 11:53:53 +0800 [thread overview]
Message-ID: <5178A8D1.9040704@linux.vnet.ibm.com> (raw)
In-Reply-To: <5177C5A1.4050109@redhat.com>
On 04/24/2013 07:44 PM, Gerd Hoffmann wrote:
> Hi,
>
>> + case VNC_ENCODING_LED_STATE:
>> + vs->features |= VNC_FEATURE_LED_STATE_MASK;
>> + break;
> I think it with the client supporting the led state extension it is
> probably a good idea to turn off the lock state sync logic in qemu's vnc
> server, i.e. add a "!(vs->features & VNC_FEATURE_LED_STATE_MASK)" check
> next to the lock_key_sync checks in do_key_event().
>
> cheers,
> Gerd
Hi Gerd,
Yes, I think it's a good idea.
Thanks!
>
--
Lei
next prev parent reply other threads:[~2013-04-25 3:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 10:12 [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server Lei Li
2013-04-24 10:12 ` [Qemu-devel] [PATCH 1/3] vnc: Add SCROLL lock key to kbd_leds Lei Li
2013-04-24 10:12 ` [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension Lei Li
2013-04-24 11:44 ` Gerd Hoffmann
2013-04-25 3:53 ` Lei Li [this message]
2013-04-24 10:12 ` [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state Lei Li
2013-04-24 14:57 ` Eric Blake
2013-04-25 2:25 ` Lei Li
2013-04-25 2:56 ` Eric Blake
2013-04-24 14:54 ` [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server Eric Blake
2013-04-25 2:10 ` Lei Li
-- strict thread matches above, loose matches on Subject: below --
2013-04-19 18:11 [Qemu-devel] [PATCH 0/3 RFC v2] " Lei Li
2013-04-19 18:11 ` [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension Lei Li
2013-04-22 19:34 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5178A8D1.9040704@linux.vnet.ibm.com \
--to=lilei@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=lagarcia@br.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.