* [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle
@ 2013-04-25 0:19 ` Kevin Hilman
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2013-04-25 0:19 UTC (permalink / raw)
To: linux-arm-kernel
commit d1669912 (idle: Implement generic idle function) added a new
generic idle along with support for hlt/nohlt command line options to
override default idle loop behavior. However, the command-line
processing is never compiled.
The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
and arches that use this feature select it in their Kconfigs.
However, no Kconfig definition was created for this option, so it is
never enabled, and therefore command-line override of the idle-loop
behavior is broken after migrating to the generic idle loop.
To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
Tested on ARM (OMAP4/Panda) which enables the command-line overrides
by default.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
Applies on tip/smp/hotplug where generic idle feature is added
arch/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 1455579..e0ef57b 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
config GENERIC_SMP_IDLE_THREAD
bool
+config GENERIC_IDLE_POLL_SETUP
+ bool
+
# Select if arch init_task initializer is different to init/init_task.c
config ARCH_INIT_TASK
bool
--
1.8.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle
@ 2013-04-25 0:19 ` Kevin Hilman
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2013-04-25 0:19 UTC (permalink / raw)
To: Thomas Gleixner, linux-kernel
Cc: linux-arm-kernel, linaro-kernel, Linus Torvalds, Rusty Russell,
Paul McKenney, Peter Zijlstra, Srivatsa S. Bhat, Magnus Damm
commit d1669912 (idle: Implement generic idle function) added a new
generic idle along with support for hlt/nohlt command line options to
override default idle loop behavior. However, the command-line
processing is never compiled.
The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
and arches that use this feature select it in their Kconfigs.
However, no Kconfig definition was created for this option, so it is
never enabled, and therefore command-line override of the idle-loop
behavior is broken after migrating to the generic idle loop.
To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
Tested on ARM (OMAP4/Panda) which enables the command-line overrides
by default.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
Applies on tip/smp/hotplug where generic idle feature is added
arch/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 1455579..e0ef57b 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
config GENERIC_SMP_IDLE_THREAD
bool
+config GENERIC_IDLE_POLL_SETUP
+ bool
+
# Select if arch init_task initializer is different to init/init_task.c
config ARCH_INIT_TASK
bool
--
1.8.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle
2013-04-25 0:19 ` Kevin Hilman
@ 2013-04-25 6:42 ` Srivatsa S. Bhat
-1 siblings, 0 replies; 7+ messages in thread
From: Srivatsa S. Bhat @ 2013-04-25 6:42 UTC (permalink / raw)
To: linux-arm-kernel
On 04/25/2013 05:49 AM, Kevin Hilman wrote:
> commit d1669912 (idle: Implement generic idle function) added a new
> generic idle along with support for hlt/nohlt command line options to
> override default idle loop behavior. However, the command-line
> processing is never compiled.
>
> The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
> and arches that use this feature select it in their Kconfigs.
> However, no Kconfig definition was created for this option, so it is
> never enabled, and therefore command-line override of the idle-loop
> behavior is broken after migrating to the generic idle loop.
>
> To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
>
> Tested on ARM (OMAP4/Panda) which enables the command-line overrides
> by default.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
> Applies on tip/smp/hotplug where generic idle feature is added
>
> arch/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 1455579..e0ef57b 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
> config GENERIC_SMP_IDLE_THREAD
> bool
>
> +config GENERIC_IDLE_POLL_SETUP
> + bool
> +
> # Select if arch init_task initializer is different to init/init_task.c
> config ARCH_INIT_TASK
> bool
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle
@ 2013-04-25 6:42 ` Srivatsa S. Bhat
0 siblings, 0 replies; 7+ messages in thread
From: Srivatsa S. Bhat @ 2013-04-25 6:42 UTC (permalink / raw)
To: Kevin Hilman
Cc: Thomas Gleixner, linux-kernel, linux-arm-kernel, linaro-kernel,
Linus Torvalds, Rusty Russell, Paul McKenney, Peter Zijlstra,
Magnus Damm
On 04/25/2013 05:49 AM, Kevin Hilman wrote:
> commit d1669912 (idle: Implement generic idle function) added a new
> generic idle along with support for hlt/nohlt command line options to
> override default idle loop behavior. However, the command-line
> processing is never compiled.
>
> The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
> and arches that use this feature select it in their Kconfigs.
> However, no Kconfig definition was created for this option, so it is
> never enabled, and therefore command-line override of the idle-loop
> behavior is broken after migrating to the generic idle loop.
>
> To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
>
> Tested on ARM (OMAP4/Panda) which enables the command-line overrides
> by default.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
> Applies on tip/smp/hotplug where generic idle feature is added
>
> arch/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 1455579..e0ef57b 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
> config GENERIC_SMP_IDLE_THREAD
> bool
>
> +config GENERIC_IDLE_POLL_SETUP
> + bool
> +
> # Select if arch init_task initializer is different to init/init_task.c
> config ARCH_INIT_TASK
> bool
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle
2013-04-25 6:42 ` Srivatsa S. Bhat
@ 2013-04-29 23:43 ` Kevin Hilman
-1 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2013-04-29 23:43 UTC (permalink / raw)
To: linux-arm-kernel
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> writes:
> On 04/25/2013 05:49 AM, Kevin Hilman wrote:
>> commit d1669912 (idle: Implement generic idle function) added a new
>> generic idle along with support for hlt/nohlt command line options to
>> override default idle loop behavior. However, the command-line
>> processing is never compiled.
>>
>> The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
>> and arches that use this feature select it in their Kconfigs.
>> However, no Kconfig definition was created for this option, so it is
>> never enabled, and therefore command-line override of the idle-loop
>> behavior is broken after migrating to the generic idle loop.
>>
>> To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
>>
>> Tested on ARM (OMAP4/Panda) which enables the command-line overrides
>> by default.
>>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Cc: Rusty Russell <rusty@rustcorp.com.au>
>> Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>> ---
>
> Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks for the review.
>> Applies on tip/smp/hotplug where generic idle feature is added
Thomas, can this get into tip/smp/hotplug so the command-line override
is not broken in v3.10?
Thanks,
Kevin
>>
>> arch/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index 1455579..e0ef57b 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
>> config GENERIC_SMP_IDLE_THREAD
>> bool
>>
>> +config GENERIC_IDLE_POLL_SETUP
>> + bool
>> +
>> # Select if arch init_task initializer is different to init/init_task.c
>> config ARCH_INIT_TASK
>> bool
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle
@ 2013-04-29 23:43 ` Kevin Hilman
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2013-04-29 23:43 UTC (permalink / raw)
To: Srivatsa S. Bhat, Thomas Gleixner
Cc: linux-kernel, linux-arm-kernel, linaro-kernel, Linus Torvalds,
Rusty Russell, Paul McKenney, Peter Zijlstra, Magnus Damm
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> writes:
> On 04/25/2013 05:49 AM, Kevin Hilman wrote:
>> commit d1669912 (idle: Implement generic idle function) added a new
>> generic idle along with support for hlt/nohlt command line options to
>> override default idle loop behavior. However, the command-line
>> processing is never compiled.
>>
>> The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
>> and arches that use this feature select it in their Kconfigs.
>> However, no Kconfig definition was created for this option, so it is
>> never enabled, and therefore command-line override of the idle-loop
>> behavior is broken after migrating to the generic idle loop.
>>
>> To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
>>
>> Tested on ARM (OMAP4/Panda) which enables the command-line overrides
>> by default.
>>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Cc: Rusty Russell <rusty@rustcorp.com.au>
>> Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>> ---
>
> Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks for the review.
>> Applies on tip/smp/hotplug where generic idle feature is added
Thomas, can this get into tip/smp/hotplug so the command-line override
is not broken in v3.10?
Thanks,
Kevin
>>
>> arch/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index 1455579..e0ef57b 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
>> config GENERIC_SMP_IDLE_THREAD
>> bool
>>
>> +config GENERIC_IDLE_POLL_SETUP
>> + bool
>> +
>> # Select if arch init_task initializer is different to init/init_task.c
>> config ARCH_INIT_TASK
>> bool
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:core/urgent] idle: Fix hlt/ nohlt command-line handling in new generic idle
2013-04-25 0:19 ` Kevin Hilman
(?)
(?)
@ 2013-05-05 6:35 ` tip-bot for Kevin Hilman
-1 siblings, 0 replies; 7+ messages in thread
From: tip-bot for Kevin Hilman @ 2013-05-05 6:35 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, rusty, torvalds, peterz, srivatsa.bhat,
paulmck, tglx, khilman, magnus.damm
Commit-ID: 485cf5dac2966b93ef2b6211cf2fd42d66c823e6
Gitweb: http://git.kernel.org/tip/485cf5dac2966b93ef2b6211cf2fd42d66c823e6
Author: Kevin Hilman <khilman@linaro.org>
AuthorDate: Wed, 24 Apr 2013 17:19:13 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 5 May 2013 08:29:40 +0200
idle: Fix hlt/nohlt command-line handling in new generic idle
commit d1669912 (idle: Implement generic idle function) added a new
generic idle along with support for hlt/nohlt command line options to
override default idle loop behavior. However, the command-line
processing is never compiled.
The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
and arches that use this feature select it in their Kconfigs.
However, no Kconfig definition was created for this option, so it is
never enabled, and therefore command-line override of the idle-loop
behavior is broken after migrating to the generic idle loop.
To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
Tested on ARM (OMAP4/Panda) which enables the command-line overrides
by default.
Signed-off-by: Kevin Hilman <khilman@linaro.org>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linaro-kernel@lists.linaro.org
Link: http://lkml.kernel.org/r/1366849153-25564-1-git-send-email-khilman@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 99f0e17..3e64403 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -213,6 +213,9 @@ config USE_GENERIC_SMP_HELPERS
config GENERIC_SMP_IDLE_THREAD
bool
+config GENERIC_IDLE_POLL_SETUP
+ bool
+
# Select if arch init_task initializer is different to init/init_task.c
config ARCH_INIT_TASK
bool
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-05 6:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-25 0:19 [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle Kevin Hilman
2013-04-25 0:19 ` Kevin Hilman
2013-04-25 6:42 ` Srivatsa S. Bhat
2013-04-25 6:42 ` Srivatsa S. Bhat
2013-04-29 23:43 ` Kevin Hilman
2013-04-29 23:43 ` Kevin Hilman
2013-05-05 6:35 ` [tip:core/urgent] idle: Fix hlt/ nohlt " tip-bot for Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.