Re: Evaluating the c_can driver for EG20T

[Wolfgang Grandegger <wg@grandegger.com>]

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

Hi Jeroen,

On 04/25/2013 11:23 AM, Wolfgang Grandegger wrote:
> On 04/25/2013 10:55 AM, j.p.lammertink wrote:
>>
>> <> Hi Wolfgang,
>>
>> <>< Hi Jeroen,
>> <><> Hi Wolfgang,
...
>> Hi Wolfgang,
>>
>> I've included the patch in the E-mail: 
>> "Losing CAN messages with socket-CAN" of 24 apr 2013 11:11. (Appendix 7)
>> It also contains kernel disto and kernel version and also
>> the problem description.
> 
> OK. could you send the file "pch_can.c" you used (sorry for my bad
> English). Your kernel is obviously 3.5.0-27-generic from Ubuntu. I'm
> going to rebase the patches on top of mainline Linux 3.5.0. Any chance
> for you to use a recent mailing Linux version?

Well, I tried to apply the patches and they fail because v3.5 is already
quite old (there are many additions to the c_can driver). Therefore I
repeat may question: "Any chance to use a recent mailing Linux version?"

Anyway, end of last year I provided out-of-tree sources for testing. I
have attached the mail including an attachment. You may want to give it
a quick try. There is an README inside. It explains how to compile the
modules. Then you need just to rmmod the old pch_can, c_can_pci and
c_can drivers and insmod the new c_can.ko and c_can_pci.ko.

I need more time to go over the sources.

Wolfgang.

[-- Attachment #2: Attached Message --]
[-- Type: message/rfc822, Size: 25312 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 603 bytes --]

Hi Micheal,

On 11/26/2012 07:13 PM, Wolfgang Grandegger wrote:
> On 11/26/2012 06:30 PM, Michael Pellegrini wrote:
...
>> Alright, I will wait until more substantial changes are implemented before
>> re-running the long-term test on this driver.
> 
> Yes, maybe we can come up with an even better solution.

I have implemented a better solution now using different sets of
registers for tx and rx. This avoids locking in the RX path as well.
Furthermore, pch_can now uses spin_[un]lock_bh. Would be nice if you
could give the pch_can and c_can_pci driver a try when time permits.

Thanks,

Wolfgang.



[-- Attachment #2.1.2: c-can-pci-v8.tar.bz2 --]
[-- Type: application/x-bzip, Size: 16856 bytes --]