Re: [PATCH v3 04/13] xen/arm: support for guest SGI

[Julien Grall <julien.grall@citrix.com>]

On 04/24/2013 08:07 PM, Stefano Stabellini wrote:

> +                    break;
> +                default:
> +                    printk("vGICD: unhandled GICD_SGIR write %x with wrong TargetListFilter field\n", *r);

The type of r is register_t, which is equal to u64 on arm64 and u32 on
arm32. You should use PRIregister.

> +                    return 0;
> +            }
> +
> +            for_each_cpu( vcpuid, &vcpu_mask )
> +            {
> +                if ( vcpuid >= d->max_vcpus || (vt = d->vcpu[vcpuid]) == NULL ||
> +                        virtual_irq >= 16 )
> +                {
> +                    printk("vGICD: GICD_SGIR write r=%x vcpu_mask=%lx, wrong CPUTargetList\n",
> +                           *r, *cpumask_bits(&vcpu_mask));

Same here.

Cheers,

Julien