From: Keir Fraser <keir.xen@gmail.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>,
"Tim (Xen.org)" <tim@xen.org>, Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v3 03/13] xen: introduce cpumask_from_bitmap
Date: Thu, 25 Apr 2013 16:17:19 +0100 [thread overview]
Message-ID: <CD9F078F.22FCD%keir.xen@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1304251608220.4180@kaball.uk.xensource.com>
On 25/04/2013 16:08, "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
wrote:
> On Thu, 25 Apr 2013, Ian Campbell wrote:
>> On Thu, 2013-04-25 at 15:42 +0100, Ian Campbell wrote:
>>> And it really wants to act on sets of real physical cpus (hence cpumask_t)?
>>
>> Actually, vcpus. Perhaps cpumask_t is the wrong datatype then?
>
> It seems to me that cpumask_t is a pretty good fit for a vcpu mask.
It's not. It's bounded by NR_CPUS for a start. And it is good documentation
for all uses of cpumasks to be applying to *physical* cpus, otherwise we
will end up even more confused!
I might consider a vcpumask_t of some sort if such an abstraction could be
made to work out nicely (given different domains have different max# of
vcpus). But we managed so far without. ;)
-- Keir
next prev parent reply other threads:[~2013-04-25 15:17 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 19:06 [PATCH v3 0/13] xen/arm: guest SMP support Stefano Stabellini
2013-04-24 19:07 ` [PATCH v3 01/13] xen/arm: basic PSCI support, implement cpu_on and cpu_off Stefano Stabellini
2013-04-25 9:53 ` Ian Campbell
2013-04-25 10:57 ` Stefano Stabellini
2013-04-25 11:31 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 02/13] xen/arm: allocate secondaries dom0 vcpus Stefano Stabellini
2013-04-25 10:08 ` Ian Campbell
2013-04-26 13:23 ` Stefano Stabellini
2013-04-26 13:25 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 03/13] xen: introduce cpumask_from_bitmap Stefano Stabellini
2013-04-25 9:24 ` Jan Beulich
2013-04-25 10:01 ` Ian Campbell
2013-04-25 14:26 ` Keir Fraser
2013-04-25 14:42 ` Ian Campbell
2013-04-25 14:44 ` Ian Campbell
2013-04-25 14:51 ` Ian Campbell
2013-04-25 15:13 ` Keir Fraser
2013-04-25 15:23 ` Ian Campbell
2013-04-25 17:20 ` Keir Fraser
2013-04-25 15:08 ` Stefano Stabellini
2013-04-25 15:17 ` Keir Fraser [this message]
2013-04-25 15:18 ` Jan Beulich
2013-04-25 15:17 ` Jan Beulich
2013-04-25 10:01 ` Stefano Stabellini
2013-04-25 10:08 ` Jan Beulich
2013-04-25 10:35 ` Stefano Stabellini
2013-04-25 10:49 ` Jan Beulich
2013-04-25 11:38 ` Stefano Stabellini
2013-04-25 12:49 ` Jan Beulich
2013-04-25 14:27 ` Keir Fraser
2013-04-24 19:07 ` [PATCH v3 04/13] xen/arm: support for guest SGI Stefano Stabellini
2013-04-25 10:16 ` Ian Campbell
2013-04-25 19:03 ` Julien Grall
2013-04-26 9:05 ` Ian Campbell
2013-04-26 11:46 ` Julien Grall
2013-04-26 12:12 ` Sander Bogaert
2013-04-26 13:07 ` Stefano Stabellini
2013-04-26 13:24 ` Ian Campbell
2013-04-26 13:35 ` Julien Grall
2013-04-26 13:56 ` Sander Bogaert
2013-04-26 14:10 ` Ian Campbell
2013-04-26 13:28 ` Julien Grall
2013-04-24 19:07 ` [PATCH v3 05/13] xen/arm: early_ioremap: allocate virtual addresses from top to bottom Stefano Stabellini
2013-04-25 10:27 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 06/13] xen/arm: implement arch_vmap_virt_end Stefano Stabellini
2013-04-25 10:29 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 07/13] xen/arm: compile and initialize vmap Stefano Stabellini
2013-04-25 10:41 ` Ian Campbell
2013-04-25 17:04 ` Stefano Stabellini
2013-04-26 9:00 ` Ian Campbell
2013-04-26 12:02 ` Stefano Stabellini
2013-04-26 13:21 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 08/13] xen/arm: implement map_domain_page_global and unmap_domain_page_global Stefano Stabellini
2013-04-25 10:43 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 09/13] xen: move VCPUOP_register_vcpu_info to common code Stefano Stabellini
2013-04-25 10:45 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 10/13] xen/arm: support VCPUOP_register_vcpu_info Stefano Stabellini
2013-04-25 10:50 ` Ian Campbell
2013-04-25 11:38 ` Stefano Stabellini
2013-04-25 11:40 ` Ian Campbell
2013-04-25 11:41 ` Stefano Stabellini
2013-04-25 14:29 ` Keir Fraser
2013-04-25 14:39 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 11/13] xen/arm: send IPIs to inject irqs into guest vcpus running on different pcpus Stefano Stabellini
2013-04-25 11:00 ` Ian Campbell
2013-04-26 13:39 ` Stefano Stabellini
2013-04-26 14:08 ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 12/13] xen/arm: start the vtimer Xen timers on the processor they should be running on Stefano Stabellini
2013-04-25 11:03 ` Ian Campbell
2013-04-26 14:30 ` Stefano Stabellini
2013-04-26 14:35 ` Ian Campbell
2013-04-26 14:36 ` Stefano Stabellini
2013-04-24 19:07 ` [PATCH v3 13/13] xen/arm: initialize virt_timer and phys_timer with the same values on all vcpus Stefano Stabellini
2013-04-25 11:21 ` Ian Campbell
2013-04-26 14:30 ` Stefano Stabellini
2013-04-26 14:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD9F078F.22FCD%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.