From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Hongbo Zhang <hongbo.zhang@stericsson.com>,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL()
Date: Thu, 25 Apr 2013 16:17:21 -0400 [thread overview]
Message-ID: <51798F51.9010401@ti.com> (raw)
In-Reply-To: <20130425174635.GB25783@flint.arm.linux.org.uk>
On 25-04-2013 13:46, Russell King wrote:
> On Thu, Apr 25, 2013 at 10:13:34AM -0400, Eduardo Valentin wrote:
>> diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c
>> index 21419851..786d192 100644
>> --- a/drivers/thermal/db8500_cpufreq_cooling.c
>> +++ b/drivers/thermal/db8500_cpufreq_cooling.c
>> @@ -37,7 +37,7 @@ static int db8500_cpufreq_cooling_probe(struct platform_device *pdev)
>> cpumask_set_cpu(0, &mask_val);
>> cdev = cpufreq_cooling_register(&mask_val);
>>
>> - if (IS_ERR_OR_NULL(cdev)) {
>> + if (IS_ERR(cdev)) {
>> dev_err(&pdev->dev, "Failed to register cooling device\n");
>> return PTR_ERR(cdev);
>
> Correct. cpufreq_cooling_register() returns either an error-pointer or
> a valid pointer.
>
Thanks for your review!
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
Zhang Rui <rui.zhang@intel.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Hongbo Zhang <hongbo.zhang@stericsson.com>,
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL()
Date: Thu, 25 Apr 2013 16:17:21 -0400 [thread overview]
Message-ID: <51798F51.9010401@ti.com> (raw)
In-Reply-To: <20130425174635.GB25783@flint.arm.linux.org.uk>
On 25-04-2013 13:46, Russell King wrote:
> On Thu, Apr 25, 2013 at 10:13:34AM -0400, Eduardo Valentin wrote:
>> diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c
>> index 21419851..786d192 100644
>> --- a/drivers/thermal/db8500_cpufreq_cooling.c
>> +++ b/drivers/thermal/db8500_cpufreq_cooling.c
>> @@ -37,7 +37,7 @@ static int db8500_cpufreq_cooling_probe(struct platform_device *pdev)
>> cpumask_set_cpu(0, &mask_val);
>> cdev = cpufreq_cooling_register(&mask_val);
>>
>> - if (IS_ERR_OR_NULL(cdev)) {
>> + if (IS_ERR(cdev)) {
>> dev_err(&pdev->dev, "Failed to register cooling device\n");
>> return PTR_ERR(cdev);
>
> Correct. cpufreq_cooling_register() returns either an error-pointer or
> a valid pointer.
>
Thanks for your review!
next prev parent reply other threads:[~2013-04-25 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 14:13 [PATCH 0/2] thermal: avoid using IS_ERR_OR_NULL() Eduardo Valentin
2013-04-25 14:13 ` Eduardo Valentin
2013-04-25 14:13 ` [PATCH 1/2] thermal: thermal_core: remove usage of IS_ERR_OR_NULL Eduardo Valentin
2013-04-25 14:13 ` Eduardo Valentin
2013-04-25 14:13 ` [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL() Eduardo Valentin
2013-04-25 14:13 ` Eduardo Valentin
2013-04-25 17:46 ` Russell King
2013-04-25 20:17 ` Eduardo Valentin [this message]
2013-04-25 20:17 ` Eduardo Valentin
2013-04-26 10:19 ` Fabio Baltieri
2013-04-26 11:03 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51798F51.9010401@ti.com \
--to=eduardo.valentin@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hongbo.zhang@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.