[PATCH 1/3] include: Add ofono_handsfree_audio_has_defer_setup()

[PATCH 1/3] include: Add ofono_handsfree_audio_has_defer_setup()

[Vinicius Costa Gomes]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

---
 include/handsfree-audio.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/handsfree-audio.h b/include/handsfree-audio.h
index 53e8ab1..846a032 100644
--- a/include/handsfree-audio.h
+++ b/include/handsfree-audio.h
@@ -53,6 +53,8 @@ ofono_bool_t ofono_handsfree_card_set_codec(struct ofono_handsfree_card *card,
 
 ofono_bool_t ofono_handsfree_audio_has_wideband(void);
 
+ofono_bool_t ofono_handsfree_audio_has_defer_setup(void);
+
 void ofono_handsfree_card_set_data(struct ofono_handsfree_card *card,
 					void *data);
 void *ofono_handsfree_card_get_data(struct ofono_handsfree_card *card);
-- 
1.8.2.1

[PATCH 2/3] handsfree-audio: Implement ofono_handsfree_audio_has_defer_setup()

[Vinicius Costa Gomes]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

---
 src/handsfree-audio.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c
index dc37853..d78498a 100644
--- a/src/handsfree-audio.c
+++ b/src/handsfree-audio.c
@@ -562,6 +562,11 @@ ofono_bool_t ofono_handsfree_audio_has_wideband(void)
 	return has_wideband;
 }
 
+ofono_bool_t ofono_handsfree_audio_has_defer_setup(void)
+{
+	return defer_setup == 1;
+}
+
 static void agent_free(struct agent *agent)
 {
 	if (agent->watch > 0)
-- 
1.8.2.1

[PATCH 3/3] hfp_hf_bluez5: Only enable wideband speech if defer_setup is supported

[Vinicius Costa Gomes]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

When setting the SDP features, only enable wideband speech support if
the kernel has defer setup for SCO.

It is possible that even if defer setup is supported the kernel is
not able to use Transparent Mode for SCO.
---
 plugins/hfp_hf_bluez5.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c
index 06b6fd3..0a4c702 100644
--- a/plugins/hfp_hf_bluez5.c
+++ b/plugins/hfp_hf_bluez5.c
@@ -638,8 +638,14 @@ static void connect_handler(DBusConnection *conn, void *user_data)
 {
 	uint16_t features = HFP_SDP_HF_FEATURE_3WAY |
 				HFP_SDP_HF_FEATURE_CLIP |
-				HFP_SDP_HF_FEATURE_REMOTE_VOLUME_CONTROL |
-				HFP_SDP_HF_FEATURE_WIDEBAND_SPEECH;
+				HFP_SDP_HF_FEATURE_REMOTE_VOLUME_CONTROL;
+
+	/*
+	 * Assuming that if defer_setup is supported, then SCO transparent
+	 * mode is also supported
+	*/
+	if (ofono_handsfree_audio_has_defer_setup())
+		features |= HFP_SDP_HF_FEATURE_WIDEBAND_SPEECH;
 
 	DBG("Registering External Profile handler ...");
 
-- 
1.8.2.1

Re: [PATCH 1/3] include: Add ofono_handsfree_audio_has_defer_setup()

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

Hi Vinicius,

On 04/25/2013 02:05 PM, Vinicius Costa Gomes wrote:
> ---
>   include/handsfree-audio.h | 2 ++
>   1 file changed, 2 insertions(+)
>

All three patches have been applied, thanks.

Regards,
-Denis