[PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper
@ 2013-04-19  3:07 Kuninori Morimoto
  2013-04-22  5:24 ` Simon Horman
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2013-04-19  3:07 UTC (permalink / raw)
  To: linux-sh

pfc-r8a7778 will have many devices pfc support in the future,
and current pfc-r8a7778 is using pin/mux definition macro for SCIF.
The device definition style using macro is readable code IMO,
but creating new macro for each devices is not good sense.
This patch adds common SH_PFC_xx() macro for each new feature devices

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v2 -> v3

 - new patch

 drivers/pinctrl/sh-pfc/pfc-r8a7778.c |   26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
index ddbd27b..139f9dd 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
@@ -1303,15 +1303,25 @@ static struct sh_pfc_pin pinmux_pins[] = {
  */
 #define PIN_NUMBER(row, col)		(1000+((row)-1)*25+(col)-1)
 
-/* - SCIF macro ------------------------------------------------------------- */
-#define SCIF_PFC_PIN(name, args...)					\
+/* - macro */
+#define SH_PFC_PINS(name, args...) \
 	static const unsigned int name ##_pins[] = { args }
-#define SCIF_PFC_DAT(name, tx, rx)					\
-	static const unsigned int name ##_mux[]  = { tx##_MARK, rx##_MARK, }
-#define SCIF_PFC_CTR(name, cts, rts)					\
-	static const unsigned int name ##_mux[]  = { cts##_MARK, rts##_MARK, }
-#define SCIF_PFC_CLK(name, sck)					\
-	static const unsigned int name ##_mux[]  = { sck##_MARK, }
+#define SH_PFC_MUX1(name, arg1)					\
+	static const unsigned int name ##_mux[]  = { arg1##_MARK }
+#define SH_PFC_MUX2(name, arg1, arg2)					\
+	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, }
+#define SH_PFC_MUX3(name, arg1, arg2, arg3)					\
+	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK,	\
+						     arg3##_MARK }
+#define SH_PFC_MUX4(name, arg1, arg2, arg3, arg4)			\
+	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, \
+						     arg3##_MARK, arg4##_MARK }
+
+/* - SCIF macro ------------------------------------------------------------- */
+#define SCIF_PFC_PIN(name, args...)	SH_PFC_PINS(name, args)
+#define SCIF_PFC_DAT(name, tx, rx)	SH_PFC_MUX2(name, tx, rx)
+#define SCIF_PFC_CTR(name, cts, rts)	SH_PFC_MUX2(name, cts, rts)
+#define SCIF_PFC_CLK(name, sck)		SH_PFC_MUX1(name, sck)
 
 /* - HSCIF0 ----------------------------------------------------------------- */
 SCIF_PFC_PIN(hscif0_data_a,	RCAR_GP_PIN(1, 17),	RCAR_GP_PIN(1, 18));
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper
  2013-04-19  3:07 [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper Kuninori Morimoto
@ 2013-04-22  5:24 ` Simon Horman
  2013-04-22 10:06 ` Laurent Pinchart
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-04-22  5:24 UTC (permalink / raw)
  To: linux-sh

On Thu, Apr 18, 2013 at 08:07:34PM -0700, Kuninori Morimoto wrote:
> pfc-r8a7778 will have many devices pfc support in the future,
> and current pfc-r8a7778 is using pin/mux definition macro for SCIF.
> The device definition style using macro is readable code IMO,
> but creating new macro for each devices is not good sense.
> This patch adds common SH_PFC_xx() macro for each new feature devices
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks, queued-up for v3.11 in the pinmux branch.

> ---
> v2 -> v3
> 
>  - new patch
> 
>  drivers/pinctrl/sh-pfc/pfc-r8a7778.c |   26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> index ddbd27b..139f9dd 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> @@ -1303,15 +1303,25 @@ static struct sh_pfc_pin pinmux_pins[] = {
>   */
>  #define PIN_NUMBER(row, col)		(1000+((row)-1)*25+(col)-1)
>  
> -/* - SCIF macro ------------------------------------------------------------- */
> -#define SCIF_PFC_PIN(name, args...)					\
> +/* - macro */
> +#define SH_PFC_PINS(name, args...) \
>  	static const unsigned int name ##_pins[] = { args }
> -#define SCIF_PFC_DAT(name, tx, rx)					\
> -	static const unsigned int name ##_mux[]  = { tx##_MARK, rx##_MARK, }
> -#define SCIF_PFC_CTR(name, cts, rts)					\
> -	static const unsigned int name ##_mux[]  = { cts##_MARK, rts##_MARK, }
> -#define SCIF_PFC_CLK(name, sck)					\
> -	static const unsigned int name ##_mux[]  = { sck##_MARK, }
> +#define SH_PFC_MUX1(name, arg1)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK }
> +#define SH_PFC_MUX2(name, arg1, arg2)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, }
> +#define SH_PFC_MUX3(name, arg1, arg2, arg3)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK,	\
> +						     arg3##_MARK }
> +#define SH_PFC_MUX4(name, arg1, arg2, arg3, arg4)			\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, \
> +						     arg3##_MARK, arg4##_MARK }
> +
> +/* - SCIF macro ------------------------------------------------------------- */
> +#define SCIF_PFC_PIN(name, args...)	SH_PFC_PINS(name, args)
> +#define SCIF_PFC_DAT(name, tx, rx)	SH_PFC_MUX2(name, tx, rx)
> +#define SCIF_PFC_CTR(name, cts, rts)	SH_PFC_MUX2(name, cts, rts)
> +#define SCIF_PFC_CLK(name, sck)		SH_PFC_MUX1(name, sck)
>  
>  /* - HSCIF0 ----------------------------------------------------------------- */
>  SCIF_PFC_PIN(hscif0_data_a,	RCAR_GP_PIN(1, 17),	RCAR_GP_PIN(1, 18));
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper
  2013-04-19  3:07 [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper Kuninori Morimoto
  2013-04-22  5:24 ` Simon Horman
@ 2013-04-22 10:06 ` Laurent Pinchart
  2013-04-23  0:32 ` Kuninori Morimoto
  2013-04-26 18:33 ` Sergei Shtylyov
  3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-04-22 10:06 UTC (permalink / raw)
  To: linux-sh

Hi Morimoto-san,

On Thursday 18 April 2013 20:07:34 Kuninori Morimoto wrote:
> pfc-r8a7778 will have many devices pfc support in the future,
> and current pfc-r8a7778 is using pin/mux definition macro for SCIF.
> The device definition style using macro is readable code IMO,
> but creating new macro for each devices is not good sense.
> This patch adds common SH_PFC_xx() macro for each new feature devices
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v2 -> v3
> 
>  - new patch
> 
>  drivers/pinctrl/sh-pfc/pfc-r8a7778.c |   26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c index ddbd27b..139f9dd 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> @@ -1303,15 +1303,25 @@ static struct sh_pfc_pin pinmux_pins[] = {
>   */
>  #define PIN_NUMBER(row, col)		(1000+((row)-1)*25+(col)-1)
> 
> -/* - SCIF macro
> ------------------------------------------------------------- */ -#define
> SCIF_PFC_PIN(name, args...)					\
> +/* - macro */
> +#define SH_PFC_PINS(name, args...) \
>  	static const unsigned int name ##_pins[] = { args }
> -#define SCIF_PFC_DAT(name, tx, rx)					\
> -	static const unsigned int name ##_mux[]  = { tx##_MARK, rx##_MARK, }
> -#define SCIF_PFC_CTR(name, cts, rts)					\
> -	static const unsigned int name ##_mux[]  = { cts##_MARK, rts##_MARK, }
> -#define SCIF_PFC_CLK(name, sck)					\
> -	static const unsigned int name ##_mux[]  = { sck##_MARK, }
> +#define SH_PFC_MUX1(name, arg1)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK }
> +#define SH_PFC_MUX2(name, arg1, arg2)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, }
> +#define SH_PFC_MUX3(name, arg1, arg2, arg3)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK,	
\
> +						     arg3##_MARK }
> +#define SH_PFC_MUX4(name, arg1, arg2, arg3, arg4)			\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, \
> +						     arg3##_MARK, arg4##_MARK }

What's your plan for groups of more than 4 pins ? :-)

At some point, when the groups get large, I think it's better to define the 
arrays explicitly.

I'm fine with this patch though.

> +/* - SCIF macro
> ------------------------------------------------------------- */ +#define
> SCIF_PFC_PIN(name, args...)	SH_PFC_PINS(name, args)
> +#define SCIF_PFC_DAT(name, tx, rx)	SH_PFC_MUX2(name, tx, rx)
> +#define SCIF_PFC_CTR(name, cts, rts)	SH_PFC_MUX2(name, cts, rts)
> +#define SCIF_PFC_CLK(name, sck)		SH_PFC_MUX1(name, sck)
> 
>  /* - HSCIF0
> ----------------------------------------------------------------- */
> SCIF_PFC_PIN(hscif0_data_a,	RCAR_GP_PIN(1, 17),	RCAR_GP_PIN(1, 18));

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper
  2013-04-19  3:07 [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper Kuninori Morimoto
  2013-04-22  5:24 ` Simon Horman
  2013-04-22 10:06 ` Laurent Pinchart
@ 2013-04-23  0:32 ` Kuninori Morimoto
  2013-04-26 18:33 ` Sergei Shtylyov
  3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2013-04-23  0:32 UTC (permalink / raw)
  To: linux-sh


Hi Laurent

> On Thursday 18 April 2013 20:07:34 Kuninori Morimoto wrote:
> > pfc-r8a7778 will have many devices pfc support in the future,
> > and current pfc-r8a7778 is using pin/mux definition macro for SCIF.
> > The device definition style using macro is readable code IMO,
> > but creating new macro for each devices is not good sense.
> > This patch adds common SH_PFC_xx() macro for each new feature devices
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
(snip)
> > +#define SH_PFC_MUX4(name, arg1, arg2, arg3, arg4)			\
> > +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, \
> > +						     arg3##_MARK, arg4##_MARK }
> 
> What's your plan for groups of more than 4 pins ? :-)
> 
> At some point, when the groups get large, I think it's better to define the 
> arrays explicitly.

Yes, I think so.

I am not forcing use of macro here.
If you can use these macros, you can use it.
If it is not match for your new pin, you can use array style.
I don't care so much.
Fortunately, these SCIF/SDHI cases, these can use macro.

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper
  2013-04-19  3:07 [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper Kuninori Morimoto
                   ` (2 preceding siblings ...)
  2013-04-23  0:32 ` Kuninori Morimoto
@ 2013-04-26 18:33 ` Sergei Shtylyov
  3 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2013-04-26 18:33 UTC (permalink / raw)
  To: linux-sh

Hello.

On 04/19/2013 07:07 AM, Kuninori Morimoto wrote:

> pfc-r8a7778 will have many devices pfc support in the future,
> and current pfc-r8a7778 is using pin/mux definition macro for SCIF.
> The device definition style using macro is readable code IMO,
> but creating new macro for each devices is not good sense.
> This patch adds common SH_PFC_xx() macro for each new feature devices
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v2 -> v3
>
>   - new patch
>
>   drivers/pinctrl/sh-pfc/pfc-r8a7778.c |   26 ++++++++++++++++++--------
>   1 file changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> index ddbd27b..139f9dd 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> @@ -1303,15 +1303,25 @@ static struct sh_pfc_pin pinmux_pins[] = {
>    */
>   #define PIN_NUMBER(row, col)		(1000+((row)-1)*25+(col)-1)
>   
> -/* - SCIF macro ------------------------------------------------------------- */
> -#define SCIF_PFC_PIN(name, args...)					\
> +/* - macro */
> +#define SH_PFC_PINS(name, args...) \
>   	static const unsigned int name ##_pins[] = { args }
> -#define SCIF_PFC_DAT(name, tx, rx)					\
> -	static const unsigned int name ##_mux[]  = { tx##_MARK, rx##_MARK, }
> -#define SCIF_PFC_CTR(name, cts, rts)					\
> -	static const unsigned int name ##_mux[]  = { cts##_MARK, rts##_MARK, }
> -#define SCIF_PFC_CLK(name, sck)					\
> -	static const unsigned int name ##_mux[]  = { sck##_MARK, }
> +#define SH_PFC_MUX1(name, arg1)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK }
> +#define SH_PFC_MUX2(name, arg1, arg2)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, }
> +#define SH_PFC_MUX3(name, arg1, arg2, arg3)					\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK,	\
> +						     arg3##_MARK }
> +#define SH_PFC_MUX4(name, arg1, arg2, arg3, arg4)			\
> +	static const unsigned int name ##_mux[]  = { arg1##_MARK, arg2##_MARK, \
> +						     arg3##_MARK, arg4##_MARK }

     I think you should also have added SH_PFC_MUX8(). I'll add it today.

WBR, Sergei


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-04-26 18:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19  3:07 [PATCH 1/3 v3] sh-pfc: r8a7778: add common PFC macro helper Kuninori Morimoto
2013-04-22  5:24 ` Simon Horman
2013-04-22 10:06 ` Laurent Pinchart
2013-04-23  0:32 ` Kuninori Morimoto
2013-04-26 18:33 ` Sergei Shtylyov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.