All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs
Date: Fri, 26 Apr 2013 14:18:26 -0500	[thread overview]
Message-ID: <517AD302.4000905@redhat.com> (raw)
In-Reply-To: <1367003813-17686-1-git-send-email-jbacik@fusionio.com>

On 4/26/13 2:16 PM, Josef Bacik wrote:
> mkfs.ext4 will ask you if you are sure if you try to mkfs an entire disk instead
> of just a partition, so any xfstest that uses a scratch device and you specify a
> full disk will appear to hang because it's waiting for you to say yes.  This
> fixes the problem by just forcing it to do its thing.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

The whole-disk test is pretty derpy anyway. Too bad -F overrides
much more than just that, but this is probably a decent
thing to do.

Thanks,
-Eric

> ---
>  common/rc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/rc b/common/rc
> index ff18cc2..9d1c3fc 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -485,7 +485,7 @@ _scratch_mkfs_ext4()
>  {
>  	local tmp_dir=/tmp/
>  
> -	/sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV \
> +	/sbin/mkfs -t $FSTYP -- -F $MKFS_OPTIONS $* $SCRATCH_DEV \
>  			2>$tmp_dir.mkfserr 1>$tmp_dir.mkfsstd
>  	local mkfs_status=$?
>  
> 


WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@redhat.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs
Date: Fri, 26 Apr 2013 14:18:26 -0500	[thread overview]
Message-ID: <517AD302.4000905@redhat.com> (raw)
In-Reply-To: <1367003813-17686-1-git-send-email-jbacik@fusionio.com>

On 4/26/13 2:16 PM, Josef Bacik wrote:
> mkfs.ext4 will ask you if you are sure if you try to mkfs an entire disk instead
> of just a partition, so any xfstest that uses a scratch device and you specify a
> full disk will appear to hang because it's waiting for you to say yes.  This
> fixes the problem by just forcing it to do its thing.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

The whole-disk test is pretty derpy anyway. Too bad -F overrides
much more than just that, but this is probably a decent
thing to do.

Thanks,
-Eric

> ---
>  common/rc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/rc b/common/rc
> index ff18cc2..9d1c3fc 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -485,7 +485,7 @@ _scratch_mkfs_ext4()
>  {
>  	local tmp_dir=/tmp/
>  
> -	/sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV \
> +	/sbin/mkfs -t $FSTYP -- -F $MKFS_OPTIONS $* $SCRATCH_DEV \
>  			2>$tmp_dir.mkfserr 1>$tmp_dir.mkfsstd
>  	local mkfs_status=$?
>  
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-04-26 19:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 19:16 [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs Josef Bacik
2013-04-26 19:16 ` Josef Bacik
2013-04-26 19:18 ` Eric Sandeen [this message]
2013-04-26 19:18   ` Eric Sandeen
2013-04-26 23:09   ` Andreas Dilger
2013-04-26 23:09     ` Andreas Dilger
2013-05-03 12:48 ` Rich Johnston
2013-05-03 12:48   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517AD302.4000905@redhat.com \
    --to=sandeen@redhat.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.