All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kexec: cleanup: make add_backup_segments static
@ 2013-04-27  6:35 Zhang Yanfei
  2013-04-30  0:35 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang Yanfei @ 2013-04-27  6:35 UTC (permalink / raw)
  To: Simon Horman; +Cc: kexec@lists.infradead.org

From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

The function add_backup_segments is only called by my_load and
they are in the same file. So unnecessary to export it. Make it
static.

Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
 kexec/kexec.c |    5 +++--
 kexec/kexec.h |    4 ----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/kexec/kexec.c b/kexec/kexec.c
index cf3fcb9..53d6edc 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -434,8 +434,9 @@ static int find_segment_hole(struct kexec_info *info,
 	return *size;
 }
 
-int add_backup_segments(struct kexec_info *info, unsigned long backup_base,
-			unsigned long backup_size)
+static int add_backup_segments(struct kexec_info *info,
+			       unsigned long backup_base,
+			       unsigned long backup_size)
 {
 	unsigned long mem_base, mem_size, bkseg_base, bkseg_size, start, end;
 	unsigned long pagesize;
diff --git a/kexec/kexec.h b/kexec/kexec.h
index 5ded390..715b568 100644
--- a/kexec/kexec.h
+++ b/kexec/kexec.h
@@ -285,10 +285,6 @@ int kexec_iomem_for_each_line(char *match,
 int parse_iomem_single(char *str, uint64_t *start, uint64_t *end);
 const char * proc_iomem(void);
 
-extern int add_backup_segments(struct kexec_info *info,
-			       unsigned long backup_base,
-			       unsigned long backup_size);
-
 #define MAX_LINE	160
 
 char *concat_cmdline(const char *base, const char *append);
-- 
1.7.1

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kexec: cleanup: make add_backup_segments static
  2013-04-27  6:35 [PATCH] kexec: cleanup: make add_backup_segments static Zhang Yanfei
@ 2013-04-30  0:35 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2013-04-30  0:35 UTC (permalink / raw)
  To: Zhang Yanfei; +Cc: kexec@lists.infradead.org

On Sat, Apr 27, 2013 at 02:35:11PM +0800, Zhang Yanfei wrote:
> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> 
> The function add_backup_segments is only called by my_load and
> they are in the same file. So unnecessary to export it. Make it
> static.
> 
> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

Thanks, applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-30  0:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-27  6:35 [PATCH] kexec: cleanup: make add_backup_segments static Zhang Yanfei
2013-04-30  0:35 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.