* [PATCH 4/6] compat/win32mmap.c: Fix some sparse warnings
@ 2013-04-27 19:18 Ramsay Jones
0 siblings, 0 replies; only message in thread
From: Ramsay Jones @ 2013-04-27 19:18 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list
Sparse issues two 'Using plain integer as NULL pointer' warnings
against the call to the CreateFileMapping() function. The warnings
relate to the second and sixth parameters, which both have pointer
type. In order to suppress the warnings, we simply pass the NULL
pointer, rather than '0', to those parameters in the function call.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
compat/win32mmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/compat/win32mmap.c b/compat/win32mmap.c
index 61d2ef8..80a8c9a 100644
--- a/compat/win32mmap.c
+++ b/compat/win32mmap.c
@@ -21,8 +21,8 @@ void *git_mmap(void *start, size_t length, int prot, int flags, int fd, off_t of
if (!(flags & MAP_PRIVATE))
die("Invalid usage of mmap when built with USE_WIN32_MMAP");
- hmap = CreateFileMapping((HANDLE)_get_osfhandle(fd), 0, PAGE_WRITECOPY,
- 0, 0, 0);
+ hmap = CreateFileMapping((HANDLE)_get_osfhandle(fd), NULL,
+ PAGE_WRITECOPY, 0, 0, NULL);
if (!hmap)
return MAP_FAILED;
--
1.8.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-04-27 19:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-27 19:18 [PATCH 4/6] compat/win32mmap.c: Fix some sparse warnings Ramsay Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.