From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: blauwirbel@gmail.com, sw@weilnetz.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/5] add missing inclusions of config-host.h
Date: Sat, 27 Apr 2013 23:08:38 +0200 [thread overview]
Message-ID: <517C3E56.6010705@redhat.com> (raw)
In-Reply-To: <CAFEAcA9uQMU9RtcB93tLonT+ST6Vczpsc_c_PgO4GT7fSpZoaw@mail.gmail.com>
Il 27/04/2013 15:19, Peter Maydell ha scritto:
>>>> >> > The next patch will add a dependency of qemu/osdep.h on config-host.h.
>>>> >> > It could be nicer to use qemu-common.h, but I prefer to be safer this
>>>> >> > close to hard feature freeze.
>>> >> Can't we just include config-host.h from osdep.h ?
>> >
>> > Yes, but that is also a bit more risky than I think we can afford at
>> > this point.
> Not sure I understand where the risk is -- all it does is
> define a pile of CONFIG_* macros, right?
Yeah, I was unsure about triggering changes in all files that include
osdep.h, but there aren't that many actually. Most files get it via
qemu-common.h, and qemu-common.h includes config-host.h.
Paolo
next prev parent reply other threads:[~2013-04-27 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 11:48 [Qemu-devel] [PATCH 1.5 v5 0/5] fix win32 compilation Paolo Bonzini
2013-04-27 11:48 ` [Qemu-devel] [PATCH 1/5] win32: add generic RC rules to rules.mak Paolo Bonzini
2013-04-27 11:48 ` [Qemu-devel] [PATCH 2/5] win32: move Makefile dependencies on version-obj-y " Paolo Bonzini
2013-04-27 11:48 ` [Qemu-devel] [PATCH 3/5] win32: generate console executable again Paolo Bonzini
2013-04-27 11:48 ` [Qemu-devel] [PATCH 4/5] add missing inclusions of config-host.h Paolo Bonzini
2013-04-27 13:11 ` Peter Maydell
2013-04-27 13:14 ` Paolo Bonzini
2013-04-27 13:19 ` Peter Maydell
2013-04-27 21:08 ` Paolo Bonzini [this message]
2013-04-27 11:48 ` [Qemu-devel] [PATCH 5/5] win32: add readv/writev emulation Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517C3E56.6010705@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.