From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: si5351: Apply rate when clock-frequency is defined in devicetree.
Date: Sun, 28 Apr 2013 10:59:41 +0200 [thread overview]
Message-ID: <517CE4FD.9010406@gmail.com> (raw)
In-Reply-To: <1366698170-31346-2-git-send-email-marek.belisko@streamunlimited.com>
On 04/23/2013 08:22 AM, Marek Belisko wrote:
> clock-frequency property from devicetree was read but never used. Apply
> defined rate when clock is registered.
>
> Signed-off-by: Marek Belisko<marek.belisko@streamunlimited.com>
> ---
> drivers/clk/clk-si5351.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> index cf39e53..8323c31 100644
> --- a/drivers/clk/clk-si5351.c
> +++ b/drivers/clk/clk-si5351.c
> @@ -1477,6 +1477,16 @@ static int si5351_i2c_probe(struct i2c_client *client,
> return -EINVAL;
> }
> drvdata->onecell.clks[n] = clk;
> +
> + /* set rate when defined in devicetree */
nit: We also set the rate when it is defined in platform_data
(which is disabled because there is still some CONFIG_OF dependency).
Anyway, the above comment and patch subject should refer to platform
data instead.
If you can send an updated version of this patch you get my
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> + if (pdata->clkout[n].rate != 0) {
> + int ret;
> + ret = clk_set_rate(clk, pdata->clkout[n].rate);
> + if (ret != 0) {
> + dev_err(&client->dev, "Cannot set rate : %d\n",
> + ret);
> + }
> + }
> }
>
> ret = of_clk_add_provider(client->dev.of_node, of_clk_src_onecell_get,
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Marek Belisko <marek.belisko@gmail.com>
Cc: mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, zonque@gmail.com,
Marek Belisko <marek.belisko@streamunlimited.com>
Subject: Re: [PATCH 2/2] clk: si5351: Apply rate when clock-frequency is defined in devicetree.
Date: Sun, 28 Apr 2013 10:59:41 +0200 [thread overview]
Message-ID: <517CE4FD.9010406@gmail.com> (raw)
In-Reply-To: <1366698170-31346-2-git-send-email-marek.belisko@streamunlimited.com>
On 04/23/2013 08:22 AM, Marek Belisko wrote:
> clock-frequency property from devicetree was read but never used. Apply
> defined rate when clock is registered.
>
> Signed-off-by: Marek Belisko<marek.belisko@streamunlimited.com>
> ---
> drivers/clk/clk-si5351.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> index cf39e53..8323c31 100644
> --- a/drivers/clk/clk-si5351.c
> +++ b/drivers/clk/clk-si5351.c
> @@ -1477,6 +1477,16 @@ static int si5351_i2c_probe(struct i2c_client *client,
> return -EINVAL;
> }
> drvdata->onecell.clks[n] = clk;
> +
> + /* set rate when defined in devicetree */
nit: We also set the rate when it is defined in platform_data
(which is disabled because there is still some CONFIG_OF dependency).
Anyway, the above comment and patch subject should refer to platform
data instead.
If you can send an updated version of this patch you get my
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> + if (pdata->clkout[n].rate != 0) {
> + int ret;
> + ret = clk_set_rate(clk, pdata->clkout[n].rate);
> + if (ret != 0) {
> + dev_err(&client->dev, "Cannot set rate : %d\n",
> + ret);
> + }
> + }
> }
>
> ret = of_clk_add_provider(client->dev.of_node, of_clk_src_onecell_get,
next prev parent reply other threads:[~2013-04-28 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 6:22 [PATCH 1/2] clk: si5351: Fix clkout rate computation Marek Belisko
2013-04-23 6:22 ` Marek Belisko
2013-04-23 6:22 ` [PATCH 2/2] clk: si5351: Apply rate when clock-frequency is defined in devicetree Marek Belisko
2013-04-23 6:22 ` Marek Belisko
2013-04-28 8:59 ` Sebastian Hesselbarth [this message]
2013-04-28 8:59 ` Sebastian Hesselbarth
2013-04-28 8:56 ` [PATCH 1/2] clk: si5351: Fix clkout rate computation Sebastian Hesselbarth
2013-04-28 8:56 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517CE4FD.9010406@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.