From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [PATCH] memory: give name every AddressSpace
Date: Mon, 29 Apr 2013 11:25:16 +0200 [thread overview]
Message-ID: <517E3C7C.3080604@redhat.com> (raw)
In-Reply-To: <517E2D74.3070804@ozlabs.ru>
Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto:
>>> >> + g_free((void *)as->name);
>> >
>> > No cast here.
> ?
>
> CC ppc64-softmmu/memory.o
> /home/alexey/pcipassthru/qemu-impreza/memory.c: In function
> 'address_space_destroy':
> /home/alexey/pcipassthru/qemu-impreza/memory.c:1626:5: warning: passing
> argument 1 of 'g_free' discards 'const' qualifier from pointer target type
> [enabled by default]
> g_free(/*(void *)*/as->name);
> ^
Please remove the const from as->name instead. Since you are strdup-ing
it, and the field is meant to be private to memory.c anyway, you do not
need protection against changing it.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace
Date: Mon, 29 Apr 2013 11:25:16 +0200 [thread overview]
Message-ID: <517E3C7C.3080604@redhat.com> (raw)
In-Reply-To: <517E2D74.3070804@ozlabs.ru>
Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto:
>>> >> + g_free((void *)as->name);
>> >
>> > No cast here.
> ?
>
> CC ppc64-softmmu/memory.o
> /home/alexey/pcipassthru/qemu-impreza/memory.c: In function
> 'address_space_destroy':
> /home/alexey/pcipassthru/qemu-impreza/memory.c:1626:5: warning: passing
> argument 1 of 'g_free' discards 'const' qualifier from pointer target type
> [enabled by default]
> g_free(/*(void *)*/as->name);
> ^
Please remove the const from as->name instead. Since you are strdup-ing
it, and the field is meant to be private to memory.c anyway, you do not
need protection against changing it.
Paolo
next prev parent reply other threads:[~2013-04-29 9:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 6:02 [Qemu-devel] [0/4] RFC: Preparations for VFIO and guest IOMMUs (v2) David Gibson
2013-04-26 6:02 ` [Qemu-devel] [PATCH 1/4] Fix vmw_pvscsi.c for iommu support changes David Gibson
2013-04-26 8:19 ` Paolo Bonzini
2013-04-26 11:04 ` David Gibson
2013-04-26 6:02 ` [Qemu-devel] [PATCH 2/4] vfio: Associate VFIO groups with (guest) IOMMU address spaces David Gibson
2013-04-26 6:02 ` [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion David Gibson
2013-04-26 8:23 ` Paolo Bonzini
2013-04-26 11:31 ` David Gibson
2013-04-26 13:40 ` Paolo Bonzini
2013-04-27 9:49 ` David Gibson
2013-04-27 12:17 ` Paolo Bonzini
2013-04-28 1:58 ` David Gibson
2013-04-29 8:11 ` Paolo Bonzini
2013-04-29 11:00 ` David Gibson
2013-04-29 11:38 ` Paolo Bonzini
2013-04-29 11:56 ` David Gibson
2013-04-29 13:44 ` Paolo Bonzini
2013-04-30 2:05 ` David Gibson
2013-04-30 2:23 ` David Gibson
2013-04-30 7:30 ` Paolo Bonzini
2013-04-30 7:54 ` David Gibson
2013-04-29 2:11 ` [Qemu-trivial] [PATCH] memory: give name every AddressSpace Alexey Kardashevskiy
2013-04-29 2:11 ` [Qemu-devel] " Alexey Kardashevskiy
2013-04-29 8:16 ` [Qemu-trivial] " Paolo Bonzini
2013-04-29 8:16 ` [Qemu-devel] " Paolo Bonzini
2013-04-29 8:21 ` [Qemu-trivial] " Alexey Kardashevskiy
2013-04-29 8:21 ` [Qemu-devel] " Alexey Kardashevskiy
2013-04-29 9:25 ` Paolo Bonzini [this message]
2013-04-29 9:25 ` Paolo Bonzini
2013-04-29 11:09 ` [Qemu-trivial] " David Gibson
2013-04-29 11:09 ` [Qemu-devel] " David Gibson
2013-04-30 2:14 ` Alexey Kardashevskiy
2013-04-26 6:02 ` [Qemu-devel] [PATCH 4/4] vfio: Only use memory listeners when appropriate David Gibson
2013-04-26 15:42 ` [Qemu-devel] [0/4] RFC: Preparations for VFIO and guest IOMMUs (v2) Alex Williamson
2013-04-27 9:51 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E3C7C.3080604@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.