* Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model
[not found] ` <5128C6B0.8060303@suse.de>
@ 2013-04-29 10:56 ` Jan Kiszka
0 siblings, 0 replies; only message in thread
From: Jan Kiszka @ 2013-04-29 10:56 UTC (permalink / raw)
To: Andreas Färber; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
On 2013-02-23 14:40, Andreas Färber wrote:
>> +static int at24_init(I2CSlave *i2c)
>
> hw/i2c.c:i2c_slave_qdev_init() calls I2CSlaveClass::init only, so please
> use a realize function instead. Cf. hw/qdev-core.h.
>
>> +{
>> + AT24State *s = DO_UPCAST(AT24State, i2c, i2c);
>> + unsigned int page_size;
>> + int64_t image_size;
>> + int device_bits;
>> + int hi_addr_bits;
>> + int dev_no;
>> +
>> + assert(AT24_MAX_PAGE_LEN <= BDRV_SECTOR_SIZE);
>
> This should instead do error_setg(errp, "...") then.
I just noticed with my latest code that the messages set via error_setg
do not make it to the terminal when initializing the device from the
command line. Known issue?
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-04-29 10:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1361565596.git.jan.kiszka@siemens.com>
[not found] ` <661021052fba1fed3d9d872b47ae050c5593ebfc.1361565596.git.jan.kiszka@siemens.com>
[not found] ` <5128C6B0.8060303@suse.de>
2013-04-29 10:56 ` [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.