All of lore.kernel.org
 help / color / mirror / Atom feed
* perf: report loops endlessly if record was killed via SIGTERM
@ 2013-04-29  8:00 Mike Galbraith
  2013-04-29 11:27 ` David Ahern
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Galbraith @ 2013-04-29  8:00 UTC (permalink / raw)
  To: LKML; +Cc: Arnaldo Carvalho de Melo

Boring notabug report, but..

(Dr. Dr., perf acts all dainbramaged when you shoot it in the head)

reproducer: perf record -a -g& sleep 1;whatever;killall perf

Discovered because AIM7 needs input, and does not run properly when
profiled via the more conventional perf record -a -g -- ./multitask -nl
-f.  Ergo, start perf record, run AIM7, kill perf.  Say SIGINT instead,
and it works as expected.  SIGTERM leaves perf.data in a bad state that
report can't deal with, but it'll happily keep trying forever.

Only mentioned because some other user might try to workaround input
nogo thingy and meet the same.

	-Mike


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: perf: report loops endlessly if record was killed via SIGTERM
  2013-04-29  8:00 perf: report loops endlessly if record was killed via SIGTERM Mike Galbraith
@ 2013-04-29 11:27 ` David Ahern
  2013-04-29 11:43   ` Mike Galbraith
  0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2013-04-29 11:27 UTC (permalink / raw)
  To: Mike Galbraith; +Cc: LKML, Arnaldo Carvalho de Melo

On 4/29/13 4:00 AM, Mike Galbraith wrote:
> Say SIGINT instead,
> and it works as expected.  SIGTERM leaves perf.data in a bad state that
> report can't deal with, but it'll happily keep trying forever.

header is usually updated on_exit which requires a clean exit. perhaps 
we should add SIGTERM to the signal list.

David

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: perf: report loops endlessly if record was killed via SIGTERM
  2013-04-29 11:27 ` David Ahern
@ 2013-04-29 11:43   ` Mike Galbraith
  0 siblings, 0 replies; 3+ messages in thread
From: Mike Galbraith @ 2013-04-29 11:43 UTC (permalink / raw)
  To: David Ahern; +Cc: LKML, Arnaldo Carvalho de Melo

On Mon, 2013-04-29 at 07:27 -0400, David Ahern wrote: 
> On 4/29/13 4:00 AM, Mike Galbraith wrote:
> > Say SIGINT instead,
> > and it works as expected.  SIGTERM leaves perf.data in a bad state that
> > report can't deal with, but it'll happily keep trying forever.
> 
> header is usually updated on_exit which requires a clean exit. perhaps 
> we should add SIGTERM to the signal list.

Yeah.  Graceful exit, and idiot proofing for free :)

-Mike


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-29 11:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-29  8:00 perf: report loops endlessly if record was killed via SIGTERM Mike Galbraith
2013-04-29 11:27 ` David Ahern
2013-04-29 11:43   ` Mike Galbraith

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.