flexcan: use hardware timestamp

flexcan: use hardware timestamp

[Sven Schuchmann]

Hello,
I was wondering if the flexcan driver uses the hardware timestamp
and by looking at the code under drivers/net/can/flexcan.c and did
not find any access to those registers.
 
is there a special reason for this?
 
If not, I would try implementing to use skb_shared_hwtstamps...
 
Best Regards,
 
   Sven

Re: flexcan: use hardware timestamp

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

On 04/29/2013 07:33 PM, Sven Schuchmann wrote:
> Hello,
> I was wondering if the flexcan driver uses the hardware timestamp
> and by looking at the code under drivers/net/can/flexcan.c and did
> not find any access to those registers.
>  
> is there a special reason for this?

Yes, no one has implemented it yet :)

> If not, I would try implementing to use skb_shared_hwtstamps...

Go ahead.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: flexcan: use hardware timestamp

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

On 04/29/2013 07:58 PM, Marc Kleine-Budde wrote:
> On 04/29/2013 07:33 PM, Sven Schuchmann wrote:
>> Hello,
>> I was wondering if the flexcan driver uses the hardware timestamp
>> and by looking at the code under drivers/net/can/flexcan.c and did
>> not find any access to those registers.
>>  
>> is there a special reason for this?
> 
> Yes, no one has implemented it yet :)
> 
>> If not, I would try implementing to use skb_shared_hwtstamps...

I mean, go ahead implement hardware timestamps, but I haven't checked if
skb_shared_hwtstamps is the correct interface.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: flexcan: use hardware timestamp

[wg]

On Mon, 29 Apr 2013 20:00:17 +0200, Marc Kleine-Budde <mkl@pengutronix.de>

wrote:

> On 04/29/2013 07:58 PM, Marc Kleine-Budde wrote:

>> On 04/29/2013 07:33 PM, Sven Schuchmann wrote:

>>> Hello,

>>> I was wondering if the flexcan driver uses the hardware timestamp

>>> and by looking at the code under drivers/net/can/flexcan.c and did

>>> not find any access to those registers.

>>>  

>>> is there a special reason for this?

>> 

>> Yes, no one has implemented it yet :)

>> 

>>> If not, I would try implementing to use skb_shared_hwtstamps...

> 

> I mean, go ahead implement hardware timestamps, but I haven't checked if

> skb_shared_hwtstamps is the correct interface.



Looks good according to:



http://lxr.linux.no/#linux+v3.9/Documentation/networking/timestamping.txt

http://lxr.linux.no/#linux+v3.9/Documentation/networking/timestamping/timestamping.c



Wolfgang,