recent kvm-kmod commit breaks on F18

recent kvm-kmod commit breaks on F18

[Gabriel L. Somlo]

Jan,

Bisect says that commit 4fb60de74f93a601775dbda053b3237634d7a417
to kvm-kmod is what causes breakage on my (otherwise stock) F18 box
(with kernel version 3.8.9-200.fc18.x86_64):

make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` clean
make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
  CLEAN   /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/.tmp_versions
make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
rm -f config.mak kvm-kmod-config.h include/asm include-compat/asm
.tmp.kvm-kmod.spec
make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` clean
make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
./sync -v  v3.8-12811-gebe8054 -l ./linux
make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` \
        LINUXINCLUDE="-I`pwd`/include -I`pwd`/include/uapi -Iinclude \
                 -Iinclude2
-I/lib/modules/3.8.9-200.fc18.x86_64/source/include
-I/lib/modules/3.8.9-200.fc18.x86_64/source/include/uapi
-I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include
-I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include/uapi \
                -Iinclude/generated/uapi -Iarch/x86/include/generated
\
                -Iarch/x86/include/generated/uapi \
                -I`pwd`/include-compat -I`pwd`/x86 \
                -include  include/generated/autoconf.h \
                -include `pwd`/x86/external-module-compat.h" \
        "$@"
make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
  LD      /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/built-in.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/svm.o
/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/svm.c:2790:12: warning:
`invalid_op_interception' defined but not used [-Wunused-function]
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/vmx.o
/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/vmx.c:5313:12: warning:
`handle_invalid_op' defined but not used [-Wunused-function]
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/kvm_main.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/x86.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/mmu.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/emulate.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/irq.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/i8259.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/pmu.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/lapic.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/ioapic.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/preempt.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/i8254.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/coalesced_mmio.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/irq_comm.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/eventfd.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/compat-x86.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/async_pf.o
  CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/cpuid.o
make[3]: *** No rule to make target
`/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/irqchip.o', needed by
`/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/kvm.o'.  Stop.
make[2]: *** [/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86] Error 2
make[1]: *** [_module_/home/somlo/KVM-OSX/SCRATCH/kvm-kmod] Error 2
make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
make: *** [all] Error 2

Thanks,
--Gabriel

Re: recent kvm-kmod commit breaks on F18

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 3849 bytes --]

On 2013-04-29 20:33, Gabriel L. Somlo wrote:
> Jan,
> 
> Bisect says that commit 4fb60de74f93a601775dbda053b3237634d7a417

That commit alone is broken as it depends on the refactorings being
selected by the submodule update.

Does the problem persist with current master checked out into a clean
folder?

Jan

> to kvm-kmod is what causes breakage on my (otherwise stock) F18 box
> (with kernel version 3.8.9-200.fc18.x86_64):
> 
> make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` clean
> make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
>   CLEAN   /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/.tmp_versions
> make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
> rm -f config.mak kvm-kmod-config.h include/asm include-compat/asm
> .tmp.kvm-kmod.spec
> make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` clean
> make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
> make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
> ./sync -v  v3.8-12811-gebe8054 -l ./linux
> make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` \
>         LINUXINCLUDE="-I`pwd`/include -I`pwd`/include/uapi -Iinclude \
>                  -Iinclude2
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/include
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/include/uapi
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include/uapi \
>                 -Iinclude/generated/uapi -Iarch/x86/include/generated
> \
>                 -Iarch/x86/include/generated/uapi \
>                 -I`pwd`/include-compat -I`pwd`/x86 \
>                 -include  include/generated/autoconf.h \
>                 -include `pwd`/x86/external-module-compat.h" \
>         "$@"
> make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
>   LD      /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/built-in.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/svm.o
> /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/svm.c:2790:12: warning:
> `invalid_op_interception' defined but not used [-Wunused-function]
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/vmx.o
> /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/vmx.c:5313:12: warning:
> `handle_invalid_op' defined but not used [-Wunused-function]
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/kvm_main.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/x86.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/mmu.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/emulate.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/irq.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/i8259.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/pmu.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/lapic.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/ioapic.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/preempt.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/i8254.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/coalesced_mmio.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/irq_comm.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/eventfd.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/compat-x86.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/async_pf.o
>   CC [M]  /home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/cpuid.o
> make[3]: *** No rule to make target
> `/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/irqchip.o', needed by
> `/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86/kvm.o'.  Stop.
> make[2]: *** [/home/somlo/KVM-OSX/SCRATCH/kvm-kmod/x86] Error 2
> make[1]: *** [_module_/home/somlo/KVM-OSX/SCRATCH/kvm-kmod] Error 2
> make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
> make: *** [all] Error 2
> 
> Thanks,
> --Gabriel



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: recent kvm-kmod commit breaks on F18

[Gabriel L. Somlo]

On Mon, Apr 29, 2013 at 09:06:37PM +0200, Jan Kiszka wrote:
> > Bisect says that commit 4fb60de74f93a601775dbda053b3237634d7a417
> 
> That commit alone is broken as it depends on the refactorings being
> selected by the submodule update.
> 
> Does the problem persist with current master checked out into a clean
> folder?

OK, after further digging, following your canonical steps
(i.e. "git submodule update --init") seems to work without problems.

Instead, i was replacing the "linux" directory from kvm-kmod with a
symlink to ../kvm (itself obtained via "git clone"), in a (potentially
misguided) attempt to stay on the master branch of both projects.

That *used* to work until the recent update. Now that I know I'm
"off the reservation", I haven't yet figured out how "reasonable" vs.
"bone-headed" of a thing that is... :)

Any further clue much appreciated !

Thx,
--Gabriel

Re: recent kvm-kmod commit breaks on F18

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

On 2013-04-29 21:44, Gabriel L. Somlo wrote:
> On Mon, Apr 29, 2013 at 09:06:37PM +0200, Jan Kiszka wrote:
>>> Bisect says that commit 4fb60de74f93a601775dbda053b3237634d7a417
>>
>> That commit alone is broken as it depends on the refactorings being
>> selected by the submodule update.
>>
>> Does the problem persist with current master checked out into a clean
>> folder?
> 
> OK, after further digging, following your canonical steps
> (i.e. "git submodule update --init") seems to work without problems.
> 
> Instead, i was replacing the "linux" directory from kvm-kmod with a
> symlink to ../kvm (itself obtained via "git clone"), in a (potentially
> misguided) attempt to stay on the master branch of both projects.
> 
> That *used* to work until the recent update. Now that I know I'm
> "off the reservation", I haven't yet figured out how "reasonable" vs.
> "bone-headed" of a thing that is... :)

Linking should work as well, though is unnecessary:

   make LINUX=/path/to/your/repo sync

That's what I'm doing all the time to test my kvm hacks on my
not-so-recent host kernel.

Jan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: recent kvm-kmod commit breaks on F18

[Gabriel L. Somlo]

On Mon, Apr 29, 2013 at 10:09:42PM +0200, Jan Kiszka wrote:
> On 2013-04-29 21:44, Gabriel L. Somlo wrote:
> > On Mon, Apr 29, 2013 at 09:06:37PM +0200, Jan Kiszka wrote:
> >>> Bisect says that commit 4fb60de74f93a601775dbda053b3237634d7a417
> Linking should work as well, though is unnecessary:
> 
>    make LINUX=/path/to/your/repo sync
> 
> That's what I'm doing all the time to test my kvm hacks on my
> not-so-recent host kernel.

OK, I "git clone"d both kvm and kvm-kmod right alongside each other in
a test directory. I then went into kvm-kmod, and did

./configure
make LINUX=../kvm sync
make

and got the same error as before:


make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` \
        LINUXINCLUDE="-I`pwd`/include -I`pwd`/include/uapi -Iinclude \
                 -Iinclude2
-I/lib/modules/3.8.9-200.fc18.x86_64/source/include
-I/lib/modules/3.8.9-200.fc18.x86_64/source/include/uapi
-I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include
-I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include/uapi \
                -Iinclude/generated/uapi -Iarch/x86/include/generated
\
                -Iarch/x86/include/generated/uapi \
                -I`pwd`/include-compat -I`pwd`/x86 \
                -include  include/generated/autoconf.h \
                -include `pwd`/x86/external-module-compat.h" \
        "$@"
make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
make[3]: *** No rule to make target
`/home/somlo/FOO/kvm-kmod/x86/irqchip.o', needed by
`/home/somlo/FOO/kvm-kmod/x86/kvm.o'.  Stop.
make[2]: *** [/home/somlo/FOO/kvm-kmod/x86] Error 2
make[1]: *** [_module_/home/somlo/FOO/kvm-kmod] Error 2
make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
make: *** [all] Error 2


This happens when I symlink (or use LINUX=../kvm with "make sync"),
but works OK with "git submodule update --init" (which I'd rather
avoid if possible).

Thanks,
--Gabriel

Re: recent kvm-kmod commit breaks on F18

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 2209 bytes --]

On 2013-04-29 22:30, Gabriel L. Somlo wrote:
> On Mon, Apr 29, 2013 at 10:09:42PM +0200, Jan Kiszka wrote:
>> On 2013-04-29 21:44, Gabriel L. Somlo wrote:
>>> On Mon, Apr 29, 2013 at 09:06:37PM +0200, Jan Kiszka wrote:
>>>>> Bisect says that commit 4fb60de74f93a601775dbda053b3237634d7a417
>> Linking should work as well, though is unnecessary:
>>
>>    make LINUX=/path/to/your/repo sync
>>
>> That's what I'm doing all the time to test my kvm hacks on my
>> not-so-recent host kernel.
> 
> OK, I "git clone"d both kvm and kvm-kmod right alongside each other in
> a test directory. I then went into kvm-kmod, and did
> 
> ./configure
> make LINUX=../kvm sync
> make
> 
> and got the same error as before:
> 
> 
> make -C /lib/modules/3.8.9-200.fc18.x86_64/build M=`pwd` \
>         LINUXINCLUDE="-I`pwd`/include -I`pwd`/include/uapi -Iinclude \
>                  -Iinclude2
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/include
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/include/uapi
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include
> -I/lib/modules/3.8.9-200.fc18.x86_64/source/arch/x86/include/uapi \
>                 -Iinclude/generated/uapi -Iarch/x86/include/generated
> \
>                 -Iarch/x86/include/generated/uapi \
>                 -I`pwd`/include-compat -I`pwd`/x86 \
>                 -include  include/generated/autoconf.h \
>                 -include `pwd`/x86/external-module-compat.h" \
>         "$@"
> make[1]: Entering directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
> make[3]: *** No rule to make target
> `/home/somlo/FOO/kvm-kmod/x86/irqchip.o', needed by
> `/home/somlo/FOO/kvm-kmod/x86/kvm.o'.  Stop.
> make[2]: *** [/home/somlo/FOO/kvm-kmod/x86] Error 2
> make[1]: *** [_module_/home/somlo/FOO/kvm-kmod] Error 2
> make[1]: Leaving directory `/usr/src/kernels/3.8.9-200.fc18.x86_64'
> make: *** [all] Error 2
> 
> 
> This happens when I symlink (or use LINUX=../kvm with "make sync"),
> but works OK with "git submodule update --init" (which I'd rather
> avoid if possible).

I dare to say that ../kvm/virt/kvm/irqchip.c does not exit, thus your
external kvm directory is not recent enough.

Jan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: recent kvm-kmod commit breaks on F18

[Gabriel L. Somlo]

On Mon, Apr 29, 2013 at 10:33:29PM +0200, Jan Kiszka wrote:
> I dare to say that ../kvm/virt/kvm/irqchip.c does not exit, thus your
> external kvm directory is not recent enough.

That's weird, I just did a

	git clone git://git.kernel.org/pub/scm/virt/kvm/kvm.git

literally five minutes ago, specifically to test your "LINUX=..."
method before replying, on the off chance there would have been a
difference in behavior vs. the symlink thing I was complaining
about earlier...

--G

Re: recent kvm-kmod commit breaks on F18

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On 2013-04-29 22:39, Gabriel L. Somlo wrote:
> On Mon, Apr 29, 2013 at 10:33:29PM +0200, Jan Kiszka wrote:
>> I dare to say that ../kvm/virt/kvm/irqchip.c does not exit, thus your
>> external kvm directory is not recent enough.
> 
> That's weird, I just did a
> 
> 	git clone git://git.kernel.org/pub/scm/virt/kvm/kvm.git

git checkout [-b <local-branch>] origin/next

If you run "git submodule update" from inside kvm-mod, this checkout is
done for you already.

Jan

> 
> literally five minutes ago, specifically to test your "LINUX=..."
> method before replying, on the off chance there would have been a
> difference in behavior vs. the symlink thing I was complaining
> about earlier...
> 
> --G
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: recent kvm-kmod commit breaks on F18

[Gabriel L. Somlo]

On Mon, Apr 29, 2013 at 10:41:36PM +0200, Jan Kiszka wrote:
> On 2013-04-29 22:39, Gabriel L. Somlo wrote:
> > On Mon, Apr 29, 2013 at 10:33:29PM +0200, Jan Kiszka wrote:
> >> I dare to say that ../kvm/virt/kvm/irqchip.c does not exit, thus your
> >> external kvm directory is not recent enough.
>
> > 	git clone git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> 
> git checkout [-b <local-branch>] origin/next
> 
> If you run "git submodule update" from inside kvm-mod, this checkout is
> done for you already.

Hmm... "origin/next" doesn't seem to be an available option. Aside from
"kvm-XYZ" and "vX.Y.Z-rcABC", there's HEAD, master, origin/HEAD, and
origin/MASTER.

Picking either one of those doesn't seem to help. FWIW, "git submodule
update" checks out commit 5a2892ce72e010e3cb96b438d7cdddce0c88e0e6
as a detached head, but explicitly checking that out in the vanilla
clone of KVM before using LINUX=../kvm still doesn't work...

Aside from wondering what's wrong with just the kvm default "master",
I think I need to go learn some more about git :)

Thanks,
--Gabriel