From: Ric Mason <ric.masonn@gmail.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Sam Ben <sam.bennn@gmail.com>,
Alexey Lyahkov <alexey.lyashkov@gmail.com>,
Andrew Perepechko <anserper@ya.ru>,
Robin Dong <sanbai@taobao.com>, Theodore Tso <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Bernd Schubert <bernd.schubert@fastmail.fm>,
David Howells <dhowells@redhat.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux-ext4 <linux-ext4@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list
Date: Wed, 01 May 2013 16:14:16 +0800 [thread overview]
Message-ID: <5180CED8.9040505@gmail.com> (raw)
In-Reply-To: <20130501080644.GE11497@suse.de>
On 05/01/2013 04:06 PM, Mel Gorman wrote:
> On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote:
>> Hi Mel,
>> On 04/30/2013 12:31 AM, Mel Gorman wrote:
>>> If a page is on a pagevec then it is !PageLRU and mark_page_accessed()
>>> may fail to move a page to the active list as expected. Now that the
>>> LRU is selected at LRU drain time, mark pages PageActive if they are
>>> on a pagevec so it gets moved to the correct list at LRU drain time.
>>> Using a debugging patch it was found that for a simple git checkout
>>> based workload that pages were never added to the active file list in
>> Could you show us the details of your workload?
>>
> The workload is git checkouts of a fixed number of commits for the
Is there script which you used?
> kernel git tree. It starts with a warm-up run that is not timed and then
> records the time for a number of iterations.
How to record the time for a number of iterations? Is the iteration here
means lru scan?
>
WARNING: multiple messages have this Message-ID (diff)
From: Ric Mason <ric.masonn@gmail.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Sam Ben <sam.bennn@gmail.com>,
Alexey Lyahkov <alexey.lyashkov@gmail.com>,
Andrew Perepechko <anserper@ya.ru>,
Robin Dong <sanbai@taobao.com>, Theodore Tso <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Bernd Schubert <bernd.schubert@fastmail.fm>,
David Howells <dhowells@redhat.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux-ext4 <linux-ext4@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list
Date: Wed, 01 May 2013 16:14:16 +0800 [thread overview]
Message-ID: <5180CED8.9040505@gmail.com> (raw)
In-Reply-To: <20130501080644.GE11497@suse.de>
On 05/01/2013 04:06 PM, Mel Gorman wrote:
> On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote:
>> Hi Mel,
>> On 04/30/2013 12:31 AM, Mel Gorman wrote:
>>> If a page is on a pagevec then it is !PageLRU and mark_page_accessed()
>>> may fail to move a page to the active list as expected. Now that the
>>> LRU is selected at LRU drain time, mark pages PageActive if they are
>>> on a pagevec so it gets moved to the correct list at LRU drain time.
>>> Using a debugging patch it was found that for a simple git checkout
>>> based workload that pages were never added to the active file list in
>> Could you show us the details of your workload?
>>
> The workload is git checkouts of a fixed number of commits for the
Is there script which you used?
> kernel git tree. It starts with a warm-up run that is not timed and then
> records the time for a number of iterations.
How to record the time for a number of iterations? Is the iteration here
means lru scan?
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-01 8:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 16:31 [RFC PATCH 0/3] Obey mark_page_accessed hint given by filesystems Mel Gorman
2013-04-29 16:31 ` Mel Gorman
2013-04-29 16:31 ` [PATCH 1/3] mm: pagevec: Defer deciding what LRU to add a page to until pagevec drain time Mel Gorman
2013-04-29 16:31 ` Mel Gorman
2013-04-29 16:50 ` Rik van Riel
2013-04-29 16:50 ` Rik van Riel
2013-05-03 7:51 ` Jan Kara
2013-05-03 7:51 ` Jan Kara
2013-05-03 8:37 ` Mel Gorman
2013-05-03 8:37 ` Mel Gorman
2013-04-29 16:31 ` [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list Mel Gorman
2013-04-29 16:31 ` Mel Gorman
2013-04-29 17:12 ` Rik van Riel
2013-04-29 17:12 ` Rik van Riel
2013-04-29 21:53 ` Mel Gorman
2013-04-29 21:53 ` Mel Gorman
2013-05-01 5:41 ` Sam Ben
2013-05-01 5:41 ` Sam Ben
2013-05-01 8:06 ` Mel Gorman
2013-05-01 8:06 ` Mel Gorman
2013-05-01 8:14 ` Ric Mason [this message]
2013-05-01 8:14 ` Ric Mason
2013-05-01 8:31 ` Mel Gorman
2013-05-01 8:31 ` Mel Gorman
2013-04-29 16:31 ` [PATCH 3/3] mm: Remove lru parameter from __pagevec_lru_add and remove parts of pagevec API Mel Gorman
2013-04-29 16:31 ` Mel Gorman
2013-05-03 8:00 ` Jan Kara
2013-05-03 8:00 ` Jan Kara
2013-05-01 6:28 ` [RFC PATCH 0/3] Obey mark_page_accessed hint given by filesystems Will Huck
2013-05-01 6:28 ` Will Huck
2013-05-01 8:08 ` Mel Gorman
2013-05-01 8:08 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5180CED8.9040505@gmail.com \
--to=ric.masonn@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=alexey.lyashkov@gmail.com \
--cc=anserper@ya.ru \
--cc=bernd.schubert@fastmail.fm \
--cc=dhowells@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=sam.bennn@gmail.com \
--cc=sanbai@taobao.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.