[PATCH/v2 1/3] systemd: do not recommend udev-extraconf for udev

[PATCH/v2 1/3] systemd: do not recommend udev-extraconf for udev

[Andreas Müller]

* adding this extra functionality is an image- or distro-decision
* at least automount-rule/script breaks other automount solutions causing
  misleading kernel messages as 'VFS: could not find a valid V7 on sda'

same as already sent by Koen Kooi [1]

[1] http://patches.openembedded.org/patch/48139/

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/recipes-core/systemd/systemd_199.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
index 43463c5..08cb0c6 100644
--- a/meta/recipes-core/systemd/systemd_199.bb
+++ b/meta/recipes-core/systemd/systemd_199.bb
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
 PROVIDES = "udev"
 
 PE = "1"
-PR = "r3"
+PR = "r4"
 
 DEPENDS = "kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup tcp-wrappers glib-2.0"
 DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
@@ -211,7 +211,7 @@ FILES_udev-dbg += "/lib/udev/.debug"
 
 RDEPENDS_udev += "udev-utils"
 RPROVIDES_udev = "hotplug"
-RRECOMMENDS_udev += "udev-extraconf udev-hwdb"
+RRECOMMENDS_udev += "udev-hwdb"
 
 FILES_udev += "${base_sbindir}/udevd \
                ${rootlibexecdir}/systemd/systemd-udevd \
-- 
1.7.6.5

[PATCH/v2 2/3] udev: do not recommend udev-extraconf

[Andreas Müller]

same as already sent by Koen Kooi [1]

[1] http://patches.openembedded.org/patch/48183/

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/recipes-core/udev/udev.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
index dd250f7..769d861 100644
--- a/meta/recipes-core/udev/udev.inc
+++ b/meta/recipes-core/udev/udev.inc
@@ -14,7 +14,7 @@ LDFLAGS += "-lrt"
 
 DEPENDS = "acl glib-2.0 libusb usbutils pciutils gperf-native libxslt-native util-linux"
 RPROVIDES_${PN} = "hotplug"
-RRECOMMENDS_${PN} += "udev-extraconf usbutils-ids pciutils-ids"
+RRECOMMENDS_${PN} += "usbutils-ids pciutils-ids"
 
 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \
            file://0001-Fixing-keyboard_force_release.sh-shell-script-path.patch \
-- 
1.7.6.5

[PATCH/v2 3/3] core-image-sato: add udev-extraconf

[Andreas Müller]

as discussed in [1-2]

[1] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039025.html
[2] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039027.html

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/recipes-sato/images/core-image-sato.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
index e3246d2..76abb17 100644
--- a/meta/recipes-sato/images/core-image-sato.bb
+++ b/meta/recipes-sato/images/core-image-sato.bb
@@ -8,4 +8,4 @@ LICENSE = "MIT"
 
 inherit core-image
 
-IMAGE_INSTALL += "packagegroup-core-x11-sato-games"
+IMAGE_INSTALL += "packagegroup-core-x11-sato-games udev-extraconf"
-- 
1.7.6.5

Re: [PATCH/v2 1/3] systemd: do not recommend udev-extraconf for udev

[Andreas Müller]

On Tue, Apr 30, 2013 at 2:30 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> * adding this extra functionality is an image- or distro-decision
> * at least automount-rule/script breaks other automount solutions causing
>   misleading kernel messages as 'VFS: could not find a valid V7 on sda'
>
> same as already sent by Koen Kooi [1]
>
> [1] http://patches.openembedded.org/patch/48139/
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  meta/recipes-core/systemd/systemd_199.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
> index 43463c5..08cb0c6 100644
> --- a/meta/recipes-core/systemd/systemd_199.bb
> +++ b/meta/recipes-core/systemd/systemd_199.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
>  PROVIDES = "udev"
>
>  PE = "1"
> -PR = "r3"
> +PR = "r4"
>
>  DEPENDS = "kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup tcp-wrappers glib-2.0"
>  DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
> @@ -211,7 +211,7 @@ FILES_udev-dbg += "/lib/udev/.debug"
>
>  RDEPENDS_udev += "udev-utils"
>  RPROVIDES_udev = "hotplug"
> -RRECOMMENDS_udev += "udev-extraconf udev-hwdb"
> +RRECOMMENDS_udev += "udev-hwdb"
>
>  FILES_udev += "${base_sbindir}/udevd \
>                 ${rootlibexecdir}/systemd/systemd-udevd \
> --
> 1.7.6.5
>

In case my family name causes trouble:

The following changes since commit e86538db13605953465aacc3f2fb7d719dad919e:

  neard: add systemd unit file (2013-04-29 15:31:39 +0100)

are available in the git repository at:
  git://gitorious.org/schnitzeltony-oe-meta/oe-core.git udev-extra-patches

Andreas Müller (3):
      systemd: do not recommend udev-extraconf for udev
      udev: do not recommend udev-extraconf
      core-image-sato: add udev-extraconf

 meta/recipes-core/systemd/systemd_199.bb    |    4 ++--
 meta/recipes-core/udev/udev.inc             |    2 +-
 meta/recipes-sato/images/core-image-sato.bb |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)


Andreas

Re: [PATCH/v2 3/3] core-image-sato: add udev-extraconf

[Saul Wold]

On 04/30/2013 05:30 AM, Andreas Müller wrote:
> as discussed in [1-2]
>
> [1] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039025.html
> [2] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039027.html
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>   meta/recipes-sato/images/core-image-sato.bb |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> index e3246d2..76abb17 100644
> --- a/meta/recipes-sato/images/core-image-sato.bb
> +++ b/meta/recipes-sato/images/core-image-sato.bb
> @@ -8,4 +8,4 @@ LICENSE = "MIT"
>
>   inherit core-image
>
> -IMAGE_INSTALL += "packagegroup-core-x11-sato-games"
> +IMAGE_INSTALL += "packagegroup-core-x11-sato-games udev-extraconf"
>

I believe that we should also have the udev-extraconf added to the 
core-image-lsb, I will add a follow-on patch for that.

Sau!

Re: [PATCH/v2 3/3] core-image-sato: add udev-extraconf

[Richard Purdie]

On Wed, 2013-05-01 at 12:31 -0700, Saul Wold wrote:
> On 04/30/2013 05:30 AM, Andreas Müller wrote:
> > as discussed in [1-2]
> >
> > [1] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039025.html
> > [2] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039027.html
> >
> > Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> > ---
> >   meta/recipes-sato/images/core-image-sato.bb |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> > index e3246d2..76abb17 100644
> > --- a/meta/recipes-sato/images/core-image-sato.bb
> > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > @@ -8,4 +8,4 @@ LICENSE = "MIT"
> >
> >   inherit core-image
> >
> > -IMAGE_INSTALL += "packagegroup-core-x11-sato-games"
> > +IMAGE_INSTALL += "packagegroup-core-x11-sato-games udev-extraconf"
> >
> 
> I believe that we should also have the udev-extraconf added to the 
> core-image-lsb, I will add a follow-on patch for that.

I'll take changes removing the core dependency however I think one of
the packagegroups ideally needs this addition, not such which one
though.

Cheers,

Richard

Re: [PATCH/v2 3/3] core-image-sato: add udev-extraconf

[Saul Wold]

On 05/02/2013 09:52 AM, Richard Purdie wrote:
> On Wed, 2013-05-01 at 12:31 -0700, Saul Wold wrote:
>> On 04/30/2013 05:30 AM, Andreas Müller wrote:
>>> as discussed in [1-2]
>>>
>>> [1] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039025.html
>>> [2] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/039027.html
>>>
>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>>> ---
>>>    meta/recipes-sato/images/core-image-sato.bb |    2 +-
>>>    1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
>>> index e3246d2..76abb17 100644
>>> --- a/meta/recipes-sato/images/core-image-sato.bb
>>> +++ b/meta/recipes-sato/images/core-image-sato.bb
>>> @@ -8,4 +8,4 @@ LICENSE = "MIT"
>>>
>>>    inherit core-image
>>>
>>> -IMAGE_INSTALL += "packagegroup-core-x11-sato-games"
>>> +IMAGE_INSTALL += "packagegroup-core-x11-sato-games udev-extraconf"
>>>
>>
>> I believe that we should also have the udev-extraconf added to the
>> core-image-lsb, I will add a follow-on patch for that.
>
> I'll take changes removing the core dependency however I think one of
> the packagegroups ideally needs this addition, not such which one
> though.
>

After looking at this again, I think it might be more complex, do we 
want the extraconf files unconditionally in for both sysvinit and 
systemd?  There are 2 packagegroups where it would make sense to have 
them for sysvinit based system to have similar behavior as before 
systemd:  packagegroup-core-basic (which feeds the lsb images) and 
packagegroup-core-x11-sato.  It may need to be anonymous code that 
checks for systemd as the udev provider.

Thoughts?

Sau!

> Cheers,
>
> Richard
>
>
>

Re: [PATCH/v2 3/3] core-image-sato: add udev-extraconf

[Burton, Ross]

On 2 May 2013 19:16, Saul Wold <sgw@linux.intel.com> wrote:
> After looking at this again, I think it might be more complex, do we want
> the extraconf files unconditionally in for both sysvinit and systemd?

Where we want udev-extraconf, we don't care if the init manager is
sysvinit or systemd as they both use udev (just different versions).

Ross