All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vyasevic@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	mst@redhat.com
Subject: Re: [Bridge] [PATCH v2 net-next 0/6] Allow bridge to function in non-promisc mode
Date: Thu, 02 May 2013 13:41:05 -0400	[thread overview]
Message-ID: <5182A531.2030900@redhat.com> (raw)
In-Reply-To: <20130502102331.43728912@nehalam.linuxnetplumber.net>

On 05/02/2013 01:23 PM, Stephen Hemminger wrote:
> Doing research on another problem, I noticed that this would
> break user mode spanning tree (RSTP) code.
>
> The daemon assumes that bridge is promicious mode and therefore
> will receive all link-level multicast packets.
>

Just took another look at RSTP code and I see that's its using
a packet socket with filter to catch STP frames.

Would setting IFF_ALL_MULTI solve the problem?  STP packets
are all multicast.

Thanks
-vlad


WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vyasevic@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	mst@redhat.com
Subject: Re: [PATCH v2 net-next 0/6] Allow bridge to function in non-promisc mode
Date: Thu, 02 May 2013 13:41:05 -0400	[thread overview]
Message-ID: <5182A531.2030900@redhat.com> (raw)
In-Reply-To: <20130502102331.43728912@nehalam.linuxnetplumber.net>

On 05/02/2013 01:23 PM, Stephen Hemminger wrote:
> Doing research on another problem, I noticed that this would
> break user mode spanning tree (RSTP) code.
>
> The daemon assumes that bridge is promicious mode and therefore
> will receive all link-level multicast packets.
>

Just took another look at RSTP code and I see that's its using
a packet socket with filter to catch STP frames.

Would setting IFF_ALL_MULTI solve the problem?  STP packets
are all multicast.

Thanks
-vlad

  reply	other threads:[~2013-05-02 17:41 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 20:52 [Bridge] [PATCH v2 net-next 0/6] Allow bridge to function in non-promisc mode Vlad Yasevich
2013-04-19 20:52 ` Vlad Yasevich
2013-04-19 20:52 ` [Bridge] [PATCH v2 net-next 1/6] bridge: Allow an ability to designate an uplink port Vlad Yasevich
2013-04-19 20:52   ` Vlad Yasevich
2013-04-19 20:52 ` [Bridge] [PATCH v2 net-next 2/6] bridge: make flags sysfs interface a little bit more extensible Vlad Yasevich
2013-04-19 20:52   ` Vlad Yasevich
2013-04-19 20:54   ` [Bridge] " Stephen Hemminger
2013-04-19 20:54     ` Stephen Hemminger
2013-04-19 21:35     ` [Bridge] " Vlad Yasevich
2013-04-19 21:35       ` Vlad Yasevich
2013-04-19 20:55   ` [Bridge] " Stephen Hemminger
2013-04-19 20:55     ` Stephen Hemminger
2013-04-19 21:33     ` [Bridge] " Vlad Yasevich
2013-04-19 21:33       ` Vlad Yasevich
2013-04-19 20:52 ` [Bridge] [PATCH v2 net-next 3/6] bridge: Implement IFF_UNICAST_FLT Vlad Yasevich
2013-04-19 20:52   ` Vlad Yasevich
2013-04-19 20:52 ` [Bridge] [PATCH v2 net-next 4/6] bridge: Allow user to program hw addresses to uplink devices Vlad Yasevich
2013-04-19 20:52   ` Vlad Yasevich
2013-04-19 20:52 ` [Bridge] [PATCH v2 net-next 5/6] bridge: Automatically set promisc on uplink ports Vlad Yasevich
2013-04-19 20:52   ` Vlad Yasevich
2013-04-19 20:52 ` [Bridge] [PATCH v2 net-next 6/6] bridge: Store bridge mac to uplinks Vlad Yasevich
2013-04-19 20:52   ` Vlad Yasevich
2013-04-19 20:58 ` [Bridge] [PATCH v2 net-next 0/6] Allow bridge to function in non-promisc mode Stephen Hemminger
2013-04-19 20:58   ` Stephen Hemminger
2013-04-19 21:48   ` [Bridge] " Vlad Yasevich
2013-04-19 21:48     ` Vlad Yasevich
2013-04-25 15:56 ` [Bridge] " Stephen Hemminger
2013-04-25 15:56   ` Stephen Hemminger
2013-04-25 16:45   ` [Bridge] " Michael S. Tsirkin
2013-04-25 16:45     ` Michael S. Tsirkin
2013-04-25 17:35     ` [Bridge] " Stephen Hemminger
2013-04-25 17:35       ` Stephen Hemminger
2013-04-25 21:13       ` [Bridge] " Michael S. Tsirkin
2013-04-25 21:13         ` Michael S. Tsirkin
2013-05-02 17:23 ` [Bridge] " Stephen Hemminger
2013-05-02 17:23   ` Stephen Hemminger
2013-05-02 17:41   ` Vlad Yasevich [this message]
2013-05-02 17:41     ` Vlad Yasevich
2013-05-02 18:14     ` [Bridge] " Stephen Hemminger
2013-05-02 18:14       ` Stephen Hemminger
2013-05-02 18:37   ` [Bridge] " Michael S. Tsirkin
2013-05-02 18:37     ` Michael S. Tsirkin
2013-05-02 21:16     ` [Bridge] " Stephen Hemminger
2013-05-02 21:16       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5182A531.2030900@redhat.com \
    --to=vyasevic@redhat.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.