* [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata()
@ 2013-05-03 6:56 Sachin Kamat
2013-05-03 7:13 ` Hans-Christian Egtvedt
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-05-03 6:56 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, sachin.kamat, nicolas.ferre, egtvedt
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/atmel/abdac.c | 2 --
sound/atmel/ac97c.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
index 071ce1b..872d59e 100644
--- a/sound/atmel/abdac.c
+++ b/sound/atmel/abdac.c
@@ -583,8 +583,6 @@ static int atmel_abdac_remove(struct platform_device *pdev)
free_irq(dac->irq, dac);
snd_card_free(card);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 6b7e2b5..ae63d22 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -1199,8 +1199,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev)
snd_card_set_dev(card, NULL);
snd_card_free(card);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata()
2013-05-03 6:56 [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata() Sachin Kamat
@ 2013-05-03 7:13 ` Hans-Christian Egtvedt
2013-05-03 7:16 ` Nicolas Ferre
2013-05-03 9:49 ` Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Hans-Christian Egtvedt @ 2013-05-03 7:13 UTC (permalink / raw)
To: Sachin Kamat; +Cc: tiwai, alsa-devel, nicolas.ferre
Around Fri 03 May 2013 12:26:28 +0530 or thereabout, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Thanks
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> sound/atmel/abdac.c | 2 --
> sound/atmel/ac97c.c | 2 --
> 2 files changed, 4 deletions(-)
<snipp diff>
--
HcE
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata()
2013-05-03 6:56 [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 7:13 ` Hans-Christian Egtvedt
@ 2013-05-03 7:16 ` Nicolas Ferre
2013-05-03 9:49 ` Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2013-05-03 7:16 UTC (permalink / raw)
To: Sachin Kamat; +Cc: tiwai, alsa-devel, egtvedt
On 03/05/2013 08:56, Sachin Kamat :
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
yes, as it is not needed anymore it may make sense to remove these calls...
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> sound/atmel/abdac.c | 2 --
> sound/atmel/ac97c.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
> index 071ce1b..872d59e 100644
> --- a/sound/atmel/abdac.c
> +++ b/sound/atmel/abdac.c
> @@ -583,8 +583,6 @@ static int atmel_abdac_remove(struct platform_device *pdev)
> free_irq(dac->irq, dac);
> snd_card_free(card);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 6b7e2b5..ae63d22 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -1199,8 +1199,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev)
> snd_card_set_dev(card, NULL);
> snd_card_free(card);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata()
2013-05-03 6:56 [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 7:13 ` Hans-Christian Egtvedt
2013-05-03 7:16 ` Nicolas Ferre
@ 2013-05-03 9:49 ` Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2013-05-03 9:49 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel, nicolas.ferre, egtvedt
At Fri, 3 May 2013 12:26:28 +0530,
Sachin Kamat wrote:
>
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Thanks, applied now with acks by Hans-Christian and Nicolas.
Takashi
> ---
> sound/atmel/abdac.c | 2 --
> sound/atmel/ac97c.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
> index 071ce1b..872d59e 100644
> --- a/sound/atmel/abdac.c
> +++ b/sound/atmel/abdac.c
> @@ -583,8 +583,6 @@ static int atmel_abdac_remove(struct platform_device *pdev)
> free_irq(dac->irq, dac);
> snd_card_free(card);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 6b7e2b5..ae63d22 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -1199,8 +1199,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev)
> snd_card_set_dev(card, NULL);
> snd_card_free(card);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-03 9:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 6:56 [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 7:13 ` Hans-Christian Egtvedt
2013-05-03 7:16 ` Nicolas Ferre
2013-05-03 9:49 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.