[PATCH] ARM: sun4i: cubieboard: Enable the i2c controllers

[PATCH] ARM: sun4i: cubieboard: Enable the i2c controllers

[Emilio López]

The Cubieboard makes use of the first two i2c controllers found on the
Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
is exposed on the board headers. This patch enables them in the device
tree.

Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
---
 arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
index b70fe0d..0e22a28 100644
--- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
+++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
@@ -41,6 +41,18 @@
 			pinctrl-0 = <&uart0_pins_a>;
 			status = "okay";
 		};
+
+		i2c0: i2c at 01c2ac00 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c0_pins_a>;
+			status = "okay";
+		};
+
+		i2c1: i2c at 01c2b000 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c1_pins_a>;
+			status = "okay";
+		};
 	};
 
 	leds {
-- 
1.8.2.2

[PATCH] ARM: sun4i: cubieboard: Enable the i2c controllers

[Arnd Bergmann]

On Thursday 02 May 2013 09:37:46 Emilio L?pez wrote:
> The Cubieboard makes use of the first two i2c controllers found on the
> Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
> is exposed on the board headers. This patch enables them in the device
> tree.
> 
> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>

Shouldn't you list the attached devices in the same patch?

What is the point of enabling the I2C bus if there are no devices
to be found?

	Arnd

[PATCH] ARM: sun4i: cubieboard: Enable the i2c controllers

[Emilio López]

Hi Arnd,

El 02/05/13 10:43, Arnd Bergmann escribi?:
> On Thursday 02 May 2013 09:37:46 Emilio L?pez wrote:
>> The Cubieboard makes use of the first two i2c controllers found on the
>> Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
>> is exposed on the board headers. This patch enables them in the device
>> tree.
>>
>> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
> 
> Shouldn't you list the attached devices in the same patch?
> 
> What is the point of enabling the I2C bus if there are no devices
> to be found?

This is complementary to the series titled "Add I2C support for
Allwinner SoCs" sent by Maxime today. We have no driver for the AXP20
PMIC yet, and the external header is left for the user to connect, so I
haven't added any device. This is still useful though, as it lets you
use I2C from userspace (i2cdetect, i2cdump, etc).

Regards,

Emilio

[PATCH] ARM: sun4i: cubieboard: Enable the i2c controllers

[Arnd Bergmann]

On Thursday 02 May 2013, Emilio L?pez wrote:
> This is complementary to the series titled "Add I2C support for
> Allwinner SoCs" sent by Maxime today. We have no driver for the AXP20
> PMIC yet, and the external header is left for the user to connect, so I
> haven't added any device. This is still useful though, as it lets you
> use I2C from userspace (i2cdetect, i2cdump, etc).

Right, that makes sense. Thanks,

	Arnd

[PATCH] ARM: sun4i: cubieboard: Enable the i2c controllers

[Maxime Ripard]

Hi Emilio,

Le 02/05/2013 14:37, Emilio L?pez a ?crit :
> The Cubieboard makes use of the first two i2c controllers found on the
> Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
> is exposed on the board headers. This patch enables them in the device
> tree.
> 
> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>

Thanks for this patch.

I'll merge it in my i2c patchset, so that every thing stays together.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com