From: Sasha Levin <sasha.levin@oracle.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Will Deacon <will.deacon@arm.com>, Asias He <asias@redhat.com>,
KVM General <kvm@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
anup@brainfault.org, Rusty Russell <rusty@rustcorp.com.au>,
pranavkumar@linaro.org, Michael Ellerman <michael@ellerman.id.au>
Subject: Re: [RFC PATCH 04/11] kvm tools: console: unconditionally output to any console
Date: Fri, 03 May 2013 12:02:14 -0400 [thread overview]
Message-ID: <5183DF86.3040507@oracle.com> (raw)
In-Reply-To: <CAOJsxLGcZys-WYLg=rBON5iaaiHP6g_w-X3GXfpZz-R5BZtjJA@mail.gmail.com>
On 05/03/2013 05:19 AM, Pekka Enberg wrote:
> On Wed, May 1, 2013 at 6:50 PM, Will Deacon <will.deacon@arm.com> wrote:
>> From: Marc Zyngier <Marc.Zyngier@arm.com>
>>
>> Kvmtool suppresses any output to a console that has not been elected
>> as *the* console.
>>
>> While this makes sense on the input side (we want the input to be sent
>> to one console driver only), it seems to be the wrong thing to do on
>> the output side, as it effectively prevents the guest from switching
>> from one console to another (think earlyprintk using 8250 to virtio
>> console).
>>
>> After all, the guest *does* poke this device and outputs something
>> there.
>>
>> Just remove the kvm->cfg.active_console test from the output paths.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Seems reasonable. Asias, Sasha?
>
I remember at trying it some time ago but dropped it for a reason I don't
remember at the moment.
Can I have the weekend to play with it to try and figure out why?
Thanks,
Sasha
next prev parent reply other threads:[~2013-05-03 16:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 15:50 [RFC PATCH 00/11] kvm tools: allow ioport emulation to be used on ARM Will Deacon
2013-05-01 15:50 ` [RFC PATCH 01/11] kvm tools: makefile: factor out libfdt inclusion Will Deacon
2013-05-01 15:50 ` [RFC PATCH 02/11] kvm tools: virtio: move fdt node generation into core mmio code Will Deacon
2013-05-01 15:50 ` [RFC PATCH 03/11] kvm tools: arm: add ioport window to virtual memory map Will Deacon
2013-05-01 15:50 ` [RFC PATCH 04/11] kvm tools: console: unconditionally output to any console Will Deacon
2013-05-03 9:19 ` Pekka Enberg
2013-05-03 16:02 ` Sasha Levin [this message]
2013-05-03 16:09 ` Will Deacon
2013-05-06 21:04 ` Sasha Levin
2013-05-07 2:48 ` Anup Patel
2013-05-05 10:16 ` Asias He
2013-05-01 15:50 ` [RFC PATCH 05/11] kvm tools: allow ioports to be offset from 0 Will Deacon
2013-05-01 15:50 ` [RFC PATCH 06/11] kvm tools: ioport: add arch callback to remap IRQ lines for ioport devices Will Deacon
2013-05-01 15:50 ` [RFC PATCH 07/11] kvm tools: ioport: allow ioport devices to generate fdt nodes Will Deacon
2013-05-01 15:50 ` [RFC PATCH 08/11] kvm tools: 8250: add fdt node generation Will Deacon
2013-05-01 15:50 ` [RFC PATCH 09/11] kvm tools: 8250: add address qualifier to uart name in fdt node Will Deacon
2013-05-01 15:50 ` [RFC PATCH 10/11] kvm tools: ARM: generate fdt nodes for ioport devices Will Deacon
2013-05-01 15:50 ` [RFC PATCH 11/11] kvm tools: ARM: add 8250 console callback to periodic poll Will Deacon
2013-05-03 6:53 ` [RFC PATCH 00/11] kvm tools: allow ioport emulation to be used on ARM Michael Ellerman
2013-05-14 15:29 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5183DF86.3040507@oracle.com \
--to=sasha.levin@oracle.com \
--cc=anup@brainfault.org \
--cc=asias@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=michael@ellerman.id.au \
--cc=penberg@kernel.org \
--cc=pranavkumar@linaro.org \
--cc=rusty@rustcorp.com.au \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.