All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 311: test fsync with dm flakey V3
Date: Fri, 3 May 2013 13:01:11 -0500	[thread overview]
Message-ID: <5183FB67.8000202@sgi.com> (raw)
In-Reply-To: <20130503173001.GC12414@localhost.localdomain>

On 05/03/2013 12:30 PM, Josef Bacik wrote:
> On Fri, May 03, 2013 at 06:28:03AM -0600, Rich Johnston wrote:
>> Josef,
>>
>> The patch does not compile on older kernels (i.e. SLES11 SP2).
>>
>> fsync-tester.c: In function 'test_three':
>> fsync-tester.c:133: warning: implicit declaration of function 'syncfs'
>> /tmp/cciHR6Gb.o: In function `test_three':
>> /data/lwork/gulag1c/rjohnston/xfstests/src/fsync-tester.c:133: undefined
>> reference to `syncfs'
>> collect2: ld returned 1 exit status
>> gmake[3]: *** [fsync-tester] Error 1
>> gmake[2]: *** [src] Error 2
>> make[1]: *** [default] Error 2
>> make: *** [default] Error 2
>>
>>
>> src/fsync-tester.c
>> 133                                 syncfs(test_fd);
>> Typo ?????                          ^^^^^^
>> Did you mean fsync?
>>
>
> Argh crap I should have noticed this in the manpage
>
> syncfs() first appeared in Linux 2.6.39
>
> You can just replace it with sync(), or do you want me to resend the patch with
> that change?  Thanks,
>
> Josef
>
No need to repost I will change it to sync() at commit time ;-)

--Rich

WARNING: multiple messages have this Message-ID (diff)
From: Rich Johnston <rjohnston@sgi.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 311: test fsync with dm flakey V3
Date: Fri, 3 May 2013 13:01:11 -0500	[thread overview]
Message-ID: <5183FB67.8000202@sgi.com> (raw)
In-Reply-To: <20130503173001.GC12414@localhost.localdomain>

On 05/03/2013 12:30 PM, Josef Bacik wrote:
> On Fri, May 03, 2013 at 06:28:03AM -0600, Rich Johnston wrote:
>> Josef,
>>
>> The patch does not compile on older kernels (i.e. SLES11 SP2).
>>
>> fsync-tester.c: In function 'test_three':
>> fsync-tester.c:133: warning: implicit declaration of function 'syncfs'
>> /tmp/cciHR6Gb.o: In function `test_three':
>> /data/lwork/gulag1c/rjohnston/xfstests/src/fsync-tester.c:133: undefined
>> reference to `syncfs'
>> collect2: ld returned 1 exit status
>> gmake[3]: *** [fsync-tester] Error 1
>> gmake[2]: *** [src] Error 2
>> make[1]: *** [default] Error 2
>> make: *** [default] Error 2
>>
>>
>> src/fsync-tester.c
>> 133                                 syncfs(test_fd);
>> Typo ?????                          ^^^^^^
>> Did you mean fsync?
>>
>
> Argh crap I should have noticed this in the manpage
>
> syncfs() first appeared in Linux 2.6.39
>
> You can just replace it with sync(), or do you want me to resend the patch with
> that change?  Thanks,
>
> Josef
>
No need to repost I will change it to sync() at commit time ;-)

--Rich

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-05-03 18:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 19:13 [PATCH] xfstests 311: test fsync with dm flakey V3 Josef Bacik
2013-04-26 19:13 ` Josef Bacik
2013-04-30  7:38 ` Dave Chinner
2013-04-30  7:38   ` Dave Chinner
2013-05-03 12:28 ` Rich Johnston
2013-05-03 12:28   ` Rich Johnston
2013-05-03 17:30   ` Josef Bacik
2013-05-03 17:30     ` Josef Bacik
2013-05-03 18:01     ` Rich Johnston [this message]
2013-05-03 18:01       ` Rich Johnston
2013-05-03 18:21 ` Rich Johnston
2013-05-03 18:21   ` Rich Johnston
2013-05-03 19:05   ` Josef Bacik
2013-05-03 19:05     ` Josef Bacik
2013-05-03 19:26     ` Rich Johnston
2013-05-03 19:26       ` Rich Johnston
2013-05-06  0:19       ` Dave Chinner
2013-05-06  0:19         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5183FB67.8000202@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.