From: Libo Chen <clbchenlibo.chen@huawei.com>
To: wsa@the-dreams.de
Cc: uclinux-dist-devel@blackfin.uclinux.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Li Zefan <lizefan@huawei.com>
Subject: [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful
Date: Mon, 6 May 2013 21:11:18 +0800 [thread overview]
Message-ID: <5187ABF6.4000907@huawei.com> (raw)
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/i2c/busses/i2c-bfin-twi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index 05080c4..d38e05a 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
@@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
out_error_add_adapter:
free_irq(iface->irq, iface);
out_error_req_irq:
-out_error_no_irq:
peripheral_free_list((unsigned short *)pdev->dev.platform_data);
+out_error_no_irq:
out_error_pin_mux:
iounmap(iface->regs_base);
out_error_ioremap:
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Libo Chen <clbchenlibo.chen@huawei.com>
To: <wsa@the-dreams.de>
Cc: <uclinux-dist-devel@blackfin.uclinux.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>
Subject: [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful
Date: Mon, 6 May 2013 21:11:18 +0800 [thread overview]
Message-ID: <5187ABF6.4000907@huawei.com> (raw)
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/i2c/busses/i2c-bfin-twi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index 05080c4..d38e05a 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
@@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
out_error_add_adapter:
free_irq(iface->irq, iface);
out_error_req_irq:
-out_error_no_irq:
peripheral_free_list((unsigned short *)pdev->dev.platform_data);
+out_error_no_irq:
out_error_pin_mux:
iounmap(iface->regs_base);
out_error_ioremap:
--
1.7.1
next reply other threads:[~2013-05-06 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 13:11 Libo Chen [this message]
2013-05-06 13:11 ` [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful Libo Chen
[not found] ` <5187ABF6.4000907-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-09 5:07 ` Zhang, Sonic
2013-05-09 5:07 ` [uclinux-dist-devel] " Zhang, Sonic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5187ABF6.4000907@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.