All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Samuel Holland <samuel@sholland.org>, Lee Jones <lee@kernel.org>,
	Pavel Machek <pavel@kernel.org>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH 1/4] dt-bindings: leds: Document "gpio" trigger
Date: Wed, 15 Jul 2026 21:39:43 +0200	[thread overview]
Message-ID: <5188715.0VBMTVartN@phil> (raw)
In-Reply-To: <20260711192842.845048-2-samuel@sholland.org>

Hi Samuel,

Am Samstag, 11. Juli 2026, 21:28:25 Mitteleuropäische Sommerzeit schrieb Samuel Holland:
> The "gpio" trigger is used to control LEDs by the level of a GPIO input
> referenced by the trigger-sources property. This is already documented
> in the trigger-sources property description and is used in at least one
> devicetree (am335x-regor.dtsi). Document it so validation of those and
> future DTs will pass.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

having Lee only in Cc in a longer patch series might make it difficult
to notice this change.

I guess this patch needs to be applied or at least "Acked-by" by them.


Heiko

> ---
> 
>  Documentation/devicetree/bindings/leds/common.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f4e44b33f56d..e148b4277a6f 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -106,6 +106,8 @@ properties:
>            - bluetooth-power
>              # LED indicates camera flash state
>            - flash
> +            # LED indicates level of GPIO input referenced by trigger-sources
> +          - gpio
>              # LED indicated keyboard capslock
>            - kbd-capslock
>              # LED indicates MTD memory activity
> 





WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Samuel Holland <samuel@sholland.org>, Lee Jones <lee@kernel.org>,
	Pavel Machek <pavel@kernel.org>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH 1/4] dt-bindings: leds: Document "gpio" trigger
Date: Wed, 15 Jul 2026 21:39:43 +0200	[thread overview]
Message-ID: <5188715.0VBMTVartN@phil> (raw)
In-Reply-To: <20260711192842.845048-2-samuel@sholland.org>

Hi Samuel,

Am Samstag, 11. Juli 2026, 21:28:25 Mitteleuropäische Sommerzeit schrieb Samuel Holland:
> The "gpio" trigger is used to control LEDs by the level of a GPIO input
> referenced by the trigger-sources property. This is already documented
> in the trigger-sources property description and is used in at least one
> devicetree (am335x-regor.dtsi). Document it so validation of those and
> future DTs will pass.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

having Lee only in Cc in a longer patch series might make it difficult
to notice this change.

I guess this patch needs to be applied or at least "Acked-by" by them.


Heiko

> ---
> 
>  Documentation/devicetree/bindings/leds/common.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f4e44b33f56d..e148b4277a6f 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -106,6 +106,8 @@ properties:
>            - bluetooth-power
>              # LED indicates camera flash state
>            - flash
> +            # LED indicates level of GPIO input referenced by trigger-sources
> +          - gpio
>              # LED indicated keyboard capslock
>            - kbd-capslock
>              # LED indicates MTD memory activity
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2026-07-15 19:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-11 19:28 [PATCH 0/4] Add devicetree for LincPlus LincStation E1 Samuel Holland
2026-07-11 19:28 ` Samuel Holland
2026-07-11 19:28 ` [PATCH 1/4] dt-bindings: leds: Document "gpio" trigger Samuel Holland
2026-07-11 19:28   ` Samuel Holland
2026-07-11 19:32   ` sashiko-bot
2026-07-13 16:20   ` Conor Dooley
2026-07-13 16:20     ` Conor Dooley
2026-07-15 19:39   ` Heiko Stuebner [this message]
2026-07-15 19:39     ` Heiko Stuebner
2026-07-11 19:28 ` [PATCH 2/4] dt-bindings: vendor-prefixes: Add techvision Samuel Holland
2026-07-11 19:28   ` Samuel Holland
2026-07-11 19:29   ` sashiko-bot
2026-07-13 16:20   ` Conor Dooley
2026-07-13 16:20     ` Conor Dooley
2026-07-11 19:28 ` [PATCH 3/4] dt-bindings: arm: rockchip: Add LincStation E1 Samuel Holland
2026-07-11 19:28   ` Samuel Holland
2026-07-11 19:30   ` sashiko-bot
2026-07-13 16:22   ` Conor Dooley
2026-07-13 16:22     ` Conor Dooley
2026-07-11 19:28 ` [PATCH 4/4] arm64: dts: " Samuel Holland
2026-07-11 19:28   ` Samuel Holland
2026-07-11 19:35   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5188715.0VBMTVartN@phil \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.