All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Prisk <linux@prisktech.co.nz>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
	'Jiri Slaby' <jslaby@suse.cz>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH 14/15] serial: vt8500: remove unnecessary platform_set_drvdata()
Date: Tue, 07 May 2013 20:17:18 +1200	[thread overview]
Message-ID: <5188B88E.9050700@prisktech.co.nz> (raw)
In-Reply-To: <009301ce4af9$eecae6f0$cc60b4d0$@samsung.com>

On 07/05/13 20:07, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>   drivers/tty/serial/vt8500_serial.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
> index 1a8bc22..053de1b 100644
> --- a/drivers/tty/serial/vt8500_serial.c
> +++ b/drivers/tty/serial/vt8500_serial.c
> @@ -630,7 +630,6 @@ static int vt8500_serial_remove(struct platform_device *pdev)
>   {
>   	struct vt8500_port *vt8500_port = platform_get_drvdata(pdev);
>   
> -	platform_set_drvdata(pdev, NULL);
>   	clk_disable_unprepare(vt8500_port->clk);
>   	uart_remove_one_port(&vt8500_uart_driver, &vt8500_port->uart);
>   
Acked-by: Tony Prisk <linux@prisktech.co.nz>

      reply	other threads:[~2013-05-07  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07  8:07 [PATCH 14/15] serial: vt8500: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07  8:17 ` Tony Prisk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5188B88E.9050700@prisktech.co.nz \
    --to=linux@prisktech.co.nz \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=jslaby@suse.cz \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.