* [PATCH 14/15] serial: vt8500: remove unnecessary platform_set_drvdata()
@ 2013-05-07 8:07 Jingoo Han
2013-05-07 8:17 ` Tony Prisk
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 8:07 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Jiri Slaby', linux-serial, Jingoo Han, Tony Prisk
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/tty/serial/vt8500_serial.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
index 1a8bc22..053de1b 100644
--- a/drivers/tty/serial/vt8500_serial.c
+++ b/drivers/tty/serial/vt8500_serial.c
@@ -630,7 +630,6 @@ static int vt8500_serial_remove(struct platform_device *pdev)
{
struct vt8500_port *vt8500_port = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
clk_disable_unprepare(vt8500_port->clk);
uart_remove_one_port(&vt8500_uart_driver, &vt8500_port->uart);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 14/15] serial: vt8500: remove unnecessary platform_set_drvdata()
2013-05-07 8:07 [PATCH 14/15] serial: vt8500: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 8:17 ` Tony Prisk
0 siblings, 0 replies; 2+ messages in thread
From: Tony Prisk @ 2013-05-07 8:17 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Greg Kroah-Hartman', 'Jiri Slaby', linux-serial
On 07/05/13 20:07, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/tty/serial/vt8500_serial.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
> index 1a8bc22..053de1b 100644
> --- a/drivers/tty/serial/vt8500_serial.c
> +++ b/drivers/tty/serial/vt8500_serial.c
> @@ -630,7 +630,6 @@ static int vt8500_serial_remove(struct platform_device *pdev)
> {
> struct vt8500_port *vt8500_port = platform_get_drvdata(pdev);
>
> - platform_set_drvdata(pdev, NULL);
> clk_disable_unprepare(vt8500_port->clk);
> uart_remove_one_port(&vt8500_uart_driver, &vt8500_port->uart);
>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 8:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 8:07 [PATCH 14/15] serial: vt8500: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 8:17 ` Tony Prisk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.