* Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd
@ 2013-05-06 16:26 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2013-05-06 16:26 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, qemu-devel
Il 06/05/2013 18:07, Jan Kiszka ha scritto:
> Improves readability.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> translate-all.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index da93608..0d84b0d 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
> section = phys_page_find(address_space_memory.dispatch,
> addr >> TARGET_PAGE_BITS);
> if (!(memory_region_is_ram(section->mr)
> - || (section->mr->rom_device && section->mr->readable))) {
> + || memory_region_is_romd(section->mr))) {
> return;
> }
> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>
Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
Any volunteers for co-maintaining it? :)
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd
2013-05-06 16:26 ` [Qemu-devel] " Paolo Bonzini
@ 2013-05-06 16:42 ` Peter Maydell
-1 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2013-05-06 16:42 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Jan Kiszka, qemu-devel
On 6 May 2013 17:26, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>> Improves readability.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> translate-all.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..0d84b0d 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>> section = phys_page_find(address_space_memory.dispatch,
>> addr >> TARGET_PAGE_BITS);
>> if (!(memory_region_is_ram(section->mr)
>> - || (section->mr->rom_device && section->mr->readable))) {
>> + || memory_region_is_romd(section->mr))) {
>> return;
>> }
>> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>
>
> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
Well, I wouldn't necessarily put it in 1.5 this close to
hardfreeze, but it looks fine for qemu-trivial to me.
In particular you can comprehend the patch and confirm its
correctness without having to have any larger understanding
of the memory system.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd
@ 2013-05-06 16:42 ` Peter Maydell
0 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2013-05-06 16:42 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Jan Kiszka, qemu-devel
On 6 May 2013 17:26, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>> Improves readability.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> translate-all.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..0d84b0d 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>> section = phys_page_find(address_space_memory.dispatch,
>> addr >> TARGET_PAGE_BITS);
>> if (!(memory_region_is_ram(section->mr)
>> - || (section->mr->rom_device && section->mr->readable))) {
>> + || memory_region_is_romd(section->mr))) {
>> return;
>> }
>> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>
>
> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
Well, I wouldn't necessarily put it in 1.5 this close to
hardfreeze, but it looks fine for qemu-trivial to me.
In particular you can comprehend the patch and confirm its
correctness without having to have any larger understanding
of the memory system.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] memory: Replace open-coded memory_region_is_romd
2013-05-06 16:26 ` [Qemu-devel] " Paolo Bonzini
@ 2013-05-07 14:17 ` Jan Kiszka
-1 siblings, 0 replies; 10+ messages in thread
From: Jan Kiszka @ 2013-05-07 14:17 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
On 2013-05-06 18:26, Paolo Bonzini wrote:
> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>> Improves readability.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> translate-all.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..0d84b0d 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>> section = phys_page_find(address_space_memory.dispatch,
>> addr >> TARGET_PAGE_BITS);
>> if (!(memory_region_is_ram(section->mr)
>> - || (section->mr->rom_device && section->mr->readable))) {
>> + || memory_region_is_romd(section->mr))) {
>> return;
>> }
>> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>
>
> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
Great, thanks.
>
> Any volunteers for co-maintaining it? :)
Raising my hand, but not without remarking that I have some bandwidth
issue ATM. But I will try my best.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd
@ 2013-05-07 14:17 ` Jan Kiszka
0 siblings, 0 replies; 10+ messages in thread
From: Jan Kiszka @ 2013-05-07 14:17 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
On 2013-05-06 18:26, Paolo Bonzini wrote:
> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>> Improves readability.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> translate-all.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..0d84b0d 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>> section = phys_page_find(address_space_memory.dispatch,
>> addr >> TARGET_PAGE_BITS);
>> if (!(memory_region_is_ram(section->mr)
>> - || (section->mr->rom_device && section->mr->readable))) {
>> + || memory_region_is_romd(section->mr))) {
>> return;
>> }
>> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>
>
> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
Great, thanks.
>
> Any volunteers for co-maintaining it? :)
Raising my hand, but not without remarking that I have some bandwidth
issue ATM. But I will try my best.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [PATCH] memory: Replace open-coded memory_region_is_romd
2013-05-07 14:17 ` [Qemu-devel] " Jan Kiszka
@ 2013-05-07 14:35 ` Paolo Bonzini
-1 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2013-05-07 14:35 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, qemu-devel
Il 07/05/2013 16:17, Jan Kiszka ha scritto:
> On 2013-05-06 18:26, Paolo Bonzini wrote:
>> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>>> Improves readability.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> translate-all.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/translate-all.c b/translate-all.c
>>> index da93608..0d84b0d 100644
>>> --- a/translate-all.c
>>> +++ b/translate-all.c
>>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>>> section = phys_page_find(address_space_memory.dispatch,
>>> addr >> TARGET_PAGE_BITS);
>>> if (!(memory_region_is_ram(section->mr)
>>> - || (section->mr->rom_device && section->mr->readable))) {
>>> + || memory_region_is_romd(section->mr))) {
>>> return;
>>> }
>>> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>>
>>
>> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
>
> Great, thanks.
>
>>
>> Any volunteers for co-maintaining it? :)
>
> Raising my hand, but not without remarking that I have some bandwidth
> issue ATM. But I will try my best.
Ok, the model we've been using for migration is that there is a pool of
people that send pull requests without being official maintainers---the
contract with Anthony is simply that patches are well reviewed.
For now I've repurposed my iommu branch as the WIP 1.6 memory branch;
It can still be rebased, but the changes should be small at this point.
I will pass the ball after sending the first 1.6 pull request.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd
@ 2013-05-07 14:35 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2013-05-07 14:35 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-trivial, qemu-devel
Il 07/05/2013 16:17, Jan Kiszka ha scritto:
> On 2013-05-06 18:26, Paolo Bonzini wrote:
>> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>>> Improves readability.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> translate-all.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/translate-all.c b/translate-all.c
>>> index da93608..0d84b0d 100644
>>> --- a/translate-all.c
>>> +++ b/translate-all.c
>>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>>> section = phys_page_find(address_space_memory.dispatch,
>>> addr >> TARGET_PAGE_BITS);
>>> if (!(memory_region_is_ram(section->mr)
>>> - || (section->mr->rom_device && section->mr->readable))) {
>>> + || memory_region_is_romd(section->mr))) {
>>> return;
>>> }
>>> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>>
>>
>> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
>
> Great, thanks.
>
>>
>> Any volunteers for co-maintaining it? :)
>
> Raising my hand, but not without remarking that I have some bandwidth
> issue ATM. But I will try my best.
Ok, the model we've been using for migration is that there is a pool of
people that send pull requests without being official maintainers---the
contract with Anthony is simply that patches are well reviewed.
For now I've repurposed my iommu branch as the WIP 1.6 memory branch;
It can still be rebased, but the changes should be small at this point.
I will pass the ball after sending the first 1.6 pull request.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread