* [PATCH] x86, boot: Cleanup A20 Code
@ 2013-05-07 15:58 Syed Salman Mansoor
2013-05-07 16:00 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Syed Salman Mansoor @ 2013-05-07 15:58 UTC (permalink / raw)
To: hpa, tglx, mingo; +Cc: x86, linux-kernel, Syed Salman Mansoor
Fix checkpatch.pl warnings in a20.c
i) WARNING: please, no spaces at the start of a line
ii) WARNING: suspect code indent for conditional statements
iii) ERROR: trailing whitespace
Signed-off-by: Syed Salman Mansoor <syed.salman.mansoor@gmail.com>
---
arch/x86/boot/a20.c | 48 ++++++++++++++++++++++++------------------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
index 64a31a6..4565f4d 100644
--- a/arch/x86/boot/a20.c
+++ b/arch/x86/boot/a20.c
@@ -129,37 +129,37 @@ static void enable_a20_fast(void)
int enable_a20(void)
{
- int loops = A20_ENABLE_LOOPS;
- int kbc_err;
+ int loops = A20_ENABLE_LOOPS;
+ int kbc_err;
- while (loops--) {
- /* First, check to see if A20 is already enabled
+ while (loops--) {
+ /* First, check to see if A20 is already enabled
(legacy free, etc.) */
- if (a20_test_short())
- return 0;
-
+ if (a20_test_short())
+ return 0;
+
/* Next, try the BIOS (INT 0x15, AX=0x2401) */
enable_a20_bios();
- if (a20_test_short())
- return 0;
-
+ if (a20_test_short())
+ return 0;
+
/* Try enabling A20 through the keyboard controller */
kbc_err = empty_8042();
- if (a20_test_short())
- return 0; /* BIOS worked, but with delayed reaction */
-
- if (!kbc_err) {
- enable_a20_kbc();
- if (a20_test_long())
- return 0;
+ if (a20_test_short())
+ return 0; /* BIOS worked, but with delayed reaction */
+
+ if (!kbc_err) {
+ enable_a20_kbc();
+ if (a20_test_long())
+ return 0;
}
-
+
/* Finally, try enabling the "fast A20 gate" */
- enable_a20_fast();
- if (a20_test_long())
- return 0;
- }
-
- return -1;
+ enable_a20_fast();
+ if (a20_test_long())
+ return 0;
+ }
+
+ return -1;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] x86, boot: Cleanup A20 Code
2013-05-07 15:58 [PATCH] x86, boot: Cleanup A20 Code Syed Salman Mansoor
@ 2013-05-07 16:00 ` H. Peter Anvin
2013-05-07 16:05 ` Syed Salman Mansoor
0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin @ 2013-05-07 16:00 UTC (permalink / raw)
To: Syed Salman Mansoor; +Cc: tglx, mingo, x86, linux-kernel
On 05/07/2013 08:58 AM, Syed Salman Mansoor wrote:
> Fix checkpatch.pl warnings in a20.c
> i) WARNING: please, no spaces at the start of a line
> ii) WARNING: suspect code indent for conditional statements
> iii) ERROR: trailing whitespace
This patch doesn't actually change anything meaningful. Sorry,
"whitespace massaging" patches are generally considered pure nuisance.
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86, boot: Cleanup A20 Code
2013-05-07 16:00 ` H. Peter Anvin
@ 2013-05-07 16:05 ` Syed Salman Mansoor
0 siblings, 0 replies; 3+ messages in thread
From: Syed Salman Mansoor @ 2013-05-07 16:05 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: tglx, mingo, x86, linux-kernel
Ok. Thanks but actually I wanted to get idea how to create kernel
patch and how to use GIT. So now will try to focus on actual fix.
Anyways sorry for any inconvenience occured due to whitespace
messaging patch.
Thanks a lot again.
On Tue, May 7, 2013 at 9:00 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 05/07/2013 08:58 AM, Syed Salman Mansoor wrote:
>> Fix checkpatch.pl warnings in a20.c
>> i) WARNING: please, no spaces at the start of a line
>> ii) WARNING: suspect code indent for conditional statements
>> iii) ERROR: trailing whitespace
>
> This patch doesn't actually change anything meaningful. Sorry,
> "whitespace massaging" patches are generally considered pure nuisance.
>
> -hpa
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-07 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 15:58 [PATCH] x86, boot: Cleanup A20 Code Syed Salman Mansoor
2013-05-07 16:00 ` H. Peter Anvin
2013-05-07 16:05 ` Syed Salman Mansoor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.