Re: [Xen-users] Xen 4.3 RC1 Test Day on freenode channel #xentest is today

[George Dunlap <george.dunlap@eu.citrix.com>]

On 08/05/13 13:15, Ian Campbell wrote:
> On Wed, 2013-05-08 at 13:07 +0100, Dietmar Hahn wrote:
>> Am Mittwoch 08 Mai 2013, 10:10:37 schrieb Ian Campbell:
>>> On Wed, 2013-05-08 at 09:30 +0100, Dietmar Hahn wrote:
>>>> Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
>>>>> Hi everybody,
>>>>>
>>>>> we have the first test day for Xen 4.3 today.
>>>>>
>>>>> For more information on Test Days and how to join see
>>>>> http://wiki.xen.org/wiki/Xen_Test_Days
>>>>> For test instructions see
>>>>> http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions
>>>> I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
>>>> As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
>>>> I did:
>>>>
>>>> # git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
>>>> # cd xen
>>>> # ./configure --libdir=/usr/lib64
>>>> # make dist
>>>>
>>>> The compiling breaks in building seabios and at the moment I have no glue
>>>> where to look.
>>> All lists apart from xen-devel to bcc, adding release manager.
>>>
>>> Looks like a conflict with your version of iasl, which are you using?
>> # iasl -v
>>
>> Intel ACPI Component Architecture
>> ASL Optimizing Compiler version 20121220-64
>> Copyright (c) 2000 - 2012 Intel Corporation
>>
>>> I would wager this relates to this upstream fix:
>>>
>>> commit 298fce95db03e41d511d1890f3e667c105ac1363
>>> Author: Kevin O'Connor <kevin@koconnor.net>
>>> Date:   Sun Dec 2 01:15:03 2012 -0500
>>>
>>>      ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
>>>      
>>>      Recent iasl compilers warn about spurious return calls.  Remove extra
>>>      return calls from the GPE event methods.  This is the q35 dsdt
>>>      equivalent of patch 475ce3f5f6a986877d637ac39f6ee23484ecc992.
>>>      
>>> Can you see if cherry picking that from
>>> git://git.seabios.org/seabios.git fixes the issue for you please. I
>>> don't think we even use the q35 DSDT so this is just a build issue.
>> This patch updates the file src/q35-acpi-dsdt.dsl which doesn't exist in
>> our version of seabios. But while looking at the commit messages I found
>> 475ce3f5f6a986877d637ac39f6ee23484ecc992.
>> This updates src/acpi-dsdt.dsl and the warnings
>>
>> out/acpi-dsdt.dsl.i    578:             Return(0x01)
>> Warning  1104 -                                  ^ Reserved method should not return a value (_L00)
>>
>> went away. With that patch in mind I fixed src/ssdt-pcihp.dsl and the warnings
>>
>> out/ssdt-pcihp.dsl.i     12:  Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) }
>> Warning  1104 - Reserved method should not return a value ^  (_EJ0)
>>
>> went away to
> Excellent, George I think we should cherry-pick
> 475ce3f5f6a986877d637ac39f6ee23484ecc992 from upstream seabios for 4.3.

Sounds good to me.

  -George