All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: Xen 4.3 RC1 Test Day on freenode channel #xentest is today
       [not found] <518A002B.1090103@xen.org>
@ 2013-05-08  8:30 ` Dietmar Hahn
  2013-05-08  9:10   ` [Xen-users] " Ian Campbell
  0 siblings, 1 reply; 7+ messages in thread
From: Dietmar Hahn @ 2013-05-08  8:30 UTC (permalink / raw)
  To: xen-devel, lars.kurth; +Cc: xen-users@lists.xen.org, xen-api@lists.xen.org

Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
> Hi everybody,
> 
> we have the first test day for Xen 4.3 today.
> 
> For more information on Test Days and how to join see 
> http://wiki.xen.org/wiki/Xen_Test_Days
> For test instructions see 
> http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions

I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
I did:

# git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
# cd xen
# ./configure --libdir=/usr/lib64
# make dist

The compiling breaks in building seabios and at the moment I have no glue
where to look.
If anybody can give a hint I can help to debug this.
Thanks.

Dietmar.


make[3]: Entering directory `/home/hahn/Src/Xen/Git/xen/tools/firmware'
GIT='socksify git' /home/hahn/Src/Xen/Git/xen/tools/firmware/../../scripts/git-checkout.sh git://xenbits.xen.org/seabios.git rel-1.7.1 seabios-dir
Cloning into 'seabios-dir-remote.tmp'...
remote: Counting objects: 8293, done.
remote: Compressing objects: 100% (1817/1817), done.
remote: Total 8293 (delta 6599), reused 8149 (delta 6470)
Receiving objects: 100% (8293/8293), 2.04 MiB | 54 KiB/s, done.
Resolving deltas: 100% (6599/6599), done.
/home/hahn/Src/Xen/Git/xen/tools/firmware/seabios-dir-remote.tmp
Switched to a new branch 'dummy'
cp seabios-config seabios-dir/.config;
make PYTHON=python subdirs-all
make[4]: Entering directory `/home/hahn/Src/Xen/Git/xen/tools/firmware'
make[5]: Entering directory `/home/hahn/Src/Xen/Git/xen/tools/firmware'
make -C seabios-dir all
  Working around non-functional -combine
make[6]: Entering directory `/home/hahn/Src/Xen/Git/xen/tools/firmware/seabios-dir-remote'
  Build Kconfig config file
  Compiling IASL out/acpi-dsdt.hex
out/acpi-dsdt.dsl.i    578:             Return(0x01)
Warning  1104 -                                  ^ Reserved method should not return a value (_L00)

out/acpi-dsdt.dsl.i    581:             Return(\_SB.PCI0.PCNF())
Warning  1104 -  Reserved method should not return a value ^  (_E01)

out/acpi-dsdt.dsl.i    584:             Return(\_SB.PRSC())
Warning  1104 -                                       ^ Reserved method should not return a value (_E02)

out/acpi-dsdt.dsl.i    587:             Return(0x01)
Warning  1104 -                                  ^ Reserved method should not return a value (_L03)

out/acpi-dsdt.dsl.i    590:             Return(0x01)
Warning  1104 -                                  ^ Reserved method should not return a value (_L04)

out/acpi-dsdt.dsl.i    593:             Return(0x01)
Warning  1104 -                                  ^ Reserved method should not return a value (_L05)

out/acpi-dsdt.dsl.i    596:             Return(0x01)
Warning  1104 -                                  ^ Reserved method should not re
...
...
And a lot more of these warnings
...
...
ASL Input:     out/acpi-dsdt.dsl.i - 628 lines, 22960 bytes, 344 keywords
AML Output:    out/acpi-dsdt.aml - 4682 bytes, 163 named objects, 181 executable opcodes
Listing File:  out/acpi-dsdt.lst - 150565 bytes
Hex Dump:      out/acpi-dsdt.hex - 44234 bytes

Compilation complete. 0 Errors, 16 Warnings, 0 Remarks, 257 Optimizations
  Compiling IASL out/ssdt-proc.hex
ASL Input:     out/ssdt-proc.dsl.i - 35 lines, 765 bytes, 8 keywords
AML Output:    out/ssdt-proc.aml - 120 bytes, 6 named objects, 2 executable opcodes
Listing File:  out/ssdt-proc.lst - 2563 bytes
Hex Dump:      out/ssdt-proc.hex - 1407 bytes

Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
  Compiling IASL out/ssdt-pcihp.hex
out/ssdt-pcihp.dsl.i     12:  Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) }
Warning  1104 - Reserved method should not return a value ^  (_EJ0)

out/ssdt-pcihp.dsl.i     17:  Method (_EJ0, 1) { Return(PCEJ(0x02)) } Name (_SUN, 0x02) }
Warning  1104 - Reserved method should not return a value ^  (_EJ0)

out/ssdt-pcihp.dsl.i     22:  Method (_EJ0, 1) { Return(PCEJ(0x03)) } Name (_SUN, 0x03) }
Warning  1104 - Reserved method should not return a value ^  (_EJ0)
...
...
And a lot more of these warnings
...
...
ASL Input:     out/ssdt-pcihp.dsl.i - 231 lines, 8975 bytes, 254 keywords
AML Output:    out/ssdt-pcihp.aml - 1646 bytes, 130 named objects, 124 executable opcodes
Listing File:  out/ssdt-pcihp.lst - 38557 bytes
Hex Dump:      out/ssdt-pcihp.hex - 15734 bytes

Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations
  Compiling whole program out/ccode32flat.o
In file included from out/ccode32flat.o.tmp.c:45:0:
out/../src/acpi.c: In function ‘build_ssdt’:
out/../src/acpi.c:417:34: error: ‘ssdt_proc_end’ undeclared (first use in this function)
out/../src/acpi.c:417:34: note: each undeclared identifier is reported only once for each function it appears in
out/../src/acpi.c:417:34: error: ‘ssdt_proc_start’ undeclared (first use in this function)
out/../src/acpi.c:439:26: error: ‘ssdp_proc_aml’ undeclared (first use in this function)
out/../src/acpi.c:440:18: error: ‘ssdt_proc_name’ undeclared (first use in this function)
out/../src/acpi.c:443:18: error: ‘ssdt_proc_id’ undeclared (first use in this function)
In file included from out/ccode32flat.o.tmp.c:45:0:
out/../src/acpi.c: In function ‘build_pcihp’:
out/../src/acpi.c:528:35: error: ‘ssdp_pcihp_aml’ undeclared (first use in this function)
out/../src/acpi.c:537:9: error: ‘aml_ej0_name’ undeclared (first use in this function)
out/../src/acpi.c:537:37: error: ‘aml_adr_dword’ undeclared (first use in this function)
out/../src/acpi.c:561:14: error: ‘acpi_s3_name’ undeclared (first use in this function)
out/../src/acpi.c:563:14: error: ‘acpi_s4_name’ undeclared (first use in this function)
out/../src/acpi.c:565:14: error: ‘acpi_s4_pkg’ undeclared (first use in this function)
out/../src/acpi.c: In function ‘acpi_bios_init’:
out/../src/acpi.c:780:41: error: ‘AmlCode’ undeclared (first use in this function)
make[6]: *** [out/ccode32flat.o] Error 1
make[6]: Leaving directory `/home/hahn/Src/Xen/Git/xen/tools/firmware/seabios-dir-remote'
make[5]: *** [subdir-all-seabios-dir] Error 2
make[5]: Leaving directory `/home/hahn/Src/Xen/Git/xen/tools/firmware'
make[4]: *** [subdirs-all] Error 2
make[4]: Leaving directory `/home/hahn/Src/Xen/Git/xen/tools/firmware'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/hahn/Src/Xen/Git/xen/tools/firmware'
make[2]: *** [subdir-install-firmware] Error 2
make[2]: Leaving directory `/home/hahn/Src/Xen/Git/xen/tools'
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/home/hahn/Src/Xen/Git/xen/tools'
make: *** [install-tools] Error 2




-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Xen-users] Xen 4.3 RC1 Test Day on freenode channel #xentest is today
  2013-05-08  8:30 ` Xen 4.3 RC1 Test Day on freenode channel #xentest is today Dietmar Hahn
@ 2013-05-08  9:10   ` Ian Campbell
  2013-05-08 12:07     ` Dietmar Hahn
  0 siblings, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2013-05-08  9:10 UTC (permalink / raw)
  To: Dietmar Hahn; +Cc: George Dunlap, lars.kurth@xen.org, xen-devel@lists.xen.org

On Wed, 2013-05-08 at 09:30 +0100, Dietmar Hahn wrote:
> Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
> > Hi everybody,
> > 
> > we have the first test day for Xen 4.3 today.
> > 
> > For more information on Test Days and how to join see 
> > http://wiki.xen.org/wiki/Xen_Test_Days
> > For test instructions see 
> > http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions
> 
> I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
> As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
> I did:
> 
> # git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
> # cd xen
> # ./configure --libdir=/usr/lib64
> # make dist
> 
> The compiling breaks in building seabios and at the moment I have no glue
> where to look.

All lists apart from xen-devel to bcc, adding release manager.

Looks like a conflict with your version of iasl, which are you using?

I would wager this relates to this upstream fix:

commit 298fce95db03e41d511d1890f3e667c105ac1363
Author: Kevin O'Connor <kevin@koconnor.net>
Date:   Sun Dec 2 01:15:03 2012 -0500

    ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
    
    Recent iasl compilers warn about spurious return calls.  Remove extra
    return calls from the GPE event methods.  This is the q35 dsdt
    equivalent of patch 475ce3f5f6a986877d637ac39f6ee23484ecc992.
    
Can you see if cherry picking that from
git://git.seabios.org/seabios.git fixes the issue for you please. I
don't think we even use the q35 DSDT so this is just a build issue.

We currently have SeaBIOS 1.7.1 in unstable, there have been 1.7.2 and
1.7.2.1 releases since then, which include that fix. The full list of
changes is below. I don't think we want to just pull in the later
SeaBIOS releases at this stage, although that would be simplest and it
looks like a largish number of the changes will have no impact on us. I
think cherry picking the one fix is probably the right approach.

Ian.

88cb66e seabios: Add a dummy PCI slot to irq mapping function
985a9d3 seabios q35: Add new PCI slot to irq routing function
2b57726 seabios q35: Enable all PIRQn IRQs at startup
e5fe4f9 Verify CC is valid during build tests.
4219149 build: Don't require $(OUT) to be a sub-directory of the main directory.
d75c22f Fix Makefile - don't reference "out/" directly, instead use "$(OUT)".
12e8199 USB-EHCI: Fix null pointer assignment
f396871 Update tools/acpi_extract.py to handle iasl 20130117 release.
4bd8aeb vgabios: implement AX=1120H..1124H functions
54ae543 boot: Support "halt" in the boot order to prevent default boot attempts.
261e870 megasas: Invert PCI device selection
57174c7 Minor: Separate UUID display from F12 boot prompt.
9c6fb72 display_uuid(): fix incomplete check after the loop
a810e4e acpi: Use prt_slot() macro to describe irq pins of first PCI device.
f64a472 acpi: reintroduce LNKS
37676f8 maininit(): print machine UUID under seabios version message
c39a272 Add compile checking phase to build.
fa2eacb Don't use gcc's -combine option.
3ffa8cc Don't recursively evaluate CFLAGS variables.
f9c3072 vga: Minor comment spelling fix.
ff5e005 floppy: Minor - reduce handle_0e code size when CONFIG_FLOPPY is disabled.
e8a76b0 acpi: drop irq 8 from hpet ressources
f92f833 acpi: Minor - merge the two dsdt ISA areas into one ISA area.
7a53595 acpi: fix COM2._UID
e8b6910 acpi: reorder PX13 + ISA
c104aa8 acpi: PCI routing DSDT simplifications.
f0cd3a9 ACPI: Delineate q35 ACSP DSL code into sections.
dabe193 ACPI: Move q35 PCI irq definitions together.
bb43027 ACPI: Move PCI0 hotplug and irq definitions to there respective areas.
298fce9 ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
e9e7ab4 acpi: Reindent DSDT code.
f051a76 acpi: move isa devices to separate file [q35]
7e269b4 acpi: add mcfg table for mmconfig
3d11108 q35: fix default vga address
8d74497 acpi: move isa devices to separate file
fb87c19 acpi: rework enable bits
f50a55c acpi: move cpu hotplug to separate file [q35]
3aab6ff acpi: move cpu hotplug to separate file
aa3defc acpi: move \_SB.PCI0._CRS to separate file [q35]
20886ab acpi: move \_SB.PCI0._CRS to separate file
7464aea acpi: move \_SB.HPET to separate file [q35]
4dfa547 acpi: move \_SB.HPET to separate file
beaedaa acpi: move DBUG() to separate file [q35]
0e25a25 acpi: move DBUG() to separate file
2114f50 seabios: q35: Register PCI IRQs as active high in APIC mode
ecbe3fd seabios: q35: add dsdt
72a590e seabios: add q35 initialization functions.
d146ab8 seabios: pci: enable SERR of normal device.
229e8e2 seabios: acpi, fadt: make while fadt initialization chipset specific
a39a9c3 seabios: make mttr UC area setup dynamic
8b73b83 floppy: Allow floppy code to be used with coreboot.
ef71989 floppy: Minor cleanup - reduce some cut-and-paste code.
b1c35f2 pciinit: Align start of PCI memory on i440 chipset.
31dcfb0 Collapse PCI device tables in pci_bios_init_devices().
68513ab esp: enable busmaster
7d05257 lsi: enable busmaster
2df70bf megasas: Add boot support for LSI MegaRAID SAS
d9f5cdb DSDT: Fix HPET _CRS Method
9600c80 config: add coreboot / qemu choice
475ce3f ACPI: Remove unnecessary Return(One) calls from DSDT.
9474a35 Provide correct dpte pointer to indicate absence of dpte
02203b5 geodevga: Setup flat panel if needed
fad37fd geodevga: Add defines for VP_MSR_PADSEL
eac884d geodevga: Setup output based on .config
5556f21 geodevga: Add configuration option for output modes
f6930c5 geodevga: Add VP_MSR_CONFIG defines
5506376 geodevga: Add some basic flat panel defines
119ece9 geodevga: Add functions to work with fp register
286e013 geodevga: Rename defines to better match a well defined naming schema
ef7f73f geodevga: Access global variables using GET_GLOBAL/SET_VGA macros.
30e6af0 Fix 'union u64_u32_u' member names.
455a7c8 add acpi pmtimer support
a1a3283 Report stdvga modes in VBE via int10 (AX = 4F00h)
58dd051 vgabios: Add support for text and cga modes to vbe_104f01().
49ddd9e vgabios: Check for relocatable windows before advertising support for it.
ef4f9e1 vgabios: Ignore mode flags in vbe get_mode_info call.
c8a3d3e bootsplash: Don't pass mode flags to VBE get_mode_info call.
f47461f Geode vga: Use standard format read/write_mask register functions.
d136fd7 Add helper functions to access DC and VP register
11ebc7d Change return values for vp_setup() and dc_setup()
7bec6db Add global struct geode
517f742 Update VBE variables
9de339d Add framebuffer size detection
0155aef Remove Extened CRTC Register functions
efb9784 Remove all dc_ functions as they are not needed anymore
c13c181 Access DC registers via geode_mem[Read|Write]
4540409 acpi: LNKS is not needed
71ed8e3 acpi: build PCI hotplug devices from a single template
7dceba3 acpi: build PCNT dynamically
2b568eb acpi_extract: detect DeviceOp
f960782 acpi_extract: fix off-by-one
c8ed45e acpi: rename Processor SSDT constants
cf5bef4 acpi: move s3/s4/s5 to build_ssdt
3dcc223 Makefile: delete output on error
7f03685 apic_id_is_present: fix undefined behavior
b306459 Use cpu_to_be32() (and related) instead of htonl (and related).

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Xen-users] Xen 4.3 RC1 Test Day on freenode channel #xentest is today
  2013-05-08  9:10   ` [Xen-users] " Ian Campbell
@ 2013-05-08 12:07     ` Dietmar Hahn
  2013-05-08 12:15       ` Ian Campbell
  0 siblings, 1 reply; 7+ messages in thread
From: Dietmar Hahn @ 2013-05-08 12:07 UTC (permalink / raw)
  To: xen-devel; +Cc: George Dunlap, lars.kurth@xen.org, Ian Campbell

Am Mittwoch 08 Mai 2013, 10:10:37 schrieb Ian Campbell:
> On Wed, 2013-05-08 at 09:30 +0100, Dietmar Hahn wrote:
> > Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
> > > Hi everybody,
> > > 
> > > we have the first test day for Xen 4.3 today.
> > > 
> > > For more information on Test Days and how to join see 
> > > http://wiki.xen.org/wiki/Xen_Test_Days
> > > For test instructions see 
> > > http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions
> > 
> > I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
> > As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
> > I did:
> > 
> > # git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
> > # cd xen
> > # ./configure --libdir=/usr/lib64
> > # make dist
> > 
> > The compiling breaks in building seabios and at the moment I have no glue
> > where to look.
> 
> All lists apart from xen-devel to bcc, adding release manager.
> 
> Looks like a conflict with your version of iasl, which are you using?

# iasl -v

Intel ACPI Component Architecture
ASL Optimizing Compiler version 20121220-64
Copyright (c) 2000 - 2012 Intel Corporation

> I would wager this relates to this upstream fix:
> 
> commit 298fce95db03e41d511d1890f3e667c105ac1363
> Author: Kevin O'Connor <kevin@koconnor.net>
> Date:   Sun Dec 2 01:15:03 2012 -0500
> 
>     ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
>     
>     Recent iasl compilers warn about spurious return calls.  Remove extra
>     return calls from the GPE event methods.  This is the q35 dsdt
>     equivalent of patch 475ce3f5f6a986877d637ac39f6ee23484ecc992.
>     
> Can you see if cherry picking that from
> git://git.seabios.org/seabios.git fixes the issue for you please. I
> don't think we even use the q35 DSDT so this is just a build issue.

This patch updates the file src/q35-acpi-dsdt.dsl which doesn't exist in
our version of seabios. But while looking at the commit messages I found
475ce3f5f6a986877d637ac39f6ee23484ecc992.
This updates src/acpi-dsdt.dsl and the warnings

out/acpi-dsdt.dsl.i    578:             Return(0x01)
Warning  1104 -                                  ^ Reserved method should not return a value (_L00)

went away. With that patch in mind I fixed src/ssdt-pcihp.dsl and the warnings

out/ssdt-pcihp.dsl.i     12:  Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) }
Warning  1104 - Reserved method should not return a value ^  (_EJ0)

went away to but the errors remain:

I played a little bit with the seabios-dir/Makefile and found that all the
*.off files are empty and *.hex too. This caused  the errors

out/../src/acpi.c:417:34: error: ‘ssdt_proc_end’ undeclared (first use in this function)
out/../src/acpi.c:417:34: note: each undeclared identifier is reported only once for each function it appears in
out/../src/acpi.c:417:34: error: ‘ssdt_proc_start’ undeclared (first use in this function)
out/../src/acpi.c:439:26: error: ‘ssdp_proc_aml’ undeclared (first use in this function)
out/../src/acpi.c:440:18: error: ‘ssdt_proc_name’ undeclared (first use in this function)
out/../src/acpi.c:443:18: error: ‘ssdt_proc_id’ undeclared (first use in this function)
In file included from out/ccode32flat.o.tmp.c:45:0:

So the question is why are these empty.
Maybe it has to do with my iasl as this creates the *.lst files as input for
generating the *.off files

Dietmar.


-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Xen-users] Xen 4.3 RC1 Test Day on freenode channel #xentest is today
  2013-05-08 12:07     ` Dietmar Hahn
@ 2013-05-08 12:15       ` Ian Campbell
  2013-05-08 12:35         ` Dietmar Hahn
  2013-05-08 12:37         ` George Dunlap
  0 siblings, 2 replies; 7+ messages in thread
From: Ian Campbell @ 2013-05-08 12:15 UTC (permalink / raw)
  To: Dietmar Hahn; +Cc: George Dunlap, lars.kurth@xen.org, xen-devel@lists.xen.org

On Wed, 2013-05-08 at 13:07 +0100, Dietmar Hahn wrote:
> Am Mittwoch 08 Mai 2013, 10:10:37 schrieb Ian Campbell:
> > On Wed, 2013-05-08 at 09:30 +0100, Dietmar Hahn wrote:
> > > Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
> > > > Hi everybody,
> > > > 
> > > > we have the first test day for Xen 4.3 today.
> > > > 
> > > > For more information on Test Days and how to join see 
> > > > http://wiki.xen.org/wiki/Xen_Test_Days
> > > > For test instructions see 
> > > > http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions
> > > 
> > > I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
> > > As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
> > > I did:
> > > 
> > > # git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
> > > # cd xen
> > > # ./configure --libdir=/usr/lib64
> > > # make dist
> > > 
> > > The compiling breaks in building seabios and at the moment I have no glue
> > > where to look.
> > 
> > All lists apart from xen-devel to bcc, adding release manager.
> > 
> > Looks like a conflict with your version of iasl, which are you using?
> 
> # iasl -v
> 
> Intel ACPI Component Architecture
> ASL Optimizing Compiler version 20121220-64
> Copyright (c) 2000 - 2012 Intel Corporation
> 
> > I would wager this relates to this upstream fix:
> > 
> > commit 298fce95db03e41d511d1890f3e667c105ac1363
> > Author: Kevin O'Connor <kevin@koconnor.net>
> > Date:   Sun Dec 2 01:15:03 2012 -0500
> > 
> >     ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
> >     
> >     Recent iasl compilers warn about spurious return calls.  Remove extra
> >     return calls from the GPE event methods.  This is the q35 dsdt
> >     equivalent of patch 475ce3f5f6a986877d637ac39f6ee23484ecc992.
> >     
> > Can you see if cherry picking that from
> > git://git.seabios.org/seabios.git fixes the issue for you please. I
> > don't think we even use the q35 DSDT so this is just a build issue.
> 
> This patch updates the file src/q35-acpi-dsdt.dsl which doesn't exist in
> our version of seabios. But while looking at the commit messages I found
> 475ce3f5f6a986877d637ac39f6ee23484ecc992.
> This updates src/acpi-dsdt.dsl and the warnings
> 
> out/acpi-dsdt.dsl.i    578:             Return(0x01)
> Warning  1104 -                                  ^ Reserved method should not return a value (_L00)
> 
> went away. With that patch in mind I fixed src/ssdt-pcihp.dsl and the warnings
> 
> out/ssdt-pcihp.dsl.i     12:  Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) }
> Warning  1104 - Reserved method should not return a value ^  (_EJ0)
> 
> went away to

Excellent, George I think we should cherry-pick
475ce3f5f6a986877d637ac39f6ee23484ecc992 from upstream seabios for 4.3.

>  but the errors remain:

Sorry, I must have missed those in the original mail.

> I played a little bit with the seabios-dir/Makefile and found that all the
> *.off files are empty and *.hex too. This caused  the errors
> 
> out/../src/acpi.c:417:34: error: ‘ssdt_proc_end’ undeclared (first use in this function)
> out/../src/acpi.c:417:34: note: each undeclared identifier is reported only once for each function it appears in
> out/../src/acpi.c:417:34: error: ‘ssdt_proc_start’ undeclared (first use in this function)
> out/../src/acpi.c:439:26: error: ‘ssdp_proc_aml’ undeclared (first use in this function)
> out/../src/acpi.c:440:18: error: ‘ssdt_proc_name’ undeclared (first use in this function)
> out/../src/acpi.c:443:18: error: ‘ssdt_proc_id’ undeclared (first use in this function)
> In file included from out/ccode32flat.o.tmp.c:45:0:
> 
> So the question is why are these empty.
> Maybe it has to do with my iasl as this creates the *.lst files as input for
> generating the *.off files

Could be related to

        commit f396871e3df9da14c65ab24a5a881674e06150a9
        Author: Kevin O'Connor <kevin@koconnor.net>
        Date:   Sun Feb 10 21:06:14 2013 -0500
        
            Update tools/acpi_extract.py to handle iasl 20130117 release.
            
            The latest iasl release produces "lst" output with "number:  " instead
            of "number....".  Update the tool to support both formats.
            
            Reported-by: Bo Yang <boyang@suse.com>
            Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
        
Except that quotes a newer version than what you have.

Could you try building the upstream 1.7.2.1 release in your environment?

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Xen-users] Xen 4.3 RC1 Test Day on freenode channel #xentest is today
  2013-05-08 12:15       ` Ian Campbell
@ 2013-05-08 12:35         ` Dietmar Hahn
  2013-05-08 12:44           ` Ian Campbell
  2013-05-08 12:37         ` George Dunlap
  1 sibling, 1 reply; 7+ messages in thread
From: Dietmar Hahn @ 2013-05-08 12:35 UTC (permalink / raw)
  To: Ian Campbell; +Cc: George Dunlap, lars.kurth@xen.org, xen-devel@lists.xen.org

Am Mittwoch 08 Mai 2013, 13:15:33 schrieb Ian Campbell:
> On Wed, 2013-05-08 at 13:07 +0100, Dietmar Hahn wrote:
> > Am Mittwoch 08 Mai 2013, 10:10:37 schrieb Ian Campbell:
> > > On Wed, 2013-05-08 at 09:30 +0100, Dietmar Hahn wrote:
> > > > Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
> > > > > Hi everybody,
> > > > > 
> > > > > we have the first test day for Xen 4.3 today.
> > > > > 
> > > > > For more information on Test Days and how to join see 
> > > > > http://wiki.xen.org/wiki/Xen_Test_Days
> > > > > For test instructions see 
> > > > > http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions
> > > > 
> > > > I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
> > > > As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
> > > > I did:
> > > > 
> > > > # git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
> > > > # cd xen
> > > > # ./configure --libdir=/usr/lib64
> > > > # make dist
> > > > 
> > > > The compiling breaks in building seabios and at the moment I have no glue
> > > > where to look.
> > > 
> > > All lists apart from xen-devel to bcc, adding release manager.
> > > 
> > > Looks like a conflict with your version of iasl, which are you using?
> > 
> > # iasl -v
> > 
> > Intel ACPI Component Architecture
> > ASL Optimizing Compiler version 20121220-64
> > Copyright (c) 2000 - 2012 Intel Corporation
> > 
> > > I would wager this relates to this upstream fix:
> > > 
> > > commit 298fce95db03e41d511d1890f3e667c105ac1363
> > > Author: Kevin O'Connor <kevin@koconnor.net>
> > > Date:   Sun Dec 2 01:15:03 2012 -0500
> > > 
> > >     ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
> > >     
> > >     Recent iasl compilers warn about spurious return calls.  Remove extra
> > >     return calls from the GPE event methods.  This is the q35 dsdt
> > >     equivalent of patch 475ce3f5f6a986877d637ac39f6ee23484ecc992.
> > >     
> > > Can you see if cherry picking that from
> > > git://git.seabios.org/seabios.git fixes the issue for you please. I
> > > don't think we even use the q35 DSDT so this is just a build issue.
> > 
> > This patch updates the file src/q35-acpi-dsdt.dsl which doesn't exist in
> > our version of seabios. But while looking at the commit messages I found
> > 475ce3f5f6a986877d637ac39f6ee23484ecc992.
> > This updates src/acpi-dsdt.dsl and the warnings
> > 
> > out/acpi-dsdt.dsl.i    578:             Return(0x01)
> > Warning  1104 -                                  ^ Reserved method should not return a value (_L00)
> > 
> > went away. With that patch in mind I fixed src/ssdt-pcihp.dsl and the warnings
> > 
> > out/ssdt-pcihp.dsl.i     12:  Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) }
> > Warning  1104 - Reserved method should not return a value ^  (_EJ0)
> > 
> > went away to
> 
> Excellent, George I think we should cherry-pick
> 475ce3f5f6a986877d637ac39f6ee23484ecc992 from upstream seabios for 4.3.
> 
> >  but the errors remain:
> 
> Sorry, I must have missed those in the original mail.
> 
> > I played a little bit with the seabios-dir/Makefile and found that all the
> > *.off files are empty and *.hex too. This caused  the errors
> > 
> > out/../src/acpi.c:417:34: error: ‘ssdt_proc_end’ undeclared (first use in this function)
> > out/../src/acpi.c:417:34: note: each undeclared identifier is reported only once for each function it appears in
> > out/../src/acpi.c:417:34: error: ‘ssdt_proc_start’ undeclared (first use in this function)
> > out/../src/acpi.c:439:26: error: ‘ssdp_proc_aml’ undeclared (first use in this function)
> > out/../src/acpi.c:440:18: error: ‘ssdt_proc_name’ undeclared (first use in this function)
> > out/../src/acpi.c:443:18: error: ‘ssdt_proc_id’ undeclared (first use in this function)
> > In file included from out/ccode32flat.o.tmp.c:45:0:
> > 
> > So the question is why are these empty.
> > Maybe it has to do with my iasl as this creates the *.lst files as input for
> > generating the *.off files
> 
> Could be related to
> 
>         commit f396871e3df9da14c65ab24a5a881674e06150a9
>         Author: Kevin O'Connor <kevin@koconnor.net>
>         Date:   Sun Feb 10 21:06:14 2013 -0500
>         
>             Update tools/acpi_extract.py to handle iasl 20130117 release.
>             
>             The latest iasl release produces "lst" output with "number:  " instead
>             of "number....".  Update the tool to support both formats.
>             
>             Reported-by: Bo Yang <boyang@suse.com>
>             Signed-off-by: Kevin O'Connor <kevin@koconnor.net>

Yes this patch did the job!

>         
> Except that quotes a newer version than what you have.
> 
> Could you try building the upstream 1.7.2.1 release in your environment?

I'll try it but this will take a little bit of time.
Thanks.

Dietmar.

-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Xen-users] Xen 4.3 RC1 Test Day on freenode channel #xentest is today
  2013-05-08 12:15       ` Ian Campbell
  2013-05-08 12:35         ` Dietmar Hahn
@ 2013-05-08 12:37         ` George Dunlap
  1 sibling, 0 replies; 7+ messages in thread
From: George Dunlap @ 2013-05-08 12:37 UTC (permalink / raw)
  To: Ian Campbell; +Cc: lars.kurth@xen.org, Dietmar Hahn, xen-devel@lists.xen.org

On 08/05/13 13:15, Ian Campbell wrote:
> On Wed, 2013-05-08 at 13:07 +0100, Dietmar Hahn wrote:
>> Am Mittwoch 08 Mai 2013, 10:10:37 schrieb Ian Campbell:
>>> On Wed, 2013-05-08 at 09:30 +0100, Dietmar Hahn wrote:
>>>> Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
>>>>> Hi everybody,
>>>>>
>>>>> we have the first test day for Xen 4.3 today.
>>>>>
>>>>> For more information on Test Days and how to join see
>>>>> http://wiki.xen.org/wiki/Xen_Test_Days
>>>>> For test instructions see
>>>>> http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions
>>>> I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
>>>> As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
>>>> I did:
>>>>
>>>> # git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
>>>> # cd xen
>>>> # ./configure --libdir=/usr/lib64
>>>> # make dist
>>>>
>>>> The compiling breaks in building seabios and at the moment I have no glue
>>>> where to look.
>>> All lists apart from xen-devel to bcc, adding release manager.
>>>
>>> Looks like a conflict with your version of iasl, which are you using?
>> # iasl -v
>>
>> Intel ACPI Component Architecture
>> ASL Optimizing Compiler version 20121220-64
>> Copyright (c) 2000 - 2012 Intel Corporation
>>
>>> I would wager this relates to this upstream fix:
>>>
>>> commit 298fce95db03e41d511d1890f3e667c105ac1363
>>> Author: Kevin O'Connor <kevin@koconnor.net>
>>> Date:   Sun Dec 2 01:15:03 2012 -0500
>>>
>>>      ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
>>>      
>>>      Recent iasl compilers warn about spurious return calls.  Remove extra
>>>      return calls from the GPE event methods.  This is the q35 dsdt
>>>      equivalent of patch 475ce3f5f6a986877d637ac39f6ee23484ecc992.
>>>      
>>> Can you see if cherry picking that from
>>> git://git.seabios.org/seabios.git fixes the issue for you please. I
>>> don't think we even use the q35 DSDT so this is just a build issue.
>> This patch updates the file src/q35-acpi-dsdt.dsl which doesn't exist in
>> our version of seabios. But while looking at the commit messages I found
>> 475ce3f5f6a986877d637ac39f6ee23484ecc992.
>> This updates src/acpi-dsdt.dsl and the warnings
>>
>> out/acpi-dsdt.dsl.i    578:             Return(0x01)
>> Warning  1104 -                                  ^ Reserved method should not return a value (_L00)
>>
>> went away. With that patch in mind I fixed src/ssdt-pcihp.dsl and the warnings
>>
>> out/ssdt-pcihp.dsl.i     12:  Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) }
>> Warning  1104 - Reserved method should not return a value ^  (_EJ0)
>>
>> went away to
> Excellent, George I think we should cherry-pick
> 475ce3f5f6a986877d637ac39f6ee23484ecc992 from upstream seabios for 4.3.

Sounds good to me.

  -George

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Xen-users] Xen 4.3 RC1 Test Day on freenode channel #xentest is today
  2013-05-08 12:35         ` Dietmar Hahn
@ 2013-05-08 12:44           ` Ian Campbell
  0 siblings, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2013-05-08 12:44 UTC (permalink / raw)
  To: Dietmar Hahn; +Cc: George Dunlap, lars.kurth@xen.org, xen-devel@lists.xen.org

On Wed, 2013-05-08 at 13:35 +0100, Dietmar Hahn wrote:
> Am Mittwoch 08 Mai 2013, 13:15:33 schrieb Ian Campbell:
> > On Wed, 2013-05-08 at 13:07 +0100, Dietmar Hahn wrote:
> > > Am Mittwoch 08 Mai 2013, 10:10:37 schrieb Ian Campbell:
> > > > On Wed, 2013-05-08 at 09:30 +0100, Dietmar Hahn wrote:
> > > > > Am Mittwoch 08 Mai 2013, 08:35:07 schrieb Lars Kurth:
> > > > > > Hi everybody,
> > > > > > 
> > > > > > we have the first test day for Xen 4.3 today.
> > > > > > 
> > > > > > For more information on Test Days and how to join see 
> > > > > > http://wiki.xen.org/wiki/Xen_Test_Days
> > > > > > For test instructions see 
> > > > > > http://wiki.xen.org/wiki/Xen_4.3_RC1_test_instructions
> > > > > 
> > > > > I tried to build xen-4.3.0-rc1 on openSUSE 12.3 (x86_64)
> > > > > As described in the wiki http://wiki.xen.org/wiki/Compiling_Xen_From_Source
> > > > > I did:
> > > > > 
> > > > > # git clone -b 4.3.0-rc1 git://xenbits.xen.org/xen.git
> > > > > # cd xen
> > > > > # ./configure --libdir=/usr/lib64
> > > > > # make dist
> > > > > 
> > > > > The compiling breaks in building seabios and at the moment I have no glue
> > > > > where to look.
> > > > 
> > > > All lists apart from xen-devel to bcc, adding release manager.
> > > > 
> > > > Looks like a conflict with your version of iasl, which are you using?
> > > 
> > > # iasl -v
> > > 
> > > Intel ACPI Component Architecture
> > > ASL Optimizing Compiler version 20121220-64
> > > Copyright (c) 2000 - 2012 Intel Corporation
> > > 
> > > > I would wager this relates to this upstream fix:
> > > > 
> > > > commit 298fce95db03e41d511d1890f3e667c105ac1363
> > > > Author: Kevin O'Connor <kevin@koconnor.net>
> > > > Date:   Sun Dec 2 01:15:03 2012 -0500
> > > > 
> > > >     ACPI: Remove unnecessary Return(One) calls from q35 DSDT.
> > > >     
> > > >     Recent iasl compilers warn about spurious return calls.  Remove extra
> > > >     return calls from the GPE event methods.  This is the q35 dsdt
> > > >     equivalent of patch 475ce3f5f6a986877d637ac39f6ee23484ecc992.
> > > >     
> > > > Can you see if cherry picking that from
> > > > git://git.seabios.org/seabios.git fixes the issue for you please. I
> > > > don't think we even use the q35 DSDT so this is just a build issue.
> > > 
> > > This patch updates the file src/q35-acpi-dsdt.dsl which doesn't exist in
> > > our version of seabios. But while looking at the commit messages I found
> > > 475ce3f5f6a986877d637ac39f6ee23484ecc992.
> > > This updates src/acpi-dsdt.dsl and the warnings
> > > 
> > > out/acpi-dsdt.dsl.i    578:             Return(0x01)
> > > Warning  1104 -                                  ^ Reserved method should not return a value (_L00)
> > > 
> > > went away. With that patch in mind I fixed src/ssdt-pcihp.dsl and the warnings
> > > 
> > > out/ssdt-pcihp.dsl.i     12:  Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) }
> > > Warning  1104 - Reserved method should not return a value ^  (_EJ0)
> > > 
> > > went away to
> > 
> > Excellent, George I think we should cherry-pick
> > 475ce3f5f6a986877d637ac39f6ee23484ecc992 from upstream seabios for 4.3.
> > 
> > >  but the errors remain:
> > 
> > Sorry, I must have missed those in the original mail.
> > 
> > > I played a little bit with the seabios-dir/Makefile and found that all the
> > > *.off files are empty and *.hex too. This caused  the errors
> > > 
> > > out/../src/acpi.c:417:34: error: ‘ssdt_proc_end’ undeclared (first use in this function)
> > > out/../src/acpi.c:417:34: note: each undeclared identifier is reported only once for each function it appears in
> > > out/../src/acpi.c:417:34: error: ‘ssdt_proc_start’ undeclared (first use in this function)
> > > out/../src/acpi.c:439:26: error: ‘ssdp_proc_aml’ undeclared (first use in this function)
> > > out/../src/acpi.c:440:18: error: ‘ssdt_proc_name’ undeclared (first use in this function)
> > > out/../src/acpi.c:443:18: error: ‘ssdt_proc_id’ undeclared (first use in this function)
> > > In file included from out/ccode32flat.o.tmp.c:45:0:
> > > 
> > > So the question is why are these empty.
> > > Maybe it has to do with my iasl as this creates the *.lst files as input for
> > > generating the *.off files
> > 
> > Could be related to
> > 
> >         commit f396871e3df9da14c65ab24a5a881674e06150a9
> >         Author: Kevin O'Connor <kevin@koconnor.net>
> >         Date:   Sun Feb 10 21:06:14 2013 -0500
> >         
> >             Update tools/acpi_extract.py to handle iasl 20130117 release.
> >             
> >             The latest iasl release produces "lst" output with "number:  " instead
> >             of "number....".  Update the tool to support both formats.
> >             
> >             Reported-by: Bo Yang <boyang@suse.com>
> >             Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
> 
> Yes this patch did the job!
> 
> >         
> > Except that quotes a newer version than what you have.
> > 
> > Could you try building the upstream 1.7.2.1 release in your environment?
> 
> I'll try it but this will take a little bit of time.

No need now! Sorry, I should have said "If that doesn't work could you
try..."

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-05-08 12:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <518A002B.1090103@xen.org>
2013-05-08  8:30 ` Xen 4.3 RC1 Test Day on freenode channel #xentest is today Dietmar Hahn
2013-05-08  9:10   ` [Xen-users] " Ian Campbell
2013-05-08 12:07     ` Dietmar Hahn
2013-05-08 12:15       ` Ian Campbell
2013-05-08 12:35         ` Dietmar Hahn
2013-05-08 12:44           ` Ian Campbell
2013-05-08 12:37         ` George Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.