From: jim_baxter@mentor.com (Jim Baxter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: fec: enable hardware checksum only on imx6q-fec
Date: Thu, 9 May 2013 10:35:15 +0100 [thread overview]
Message-ID: <518B6DD3.1040201@mentor.com> (raw)
In-Reply-To: <1368083302-12516-1-git-send-email-shawn.guo@linaro.org>
On 09/05/13 08:08, Shawn Guo wrote:
> Commit 4c09eed (net: fec: Enable imx6 enet checksum acceleration.)
> enables hardware checksum acceleration unconditionally for all fec
> variants. This is inappropriate, because some variants like imx5 have
> no such support on hardware. Consequently, fec is broken on these
> platforms. Fix it by enabling hardware checksum only on imx6q-fec type
> of controllers.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Reviewed-by: Jim Baxter <jim_baxter@mentor.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jim Baxter <jim_baxter@mentor.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>, <kernel@pengutronix.de>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] net: fec: enable hardware checksum only on imx6q-fec
Date: Thu, 9 May 2013 10:35:15 +0100 [thread overview]
Message-ID: <518B6DD3.1040201@mentor.com> (raw)
In-Reply-To: <1368083302-12516-1-git-send-email-shawn.guo@linaro.org>
On 09/05/13 08:08, Shawn Guo wrote:
> Commit 4c09eed (net: fec: Enable imx6 enet checksum acceleration.)
> enables hardware checksum acceleration unconditionally for all fec
> variants. This is inappropriate, because some variants like imx5 have
> no such support on hardware. Consequently, fec is broken on these
> platforms. Fix it by enabling hardware checksum only on imx6q-fec type
> of controllers.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Reviewed-by: Jim Baxter <jim_baxter@mentor.com>
next prev parent reply other threads:[~2013-05-09 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 7:08 [PATCH] net: fec: enable hardware checksum only on imx6q-fec Shawn Guo
2013-05-09 7:08 ` Shawn Guo
2013-05-09 9:35 ` Jim Baxter [this message]
2013-05-09 9:35 ` Jim Baxter
2013-05-11 23:12 ` David Miller
2013-05-11 23:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518B6DD3.1040201@mentor.com \
--to=jim_baxter@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.