* [PATCH 13/26] mtd: nand: docg4: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:34 Jingoo Han
2013-05-09 16:16 ` Mike Dunn
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 6:34 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, Jingoo Han, 'David Woodhouse',
'Mike Dunn'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/docg4.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c
index fa25e7a..dc86d4a 100644
--- a/drivers/mtd/nand/docg4.c
+++ b/drivers/mtd/nand/docg4.c
@@ -1368,7 +1368,6 @@ static int __init probe_docg4(struct platform_device *pdev)
struct nand_chip *nand = mtd->priv;
struct docg4_priv *doc = nand->priv;
nand_release(mtd); /* deletes partitions and mtd devices */
- platform_set_drvdata(pdev, NULL);
free_bch(doc->bch);
kfree(mtd);
}
@@ -1380,7 +1379,6 @@ static int __exit cleanup_docg4(struct platform_device *pdev)
{
struct docg4_priv *doc = platform_get_drvdata(pdev);
nand_release(doc->mtd);
- platform_set_drvdata(pdev, NULL);
free_bch(doc->bch);
kfree(doc->mtd);
iounmap(doc->virtadr);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 13/26] mtd: nand: docg4: remove unnecessary platform_set_drvdata()
2013-05-07 6:34 [PATCH 13/26] mtd: nand: docg4: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-09 16:16 ` Mike Dunn
0 siblings, 0 replies; 2+ messages in thread
From: Mike Dunn @ 2013-05-09 16:16 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Artem Bityutskiy', linux-mtd, 'David Woodhouse'
On 05/06/2013 11:34 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Mike Dunn <mikedunn@newsguy.com>
Thanks!
Mike
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-09 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 6:34 [PATCH 13/26] mtd: nand: docg4: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-09 16:16 ` Mike Dunn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.