From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Disable spectral scan code to fix crash on rmmod.
Date: Thu, 09 May 2013 10:40:00 -0700 [thread overview]
Message-ID: <518BDF70.3040407@candelatech.com> (raw)
In-Reply-To: <20875.13834.615920.337442@gargle.gargle.HOWL>
On 05/08/2013 10:37 PM, Sujith Manoharan wrote:
> greearb at candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> With CONFIG_ATH9K_DEBUGFS enabled, and slub memory poisoning
>> enabled, I see this crash on rmmod of ath9k. I'm not sure how
>> to fix this properly, but in the meantime, this patch to disable
>> the spectral scan code works around the problem for me.
>>
>> With memory poisoning and the verify_mem_not_deleted code
>> below added, the crash looks as follows... The dentry
>> is not *always* freed at this point, probably because rcu
>> callbacks haven't completed. You still get a crash soon
>> after, however.
>
> The relay file should probably be closed before calling ieee80211_unregister_hw().
> The ath9k debugfs directory is created inside the phy#/ directory and that would
> get cleaned up when the wiphy is unregistered.
>
> Does this help ?
This fixes the problem for me, and certainly is less of a hack than
what I posted.
I did several module unloads with memory poisoning enabled, system
remains stable.
Tested-by: Ben Greear <greearb@candelatech.com>
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: Disable spectral scan code to fix crash on rmmod.
Date: Thu, 09 May 2013 10:40:00 -0700 [thread overview]
Message-ID: <518BDF70.3040407@candelatech.com> (raw)
In-Reply-To: <20875.13834.615920.337442@gargle.gargle.HOWL>
On 05/08/2013 10:37 PM, Sujith Manoharan wrote:
> greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> With CONFIG_ATH9K_DEBUGFS enabled, and slub memory poisoning
>> enabled, I see this crash on rmmod of ath9k. I'm not sure how
>> to fix this properly, but in the meantime, this patch to disable
>> the spectral scan code works around the problem for me.
>>
>> With memory poisoning and the verify_mem_not_deleted code
>> below added, the crash looks as follows... The dentry
>> is not *always* freed at this point, probably because rcu
>> callbacks haven't completed. You still get a crash soon
>> after, however.
>
> The relay file should probably be closed before calling ieee80211_unregister_hw().
> The ath9k debugfs directory is created inside the phy#/ directory and that would
> get cleaned up when the wiphy is unregistered.
>
> Does this help ?
This fixes the problem for me, and certainly is less of a hack than
what I posted.
I did several module unloads with memory poisoning enabled, system
remains stable.
Tested-by: Ben Greear <greearb@candelatech.com>
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-05-09 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 22:08 [ath9k-devel] [PATCH] ath9k: Disable spectral scan code to fix crash on rmmod greearb at candelatech.com
2013-05-08 22:08 ` greearb
2013-05-09 5:37 ` [ath9k-devel] " Sujith Manoharan
2013-05-09 5:37 ` Sujith Manoharan
2013-05-09 17:40 ` Ben Greear [this message]
2013-05-09 17:40 ` Ben Greear
2013-05-09 18:18 ` [ath9k-devel] " Simon Wunderlich
2013-05-09 18:18 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BDF70.3040407@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.