All of lore.kernel.org
 help / color / mirror / Atom feed
* Fix gssd ignore machine credentials for root
@ 2013-05-11 11:54 Doug Nazar
  2013-05-12 18:20 ` Steve Dickson
  2013-07-02 12:48 ` Steve Dickson
  0 siblings, 2 replies; 3+ messages in thread
From: Doug Nazar @ 2013-05-11 11:54 UTC (permalink / raw)
  To: linux-nfs

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

Commit 1c787f14 [gssd: scan for DIR: ccaches, too] changed the default 
prefix for the credential cache files. Update the check to ignore the 
machine credential file when running with -n (root ignores machine 
credentials).

Doug


[-- Attachment #2: nfs-utils-root-ignore-machine-creds-fix.patch --]
[-- Type: text/plain, Size: 430 bytes --]

--- utils/gssd/krb5_util.c	2013-05-11 00:33:08.054297810 -0400
+++ ../nfs-utils-1.2.7.new/utils/gssd/krb5_util.c	2012-11-11 18:01:23.000000000 -0500
@@ -231,7 +231,7 @@
 				continue;
 			}
 			if (uid == 0 && !root_uses_machine_creds && 
-				strstr(namelist[i]->d_name, "_machine_")) {
+				strstr(namelist[i]->d_name, "machine_")) {
 				printerr(3, "CC '%s' not available to root\n",
 					 statname);
 				free(namelist[i]);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix gssd ignore machine credentials for root
  2013-05-11 11:54 Fix gssd ignore machine credentials for root Doug Nazar
@ 2013-05-12 18:20 ` Steve Dickson
  2013-07-02 12:48 ` Steve Dickson
  1 sibling, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2013-05-12 18:20 UTC (permalink / raw)
  To: Doug Nazar; +Cc: linux-nfs

Hi

On 11/05/13 07:54, Doug Nazar wrote:
> Commit 1c787f14 [gssd: scan for DIR: ccaches, too] changed the default prefix for the credential cache files. Update the check to ignore the machine credential file when running with -n (root ignores machine credentials).
Thank you very much for point this bug out but could you please
resubmit the patch using the proper Signed-off-by format define section 
12 of https://www.kernel.org/doc/Documentation/SubmittingPatches

Sections 1, 7, 11, 15 are also some what important.... Thanks! 

steved.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix gssd ignore machine credentials for root
  2013-05-11 11:54 Fix gssd ignore machine credentials for root Doug Nazar
  2013-05-12 18:20 ` Steve Dickson
@ 2013-07-02 12:48 ` Steve Dickson
  1 sibling, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2013-07-02 12:48 UTC (permalink / raw)
  To: Doug Nazar; +Cc: linux-nfs



On 11/05/13 07:54, Doug Nazar wrote:
> Commit 1c787f14 [gssd: scan for DIR: ccaches, too] changed the default prefix for the credential cache files. Update the check to ignore the machine credential file when running with -n (root ignores machine credentials).
Committed...

In the future please send patches in line and with the work "[PATCH]" in the subject. 

steved.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-02 12:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 11:54 Fix gssd ignore machine credentials for root Doug Nazar
2013-05-12 18:20 ` Steve Dickson
2013-07-02 12:48 ` Steve Dickson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.