* [Ocfs2-devel] [PATCH] ocfs2: goto out_unlock if ocfs2_get_clusters_nocache failed in ocfs2_fiemap
@ 2013-05-14 6:02 Joseph Qi
2013-05-14 6:41 ` Jeff Liu
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Qi @ 2013-05-14 6:02 UTC (permalink / raw)
To: ocfs2-devel
Last time we found there is lock/unlock bug in ocfs2_file_aio_write, and
then we did a thorough search for all lock resources in
ocfs2_inode_info, including rw, inode and open lockres and found this
bug. My kernel version is 3.0.13, and it is also in the lastest version 3.9.
In ocfs2_fiemap, once ocfs2_get_clusters_nocache failed, it should goto
out_unlock instead of out, because we need release buffer head, up read
alloc sem and unlock inode.
Cc: stable at vger.kernel.org
Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
---
fs/ocfs2/extent_map.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c
index 1c39efb..2487116 100644
--- a/fs/ocfs2/extent_map.c
+++ b/fs/ocfs2/extent_map.c
@@ -790,7 +790,7 @@ int ocfs2_fiemap(struct inode *inode, struct
fiemap_extent_info *fieinfo,
&hole_size, &rec, &is_last);
if (ret) {
mlog_errno(ret);
- goto out;
+ goto out_unlock;
}
if (rec.e_blkno == 0ULL) {
--
1.7.9.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: goto out_unlock if ocfs2_get_clusters_nocache failed in ocfs2_fiemap
2013-05-14 6:02 [Ocfs2-devel] [PATCH] ocfs2: goto out_unlock if ocfs2_get_clusters_nocache failed in ocfs2_fiemap Joseph Qi
@ 2013-05-14 6:41 ` Jeff Liu
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Liu @ 2013-05-14 6:41 UTC (permalink / raw)
To: ocfs2-devel
On 05/14/2013 02:02 PM, Joseph Qi wrote:
> Last time we found there is lock/unlock bug in ocfs2_file_aio_write, and
> then we did a thorough search for all lock resources in
> ocfs2_inode_info, including rw, inode and open lockres and found this
> bug. My kernel version is 3.0.13, and it is also in the lastest version 3.9.
> In ocfs2_fiemap, once ocfs2_get_clusters_nocache failed, it should goto
> out_unlock instead of out, because we need release buffer head, up read
> alloc sem and unlock inode.
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
>
> ---
> fs/ocfs2/extent_map.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c
> index 1c39efb..2487116 100644
> --- a/fs/ocfs2/extent_map.c
> +++ b/fs/ocfs2/extent_map.c
> @@ -790,7 +790,7 @@ int ocfs2_fiemap(struct inode *inode, struct
> fiemap_extent_info *fieinfo,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Corrupt patch.
After fixing this issue, you can add:
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
> &hole_size, &rec, &is_last);
> if (ret) {
> mlog_errno(ret);
> - goto out;
> + goto out_unlock;
> }
>
> if (rec.e_blkno == 0ULL) {
>
-Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-14 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-14 6:02 [Ocfs2-devel] [PATCH] ocfs2: goto out_unlock if ocfs2_get_clusters_nocache failed in ocfs2_fiemap Joseph Qi
2013-05-14 6:41 ` Jeff Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.