All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: wim@iguana.be, linux-watchdog@vger.kernel.org
Cc: Carlo Caione <carlo.caione@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: sunxi: New watchdog driver for Allwinner A10/A13
Date: Wed, 15 May 2013 10:43:00 +0200	[thread overview]
Message-ID: <51934A94.3070503@free-electrons.com> (raw)
In-Reply-To: <1368390994-27161-1-git-send-email-carlo.caione@gmail.com>

Hi,

Le 12/05/2013 22:36, Carlo Caione a écrit :
> This patch adds the driver for the watchdog found in the Allwinner A10 and
> A13 SoCs. It has DT-support and uses the new watchdog framework.

I'd like to start some more general discussion here.

All the sunxi boards don't have a PMIC to do the reset properly, so we
chose to do the reboot hook using the watchdog.

How is that handled usually? Obviously, we could have a rather minimal
approach, like this one, where we have code duplication between the arch
code and the watchdog driver code, which is probably not so nice, but I
couldn't find either any convention for this, or a piece of
infrastructure to do so.

What could be the preferred solution?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sunxi: New watchdog driver for Allwinner A10/A13
Date: Wed, 15 May 2013 10:43:00 +0200	[thread overview]
Message-ID: <51934A94.3070503@free-electrons.com> (raw)
In-Reply-To: <1368390994-27161-1-git-send-email-carlo.caione@gmail.com>

Hi,

Le 12/05/2013 22:36, Carlo Caione a ?crit :
> This patch adds the driver for the watchdog found in the Allwinner A10 and
> A13 SoCs. It has DT-support and uses the new watchdog framework.

I'd like to start some more general discussion here.

All the sunxi boards don't have a PMIC to do the reset properly, so we
chose to do the reboot hook using the watchdog.

How is that handled usually? Obviously, we could have a rather minimal
approach, like this one, where we have code duplication between the arch
code and the watchdog driver code, which is probably not so nice, but I
couldn't find either any convention for this, or a piece of
infrastructure to do so.

What could be the preferred solution?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2013-05-15  8:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-12 20:36 [PATCH] ARM: sunxi: New watchdog driver for Allwinner A10/A13 Carlo Caione
2013-05-12 20:36 ` Carlo Caione
2013-05-15  8:34 ` Maxime Ripard
2013-05-15  8:34   ` Maxime Ripard
2013-05-15 12:28   ` Guenter Roeck
2013-05-15 12:28     ` Guenter Roeck
2013-05-16 15:33     ` Maxime Ripard
2013-05-16 15:33       ` Maxime Ripard
2013-05-15  8:43 ` Maxime Ripard [this message]
2013-05-15  8:43   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51934A94.3070503@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=carlo.caione@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.