All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vikram Narayanan <vikram186@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v5 09/11] mtd: parse out the ECC info for the full-id nand chips
Date: Wed, 15 May 2013 22:24:02 +0530	[thread overview]
Message-ID: <5193BDAA.8040909@gmail.com> (raw)
In-Reply-To: <1368607232-2210-10-git-send-email-b32955@freescale.com>

On 5/15/2013 2:10 PM, Huang Shijie wrote:
> Parse out the ECC information for the full-id nand chips.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
>   drivers/mtd/nand/nand_base.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 41e5c07..359e105 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3243,6 +3243,8 @@ static bool find_full_id_nand(struct mtd_info *mtd, struct nand_chip *chip,
>   		chip->cellinfo = id_data[2];
>   		chip->chipsize = (uint64_t)type->chipsize << 20;
>   		chip->options |= type->options;
> +		chip->ecc_strength = NAND_ECC_STRENGTH(type);
> +		chip->ecc_step = NAND_ECC_STEP(type);

Does all NAND chips define this? I mean the patch 10/11 "mtd: add the 
ecc info for some full-id nand chips". What does the above result for 
the other chips? Does it get populated at runtime?

~Vikram

  reply	other threads:[~2013-05-15 16:54 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15  8:40 [PATCH v5 00/11] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-05-15  8:40 ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 01/11] " Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15 12:11   ` Artem Bityutskiy
2013-05-15 12:11     ` Artem Bityutskiy
2013-05-16  2:16     ` Huang Shijie
2013-05-16  2:16       ` Huang Shijie
2013-05-16  7:14       ` Artem Bityutskiy
2013-05-16  7:14         ` Artem Bityutskiy
2013-05-16  8:06         ` Huang Shijie
2013-05-16  8:06           ` Huang Shijie
2013-05-16  9:36           ` Artem Bityutskiy
2013-05-16  9:36             ` Artem Bityutskiy
2013-05-16 10:46             ` Huang Shijie
2013-05-16 10:46               ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 02/11] mtd: increase max OOB size to 744 Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15 12:12   ` Artem Bityutskiy
2013-05-15 12:12     ` Artem Bityutskiy
2013-05-15  8:40 ` [PATCH v5 03/11] mtd: get the ECC info from the parameter page for ONFI nand Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15 17:04   ` Vikram Narayanan
2013-05-16  2:21     ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 04/11] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 05/11] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 06/11] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15 16:57   ` Vikram Narayanan
2013-05-16  2:37     ` Huang Shijie
2013-05-16  4:42     ` [PATCH v5 fix] " Huang Shijie
2013-05-16  4:42       ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 07/11] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 08/11] mtd: add ECC info for nand_flash_dev{} Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15  8:40 ` [PATCH v5 09/11] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-05-15  8:40   ` Huang Shijie
2013-05-15 16:54   ` Vikram Narayanan [this message]
2013-05-16  2:40     ` Huang Shijie
2013-05-15  8:54 ` [PATCH v5 10/11] mtd: add the ecc info for some " Huang Shijie
2013-05-15  8:54   ` Huang Shijie
2013-05-15  8:54 ` [PATCH v5 11/11] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
2013-05-15  8:54   ` Huang Shijie
2013-05-15 16:31   ` Vikram Narayanan
2013-05-16  2:46     ` Huang Shijie
2013-05-16  4:49     ` [PATCH v5 fix] " Huang Shijie
2013-05-16  4:49       ` Huang Shijie
2013-05-15 10:05 ` [PATCH v5 00/11] mtd: add datasheet's ECC information to nand_chip{} Artem Bityutskiy
2013-05-15 10:05   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5193BDAA.8040909@gmail.com \
    --to=vikram186@gmail.com \
    --cc=b32955@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.